From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3329BC388F7 for ; Thu, 22 Oct 2020 09:20:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A217E2463D for ; Thu, 22 Oct 2020 09:20:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DbecBdCp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A217E2463D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1C3C6E046; Thu, 22 Oct 2020 09:20:44 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 636546E046 for ; Thu, 22 Oct 2020 09:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603358442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3jOFm9ce5hvw8xSLzH7tyekR19F8FNfDB8a9ocIepg=; b=DbecBdCpltE1zlvAieNDi/zJapfbDiZO4fyQAAlV6R1QnFN3y1CStQ2IurgXFUA+4/PLEe OHAqasBOIqMkJH68JxUrEBThaAJSQU2JcLDGbzeCly0lfzZtKa3AqLiWJqIzsCADSgia+H syI2pR59pStbnZqRKmGPTuYtIfjDnzc= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-6jHkr6BoO_mM36c42cT62w-1; Thu, 22 Oct 2020 05:20:40 -0400 X-MC-Unique: 6jHkr6BoO_mM36c42cT62w-1 Received: by mail-ej1-f71.google.com with SMTP id k23so432506ejx.0 for ; Thu, 22 Oct 2020 02:20:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e3jOFm9ce5hvw8xSLzH7tyekR19F8FNfDB8a9ocIepg=; b=s7gXpqY6NZr/9lkWy4z3lh+5N4Dz+/JKrACp0l/opQ85iFX19p1lzB5t5tnq8NyluO eaeV5TCcbneQtbsKkyB4ITxL+9Ce7SOCobmbagLxWSePDNN/GefKE+4aBzyqEt9uf8ls sR/jl7iD78kPpxbUNPqd+PU01RXhpM1DK6uGyPp4qLj7ZCMUi6mkZRcWwDWvrKFQKrA2 QTwFEghiE6lcWYpiz2/vYd7VJeg01YoGkqAQJOnZV49Nhg3GyFWf2PBQtTCMhRFYEE0f fh/vxvfkRzBR73wqLBk0MwRvFgJ8XJTdG9/wqBIbW7nlLyuwbo482vP0sF4KYmgBdnwI tYCw== X-Gm-Message-State: AOAM533BefnIC9FUTklCwgRwNSiT+YWelX8+FDg3u105AFuH0iEsJ1G2 KdCJ23NO8R03MkaHPa+xXWigSBA0SPHn1YHmuXm0wIuOsP0onFXXCGWJmJ2vdmmKJnsBP7Oxf6i KsLJnsxQyyycu9VSu1ptqzNm41zRy X-Received: by 2002:a05:6402:b8f:: with SMTP id cf15mr1342872edb.369.1603358439165; Thu, 22 Oct 2020 02:20:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHyaq9pMCEBMDvpI3ftwUCjdgIu+dlejcx9ImqKgunXgPZixX9Yjar7jmPd9v6K302tg0U9Q== X-Received: by 2002:a05:6402:b8f:: with SMTP id cf15mr1342855edb.369.1603358438935; Thu, 22 Oct 2020 02:20:38 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id qw1sm501091ejb.44.2020.10.22.02.20.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2020 02:20:38 -0700 (PDT) Subject: Re: [PATCH 0/3] drm: Store USB device in struct drm_device To: Thomas Zimmermann , airlied@linux.ie, daniel@ffwll.ch, sean@poorly.run, maarten.lankhorst@linux.intel.com, mripard@kernel.org References: <20201021130732.4048-1-tzimmermann@suse.de> From: Hans de Goede Message-ID: Date: Thu, 22 Oct 2020 11:20:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201021130732.4048-1-tzimmermann@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 10/21/20 3:07 PM, Thomas Zimmermann wrote: > The drivers gm12u320 and udl operate on USB devices. They leave the > PCI device in struct drm_device empty and store the USB device in their > own driver structure. > > Fix this special case and save a few bytes by putting the USB device > into an anonymous union with the PCI data. It's expected that DRM > core and helpers only touch the PCI-device field for actual PCI devices. > > Thomas Zimmermann (3): > drm: Add reference to USB device to struct drm_device > drm/tiny/gm12u320: Store USB device in struct drm_device.udev > drm/udl: Store USB device in struct drm_device.udev This series looks good to me: Reviewed-by: Hans de Goede Regards, Hans > > drivers/gpu/drm/tiny/gm12u320.c | 52 +++++++++++++---------------- > drivers/gpu/drm/udl/udl_connector.c | 8 ++--- > drivers/gpu/drm/udl/udl_drv.c | 2 +- > drivers/gpu/drm/udl/udl_drv.h | 1 - > drivers/gpu/drm/udl/udl_main.c | 15 +++++---- > include/drm/drm_device.h | 21 ++++++++---- > 6 files changed, 52 insertions(+), 47 deletions(-) > > -- > 2.28.0 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel