From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave Date: Thu, 13 Jun 2019 08:45:49 +0200 Message-ID: References: <20190612091253.26413-1-daniel.vetter@ffwll.ch> <20190612091253.26413-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0425675523==" Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20C6389267 for ; Thu, 13 Jun 2019 06:46:05 +0000 (UTC) In-Reply-To: <20190612091253.26413-2-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Sam Bobroff , YueHaibing , Gerd Hoffmann , Dave Airlie , Alex Deucher , Daniel Vetter , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0425675523== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GrErnbjl08T4cSMZEYhYTGmE6tWoUIZH4" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GrErnbjl08T4cSMZEYhYTGmE6tWoUIZH4 Content-Type: multipart/mixed; boundary="ARPRk6gyjrTX0CflyxvkV3LMmJNpGYzI0"; protected-headers="v1" From: Thomas Zimmermann To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Dave Airlie , Gerd Hoffmann , Alex Deucher , Sam Bobroff , Sam Ravnborg , YueHaibing Message-ID: Subject: Re: [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave References: <20190612091253.26413-1-daniel.vetter@ffwll.ch> <20190612091253.26413-2-daniel.vetter@ffwll.ch> In-Reply-To: <20190612091253.26413-2-daniel.vetter@ffwll.ch> --ARPRk6gyjrTX0CflyxvkV3LMmJNpGYzI0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Acked-by: Thomas Zimmermann Am 12.06.19 um 11:12 schrieb Daniel Vetter: > ast doesn't implement the mode_set_base_atomic hook this would need, > so this is dead code. >=20 > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Daniel Vetter > Cc: Gerd Hoffmann > Cc: Thomas Zimmermann > Cc: Alex Deucher > Cc: Sam Bobroff > Cc: Sam Ravnborg > Cc: YueHaibing > --- > drivers/gpu/drm/ast/ast_fb.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.= c > index 05f45222b702..5480caecde86 100644 > --- a/drivers/gpu/drm/ast/ast_fb.c > +++ b/drivers/gpu/drm/ast/ast_fb.c > @@ -166,8 +166,6 @@ static struct fb_ops astfb_ops =3D { > .fb_pan_display =3D drm_fb_helper_pan_display, > .fb_blank =3D drm_fb_helper_blank, > .fb_setcmap =3D drm_fb_helper_setcmap, > - .fb_debug_enter =3D drm_fb_helper_debug_enter, > - .fb_debug_leave =3D drm_fb_helper_debug_leave, > }; > =20 > static int astfb_create_object(struct ast_fbdev *afbdev, >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --ARPRk6gyjrTX0CflyxvkV3LMmJNpGYzI0-- --GrErnbjl08T4cSMZEYhYTGmE6tWoUIZH4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl0B8SkACgkQaA3BHVML eiM9XwgAnayZI4rnnxYYBsm1hUMbhu37SQSUeomkBWAvh/WdvCInFh3+yQFgUMUm WtE4KXAaeslmXz4oWWAt6Wd+WBPFf1ewY9d05KZ48KDe+n9V4Vr7X47sisHwJly/ 6ibQxlLHOIkFjX5cyV4d66NUoQw9k7hgWhq79Z5PE+Sgo8uNV7bVsxfflCEzWWpV ajZwlDtG5uTKrVbwYJCCN2adUatoquLGYJF/HL0LXYJFBk330yv6gg1vG7grnS/J Uph6gCP4RA6ADkbEOo/TGVuJi4MgBbgyaRV7orixZjjHMUPLxZINmJg6TJQqeDaH fRi83guw6qyLbIHrImkFc/kBFgIQgg== =swYE -----END PGP SIGNATURE----- --GrErnbjl08T4cSMZEYhYTGmE6tWoUIZH4-- --===============0425675523== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0425675523==--