dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: "Thomas Hellström (Intel)" <thomas_os@shipmail.org>,
	"Zack Rusin" <zackr@vmware.com>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: ttm_resource_manager::use_tt
Date: Sun, 30 May 2021 18:40:45 +0200	[thread overview]
Message-ID: <d6035638-cbf0-e17f-c8ce-abfd76e7a0cf@amd.com> (raw)
In-Reply-To: <60c9d566-608e-95c1-59d1-4d5051c1997e@shipmail.org>



Am 29.05.21 um 17:23 schrieb Thomas Hellström (Intel):
>
> On 5/28/21 9:30 PM, Zack Rusin wrote:
>> On 5/22/21 3:13 AM, Christian König wrote:
>>> Hi Zack,
>>>
>>> IIRC that was for the VMW_PL_GMR type, wasn't it?
>>>
>>> As far as I have seen that backend was just giving out unique 
>>> numbers and it looked questionable that we allocated pages for that.
>>>
>>> E.g. when you set that flag then for each allocation we also 
>>> allocate a TTM tt structure and a corresponding page.
>>>
>>
>> Got ya. Yea, it's a little messy. I think it's correct. Those unique 
>> numbers are just identifiers for the bo's but the actual memory for 
>> them is regular system memory (e.g. we just tell our virtual 
>> hardware, here's some guest system pages and here's a unique id that 
>> we'll be using the refer to them).
>>
>>
> Yes, allocating pages for that memory type is correct. The main 
> difference to other hardware here is that on other hardware those are 
> bound to gpu using a range in a translation table. With vmwgfx they 
> are bound using a slot with a unique integer..

Ok that makes more sense then. In this case just drop the TODO.

Christian.

>
> /Thomas
>
>


      reply	other threads:[~2021-05-30 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 18:17 ttm_resource_manager::use_tt Zack Rusin
2021-05-22  7:13 ` ttm_resource_manager::use_tt Christian König
2021-05-28 19:30   ` ttm_resource_manager::use_tt Zack Rusin
2021-05-29 15:23     ` ttm_resource_manager::use_tt Thomas Hellström (Intel)
2021-05-30 16:40       ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6035638-cbf0-e17f-c8ce-abfd76e7a0cf@amd.com \
    --to=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=thomas_os@shipmail.org \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox