From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C46E9C4167D for ; Fri, 3 Nov 2023 19:38:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7853D10EA4C; Fri, 3 Nov 2023 19:38:30 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 115EB10EA4C for ; Fri, 3 Nov 2023 19:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699040308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=18fxGFPyEfYX6zujRVQDCVGp1gVPnAg8xcOJqGUDNpU=; b=LnHnrA+TRTW9MeG5XpHwjxjBtQQZXcRQphtLtL+1YOfwMlQrkjEafpzCshX99FViXKsNms 3B0h/HowpPQ4gOnwcmGBGPRJcp6XtuYIUrIMTjC7wT/1duZhkNNXRLTp1yJP2LN6HgVNY0 KN5JvTfNDWjrAG0yJL55uXJg3vJ+iaI= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-xDrwUcKVOxOQUEsV1augJQ-1; Fri, 03 Nov 2023 15:38:26 -0400 X-MC-Unique: xDrwUcKVOxOQUEsV1augJQ-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-543f1c6dcaeso1831470a12.1 for ; Fri, 03 Nov 2023 12:38:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699040305; x=1699645105; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=18fxGFPyEfYX6zujRVQDCVGp1gVPnAg8xcOJqGUDNpU=; b=uR1pbgnvDiN9Rx5psXm/8oiZNfTdnBowV8+mcE0lMmUebGtLrboqvjGqI6eN1G3j9i OFXfI5q6w6EQ2KkI8l6S8R54hLlm8HdD3H1w1EPj8KKmf1q3hkDhStBo2yA4i1qLU9SU w7qPVAnVWiv7nUX1qYktKXh56uydU2hQQaxdckBqrHam5BdWx6RdiLA7gGDIelozk6o0 1SaamOqjXgNlOFzTPaCMoN7CSCZmKBu6k/WgdBlbcl+kB0VQ4YEmniIgwbTd5rhby0Q8 EaCu/uNC2yQzW+6Sggv0/a9CYQpjxi+s9gxt2ilZ/ygQtgbQT30/CS43MqfslmwEYg66 gzdg== X-Gm-Message-State: AOJu0YyMA5CuMynWhBBbD7UFXaAahZJ7GiDwuHh/GXlU/JvC2ivGwite WtzXClV+1mMXxONIyePbTjXQ2qwopjB+UI6YqY/PaZAC9aKCCTyw1vf36wPK5Y26ZhU+/F1rfBA GJgcUtpLcO5XgvEMvKGipKFtEGKg+ X-Received: by 2002:a17:907:3da1:b0:9b7:37de:6009 with SMTP id he33-20020a1709073da100b009b737de6009mr8119048ejc.3.1699040305171; Fri, 03 Nov 2023 12:38:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2EgYFYkxhAFVhtUcYX07z+ZAHa6gRCnHShMvlzepM1PxNvaeqEAxxrCtaSa8ojD2/gCJsUw== X-Received: by 2002:a17:907:3da1:b0:9b7:37de:6009 with SMTP id he33-20020a1709073da100b009b737de6009mr8119007ejc.3.1699040304766; Fri, 03 Nov 2023 12:38:24 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? ([2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id lk22-20020a170906cb1600b0099d804da2e9sm1220533ejb.225.2023.11.03.12.38.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Nov 2023 12:38:24 -0700 (PDT) Message-ID: Date: Fri, 3 Nov 2023 20:38:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled To: Mario Limonciello , Karol Herbst , Lyude Paul , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Bjorn Helgaas , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Mika Westerberg , Lukas Wunner References: <20231103190758.82911-1-mario.limonciello@amd.com> <20231103190758.82911-7-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20231103190758.82911-7-mario.limonciello@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , "open list:THUNDERBOLT DRIVER" , "open list:ACPI" , "Rafael J . Wysocki" , Michael Jamet , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Xinhui Pan , Manivannan Sadhasivam , open list , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:X86 PLATFORM DRIVERS" , Mark Gross , Yehezkel Bernat , "open list:PCI SUBSYSTEM" , Danilo Krummrich , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , Andreas Noever , "Maciej W . Rozycki" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 11/3/23 20:07, Mario Limonciello wrote: > The `is_thunderbolt` bit has been used to indicate that a PCIe device > contained the Intel VSEC which is used by various parts of the kernel > to change behavior. To later allow usage with USB4 controllers as well, > rename this to `is_tunneled`. > > Signed-off-by: Mario Limonciello Here is my ack for the trivial drivers/platform/x86/apple-gmux.c change: Acked-by: Hans de Goede Bjorn, feel free to route this through the PCI tree. Regards, Hans > --- > drivers/pci/pci.c | 2 +- > drivers/pci/probe.c | 2 +- > drivers/platform/x86/apple-gmux.c | 2 +- > include/linux/pci.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 59c01d68c6d5..d9aa5a39f585 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3032,7 +3032,7 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge) > return true; > > /* Even the oldest 2010 Thunderbolt controller supports D3. */ > - if (bridge->is_thunderbolt) > + if (bridge->is_tunneled) > return true; > > /* Platform might know better if the bridge supports D3 */ > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 795534589b98..518413d15402 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -1597,7 +1597,7 @@ static void set_pcie_thunderbolt(struct pci_dev *dev) > /* Is the device part of a Thunderbolt controller? */ > vsec = pci_find_vsec_capability(dev, PCI_VENDOR_ID_INTEL, PCI_VSEC_ID_INTEL_TBT); > if (vsec) > - dev->is_thunderbolt = 1; > + dev->is_tunneled = 1; > } > > static void set_pcie_untrusted(struct pci_dev *dev) > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 1417e230edbd..20315aa4463a 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -774,7 +774,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return to_pci_dev(dev)->is_thunderbolt; > + return to_pci_dev(dev)->is_tunneled; > } > > static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 439c2dac8a3e..b1724f25fb02 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -440,7 +440,7 @@ struct pci_dev { > unsigned int is_virtfn:1; > unsigned int is_hotplug_bridge:1; > unsigned int shpc_managed:1; /* SHPC owned by shpchp */ > - unsigned int is_thunderbolt:1; /* Thunderbolt controller */ > + unsigned int is_tunneled:1; /* Tunneled TBT or USB4 link */ > unsigned int no_command_complete:1; /* No command completion */ > /* > * Devices marked being untrusted are the ones that can potentially