From: Timur Tabi <ttabi@nvidia.com>
To: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@gmail.com" <airlied@gmail.com>
Cc: "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] nouveau/gsp: use rpc sequence numbers properly.
Date: Wed, 4 Feb 2026 21:36:34 +0000 [thread overview]
Message-ID: <d8a40e5c65e4aa51636a42fc613b223dfeb001a6.camel@nvidia.com> (raw)
In-Reply-To: <20260203052431.2219998-2-airlied@gmail.com>
On Tue, 2026-02-03 at 15:21 +1000, Dave Airlie wrote:
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
> index 2a7e80c6d70f..6e7af2f737b7 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c
> @@ -704,7 +704,7 @@ r535_gsp_rpc_set_registry(struct nvkm_gsp *gsp)
>
> build_registry(gsp, rpc);
>
> - return nvkm_gsp_rpc_wr(gsp, rpc, NVKM_GSP_RPC_REPLY_NOWAIT);
> + return nvkm_gsp_rpc_wr(gsp, rpc, NVKM_GSP_RPC_REPLY_NOSEQ);
>
> fail:
> clean_registry(gsp);
So are you saying that some RPC commands need to have a sequence number set, and some do not?
next prev parent reply other threads:[~2026-02-04 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 5:21 nouveau : fix r570 suspend/resume regression Dave Airlie
2026-02-03 5:21 ` [PATCH 1/3] nouveau/gsp: use rpc sequence numbers properly Dave Airlie
2026-02-04 21:36 ` Timur Tabi [this message]
2026-02-04 21:56 ` Dave Airlie
2026-02-05 3:00 ` John Hubbard
2026-02-05 4:37 ` Dave Airlie
2026-02-05 5:39 ` John Hubbard
2026-02-03 5:21 ` [PATCH 2/3] nouveau: add a third state to the fini handler Dave Airlie
2026-02-03 5:21 ` [PATCH 3/3] nouveau/gsp: fix suspend/resume regression on r570 firmware Dave Airlie
2026-02-03 20:08 ` nouveau : fix r570 suspend/resume regression lyude
2026-02-04 3:06 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8a40e5c65e4aa51636a42fc613b223dfeb001a6.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).