Re: [PATCH v2] accel/ivpu: Improve debug and warning messages

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 04 Nov 2025, Karol Wachowski <karol.wachowski@linux.intel.com> wrote:
> On 11/4/2025 2:00 PM, Jani Nikula wrote:
>> On Tue, 04 Nov 2025, Karol Wachowski <karol.wachowski@linux.intel.com> wrote:
>>>  #define ivpu_warn_ratelimited(vdev, fmt, ...) \
>>> -	drm_err_ratelimited(&(vdev)->drm, "%s(): " fmt, __func__, ##__VA_ARGS__)
>>> +	__drm_printk(&(vdev)->drm, warn, _ratelimited, fmt, ##__VA_ARGS__)
>> The double underscore is a hint that it's private, don't use it outside
>> of drm_print.h.
>>
>> BR,
>> Jani.
>
> Thanks, I will remove this. BTW is there a reason for
> drm_warn_ratelimited not existing in drm_print.h?

I can't think of a reason other than not having a user and not wanting
to pre-emptively add a bunch of macros that aren't used.

BR,
Jani.


-- 
Jani Nikula, Intel