From: Andrzej Hajda <a.hajda@samsung.com>
To: Baoyou Xie <baoyou.xie@linaro.org>,
jingoohan1@gmail.com, inki.dae@samsung.com,
jy0922.shim@samsung.com, sw0312.kim@samsung.com,
kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org,
krzk@kernel.org, javier@osg.samsung.com
Cc: linux-samsung-soc@vger.kernel.org, arnd@arndb.de,
xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static
Date: Tue, 20 Sep 2016 10:28:20 +0200 [thread overview]
Message-ID: <d9014b26-39fb-ee90-fbdd-dbb0a25350e2@samsung.com> (raw)
In-Reply-To: <1474207110-16111-1-git-send-email-baoyou.xie@linaro.org>
On 18.09.2016 15:58, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/exynos/exynos_dp.c:46:5: warning: no previous prototype for 'exynos_dp_crtc_clock_enable' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
next prev parent reply other threads:[~2016-09-20 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160920024446eucas1p18933d6821f5194e56b208095959ac39c@eucas1p1.samsung.com>
2016-09-18 13:58 ` [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static Baoyou Xie
2016-09-20 8:28 ` Andrzej Hajda [this message]
2016-09-25 7:54 Baoyou Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9014b26-39fb-ee90-fbdd-dbb0a25350e2@samsung.com \
--to=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jingoohan1@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).