* [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static
@ 2016-09-18 13:58 ` Baoyou Xie
2016-09-20 8:28 ` Andrzej Hajda
0 siblings, 1 reply; 3+ messages in thread
From: Baoyou Xie @ 2016-09-18 13:58 UTC (permalink / raw)
To: jingoohan1, inki.dae, jy0922.shim, sw0312.kim, kyungmin.park,
airlied, kgene, krzk, javier
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel,
arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/exynos/exynos_dp.c:46:5: warning: no previous prototype for 'exynos_dp_crtc_clock_enable' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/exynos/exynos_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c
index 4f08505..528229f 100644
--- a/drivers/gpu/drm/exynos/exynos_dp.c
+++ b/drivers/gpu/drm/exynos/exynos_dp.c
@@ -43,7 +43,7 @@ struct exynos_dp_device {
struct analogix_dp_plat_data plat_data;
};
-int exynos_dp_crtc_clock_enable(struct analogix_dp_plat_data *plat_data,
+static int exynos_dp_crtc_clock_enable(struct analogix_dp_plat_data *plat_data,
bool enable)
{
struct exynos_dp_device *dp = to_dp(plat_data);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static
2016-09-18 13:58 ` [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static Baoyou Xie
@ 2016-09-20 8:28 ` Andrzej Hajda
0 siblings, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2016-09-20 8:28 UTC (permalink / raw)
To: Baoyou Xie, jingoohan1, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, airlied, kgene, krzk, javier
Cc: linux-samsung-soc, arnd, xie.baoyou, linux-kernel, dri-devel,
linux-arm-kernel
On 18.09.2016 15:58, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/exynos/exynos_dp.c:46:5: warning: no previous prototype for 'exynos_dp_crtc_clock_enable' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static
@ 2016-09-25 7:54 Baoyou Xie
0 siblings, 0 replies; 3+ messages in thread
From: Baoyou Xie @ 2016-09-25 7:54 UTC (permalink / raw)
To: jingoohan1, inki.dae, jy0922.shim, sw0312.kim, kyungmin.park,
airlied, kgene, krzk, javier
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel,
arnd, baoyou.xie, xie.baoyou, han.fei, tang.qiang007
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/exynos/exynos_dp.c:46:5: warning: no previous prototype for 'exynos_dp_crtc_clock_enable' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/exynos/exynos_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c
index 4f08505..528229f 100644
--- a/drivers/gpu/drm/exynos/exynos_dp.c
+++ b/drivers/gpu/drm/exynos/exynos_dp.c
@@ -43,7 +43,7 @@ struct exynos_dp_device {
struct analogix_dp_plat_data plat_data;
};
-int exynos_dp_crtc_clock_enable(struct analogix_dp_plat_data *plat_data,
+static int exynos_dp_crtc_clock_enable(struct analogix_dp_plat_data *plat_data,
bool enable)
{
struct exynos_dp_device *dp = to_dp(plat_data);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-25 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160920024446eucas1p18933d6821f5194e56b208095959ac39c@eucas1p1.samsung.com>
2016-09-18 13:58 ` [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static Baoyou Xie
2016-09-20 8:28 ` Andrzej Hajda
2016-09-25 7:54 Baoyou Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).