From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2] drm/scheduler: remove timeout work_struct from drm_sched_job Date: Tue, 25 Sep 2018 19:34:16 +0200 Message-ID: References: <20180925170902.3676-1-nayan26deshmukh@gmail.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 342EE89AEB for ; Tue, 25 Sep 2018 17:34:19 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id f10-v6so3203073wrs.0 for ; Tue, 25 Sep 2018 10:34:19 -0700 (PDT) In-Reply-To: <20180925170902.3676-1-nayan26deshmukh@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nayan Deshmukh , dri-devel@lists.freedesktop.org Cc: christian.koenig@amd.com List-Id: dri-devel@lists.freedesktop.org QW0gMjUuMDkuMjAxOCB1bSAxOTowOSBzY2hyaWViIE5heWFuIERlc2htdWtoOgo+IGhhdmluZyBh IGRlbGF5ZWQgd29yayBpdGVtIHBlciBqb2IgaXMgcmVkdW5kYW50IGFzIHdlIG9ubHkgbmVlZCBv bmUKPiBwZXIgc2NoZWR1bGVyIHRvIHRyYWNrIHRoZSB0aW1lIG91dCB0aGUgY3VycmVudGx5IGV4 ZWN1dGluZyBqb2IuCj4KPiB2MjogdGhlIGZpcnN0IGVsZW1lbnQgb2YgdGhlIHJpbmcgbWlycm9y IGxpc3QgaXMgdGhlIGN1cnJlbnRseQo+IGV4ZWN1dGluZyBqb2Igc28gd2UgZG9uJ3QgbmVlZCBh IGFkZGl0aW9uYWwgdmFyaWFibGUgZm9yIGl0Cj4KPiBTaWduZWQtb2ZmLWJ5OiBOYXlhbiBEZXNo bXVraCA8bmF5YW4yNmRlc2htdWtoQGdtYWlsLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IENocmlzdGlh biBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KClJldmlld2VkLWJ5OiBDaHJpc3Rp YW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+CgpHb2luZyB0byBwdXNoIHRoYXQg aW50byBvdXIgYnJhbmNoIG9uIHRoZSBuZXh0IGJlc3Qgb2NjYXNpb24uCgpDaHJpc3RpYW4uCgo+ IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMgfCAzMSArKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gICBpbmNsdWRlL2RybS9ncHVfc2NoZWR1bGVy LmggICAgICAgICAgICB8ICA2ICsrKy0tLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspLCAxOCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v c2NoZWR1bGVyL3NjaGVkX21haW4uYyBiL2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvc2NoZWRf bWFpbi5jCj4gaW5kZXggOWNhNzQxZjNhMGJjLi40ZTg1MDVkNTE3OTUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4uYwo+IEBAIC0xOTcsMTkgKzE5NywxNSBAQCBzdGF0 aWMgdm9pZCBkcm1fc2NoZWRfam9iX2ZpbmlzaChzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4g ICAJICogbWFuYWdlcyB0byBmaW5kIHRoaXMgam9iIGFzIHRoZSBuZXh0IGpvYiBpbiB0aGUgbGlz dCwgdGhlIGZlbmNlCj4gICAJICogc2lnbmFsZWQgY2hlY2sgYmVsb3cgd2lsbCBwcmV2ZW50IHRo ZSB0aW1lb3V0IHRvIGJlIHJlc3RhcnRlZC4KPiAgIAkgKi8KPiAtCWNhbmNlbF9kZWxheWVkX3dv cmtfc3luYygmc19qb2ItPndvcmtfdGRyKTsKPiArCWNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygm c2NoZWQtPndvcmtfdGRyKTsKPiAgIAo+ICAgCXNwaW5fbG9jaygmc2NoZWQtPmpvYl9saXN0X2xv Y2spOwo+IC0JLyogcXVldWUgVERSIGZvciBuZXh0IGpvYiAqLwo+IC0JaWYgKHNjaGVkLT50aW1l b3V0ICE9IE1BWF9TQ0hFRFVMRV9USU1FT1VUICYmCj4gLQkgICAgIWxpc3RfaXNfbGFzdCgmc19q b2ItPm5vZGUsICZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCkpIHsKPiAtCQlzdHJ1Y3QgZHJtX3Nj aGVkX2pvYiAqbmV4dCA9IGxpc3RfbmV4dF9lbnRyeShzX2pvYiwgbm9kZSk7Cj4gLQo+IC0JCWlm ICghZG1hX2ZlbmNlX2lzX3NpZ25hbGVkKCZuZXh0LT5zX2ZlbmNlLT5maW5pc2hlZCkpCj4gLQkJ CXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmbmV4dC0+d29ya190ZHIsIHNjaGVkLT50aW1lb3V0KTsK PiAtCX0KPiAgIAkvKiByZW1vdmUgam9iIGZyb20gcmluZ19taXJyb3JfbGlzdCAqLwo+ICAgCWxp c3RfZGVsKCZzX2pvYi0+bm9kZSk7Cj4gKwkvKiBxdWV1ZSBURFIgZm9yIG5leHQgam9iICovCj4g KwlpZiAoc2NoZWQtPnRpbWVvdXQgIT0gTUFYX1NDSEVEVUxFX1RJTUVPVVQgJiYKPiArCSAgICAh bGlzdF9lbXB0eSgmc2NoZWQtPnJpbmdfbWlycm9yX2xpc3QpKQo+ICsJCXNjaGVkdWxlX2RlbGF5 ZWRfd29yaygmc2NoZWQtPndvcmtfdGRyLCBzY2hlZC0+dGltZW91dCk7Cj4gICAJc3Bpbl91bmxv Y2soJnNjaGVkLT5qb2JfbGlzdF9sb2NrKTsKPiAgIAo+ICAgCWRtYV9mZW5jZV9wdXQoJnNfam9i LT5zX2ZlbmNlLT5maW5pc2hlZCk7Cj4gQEAgLTIzNiwxNiArMjMyLDIxIEBAIHN0YXRpYyB2b2lk IGRybV9zY2hlZF9qb2JfYmVnaW4oc3RydWN0IGRybV9zY2hlZF9qb2IgKnNfam9iKQo+ICAgCWlm IChzY2hlZC0+dGltZW91dCAhPSBNQVhfU0NIRURVTEVfVElNRU9VVCAmJgo+ICAgCSAgICBsaXN0 X2ZpcnN0X2VudHJ5X29yX251bGwoJnNjaGVkLT5yaW5nX21pcnJvcl9saXN0LAo+ICAgCQkJCSAg ICAgc3RydWN0IGRybV9zY2hlZF9qb2IsIG5vZGUpID09IHNfam9iKQo+IC0JCXNjaGVkdWxlX2Rl bGF5ZWRfd29yaygmc19qb2ItPndvcmtfdGRyLCBzY2hlZC0+dGltZW91dCk7Cj4gKwkJc2NoZWR1 bGVfZGVsYXllZF93b3JrKCZzY2hlZC0+d29ya190ZHIsIHNjaGVkLT50aW1lb3V0KTsKPiAgIAlz cGluX3VubG9jaygmc2NoZWQtPmpvYl9saXN0X2xvY2spOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMg dm9pZCBkcm1fc2NoZWRfam9iX3RpbWVkb3V0KHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAg IHsKPiAtCXN0cnVjdCBkcm1fc2NoZWRfam9iICpqb2IgPSBjb250YWluZXJfb2Yod29yaywgc3Ry dWN0IGRybV9zY2hlZF9qb2IsCj4gLQkJCQkJCSB3b3JrX3Rkci53b3JrKTsKPiArCXN0cnVjdCBk cm1fZ3B1X3NjaGVkdWxlciAqc2NoZWQ7Cj4gKwlzdHJ1Y3QgZHJtX3NjaGVkX2pvYiAqam9iOwo+ ICsKPiArCXNjaGVkID0gY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCBkcm1fZ3B1X3NjaGVkdWxl ciwgd29ya190ZHIud29yayk7Cj4gKwlqb2IgPSBsaXN0X2ZpcnN0X2VudHJ5X29yX251bGwoJnNj aGVkLT5yaW5nX21pcnJvcl9saXN0LAo+ICsJCQkJICAgICAgIHN0cnVjdCBkcm1fc2NoZWRfam9i LCBub2RlKTsKPiAgIAo+IC0Jam9iLT5zY2hlZC0+b3BzLT50aW1lZG91dF9qb2Ioam9iKTsKPiAr CWlmIChqb2IpCj4gKwkJam9iLT5zY2hlZC0+b3BzLT50aW1lZG91dF9qb2Ioam9iKTsKPiAgIH0K PiAgIAo+ICAgLyoqCj4gQEAgLTMxNSw3ICszMTYsNyBAQCB2b2lkIGRybV9zY2hlZF9qb2JfcmVj b3Zlcnkoc3RydWN0IGRybV9ncHVfc2NoZWR1bGVyICpzY2hlZCkKPiAgIAlzX2pvYiA9IGxpc3Rf Zmlyc3RfZW50cnlfb3JfbnVsbCgmc2NoZWQtPnJpbmdfbWlycm9yX2xpc3QsCj4gICAJCQkJCSBz dHJ1Y3QgZHJtX3NjaGVkX2pvYiwgbm9kZSk7Cj4gICAJaWYgKHNfam9iICYmIHNjaGVkLT50aW1l b3V0ICE9IE1BWF9TQ0hFRFVMRV9USU1FT1VUKQo+IC0JCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygm c19qb2ItPndvcmtfdGRyLCBzY2hlZC0+dGltZW91dCk7Cj4gKwkJc2NoZWR1bGVfZGVsYXllZF93 b3JrKCZzY2hlZC0+d29ya190ZHIsIHNjaGVkLT50aW1lb3V0KTsKPiAgIAo+ICAgCWxpc3RfZm9y X2VhY2hfZW50cnlfc2FmZShzX2pvYiwgdG1wLCAmc2NoZWQtPnJpbmdfbWlycm9yX2xpc3QsIG5v ZGUpIHsKPiAgIAkJc3RydWN0IGRybV9zY2hlZF9mZW5jZSAqc19mZW5jZSA9IHNfam9iLT5zX2Zl bmNlOwo+IEBAIC0zODQsNyArMzg1LDYgQEAgaW50IGRybV9zY2hlZF9qb2JfaW5pdChzdHJ1Y3Qg ZHJtX3NjaGVkX2pvYiAqam9iLAo+ICAgCj4gICAJSU5JVF9XT1JLKCZqb2ItPmZpbmlzaF93b3Jr LCBkcm1fc2NoZWRfam9iX2ZpbmlzaCk7Cj4gICAJSU5JVF9MSVNUX0hFQUQoJmpvYi0+bm9kZSk7 Cj4gLQlJTklUX0RFTEFZRURfV09SSygmam9iLT53b3JrX3RkciwgZHJtX3NjaGVkX2pvYl90aW1l ZG91dCk7Cj4gICAKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiBAQCAtNTc1LDYgKzU3NSw3IEBAIGlu dCBkcm1fc2NoZWRfaW5pdChzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkLAo+ICAgCUlO SVRfTElTVF9IRUFEKCZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCk7Cj4gICAJc3Bpbl9sb2NrX2lu aXQoJnNjaGVkLT5qb2JfbGlzdF9sb2NrKTsKPiAgIAlhdG9taWNfc2V0KCZzY2hlZC0+aHdfcnFf Y291bnQsIDApOwo+ICsJSU5JVF9ERUxBWUVEX1dPUksoJnNjaGVkLT53b3JrX3RkciwgZHJtX3Nj aGVkX2pvYl90aW1lZG91dCk7Cj4gICAJYXRvbWljX3NldCgmc2NoZWQtPm51bV9qb2JzLCAwKTsK PiAgIAlhdG9taWM2NF9zZXQoJnNjaGVkLT5qb2JfaWRfY291bnQsIDApOwo+ICAgCj4gZGlmZiAt LWdpdCBhL2luY2x1ZGUvZHJtL2dwdV9zY2hlZHVsZXIuaCBiL2luY2x1ZGUvZHJtL2dwdV9zY2hl ZHVsZXIuaAo+IGluZGV4IGRhZWM1MGY4ODdiMy4uZDg3YjI2OGYxNzgxIDEwMDY0NAo+IC0tLSBh L2luY2x1ZGUvZHJtL2dwdV9zY2hlZHVsZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2dwdV9zY2hl ZHVsZXIuaAo+IEBAIC0xNzUsOCArMTc1LDYgQEAgc3RydWN0IGRybV9zY2hlZF9mZW5jZSAqdG9f ZHJtX3NjaGVkX2ZlbmNlKHN0cnVjdCBkbWFfZmVuY2UgKmYpOwo+ICAgICogICAgICAgICAgICAg ICBmaW5pc2hlZCB0byByZW1vdmUgdGhlIGpvYiBmcm9tIHRoZQo+ICAgICogICAgICAgICAgICAg ICBAZHJtX2dwdV9zY2hlZHVsZXIucmluZ19taXJyb3JfbGlzdC4KPiAgICAqIEBub2RlOiB1c2Vk IHRvIGFwcGVuZCB0aGlzIHN0cnVjdCB0byB0aGUgQGRybV9ncHVfc2NoZWR1bGVyLnJpbmdfbWly cm9yX2xpc3QuCj4gLSAqIEB3b3JrX3Rkcjogc2NoZWR1bGVzIGEgZGVsYXllZCBjYWxsIHRvIEBk cm1fc2NoZWRfam9iX3RpbWVkb3V0IGFmdGVyIHRoZSB0aW1lb3V0Cj4gLSAqICAgICAgICAgICAg aW50ZXJ2YWwgaXMgb3Zlci4KPiAgICAqIEBpZDogYSB1bmlxdWUgaWQgYXNzaWduZWQgdG8gZWFj aCBqb2Igc2NoZWR1bGVkIG9uIHRoZSBzY2hlZHVsZXIuCj4gICAgKiBAa2FybWE6IGluY3JlbWVu dCBvbiBldmVyeSBoYW5nIGNhdXNlZCBieSB0aGlzIGpvYi4gSWYgdGhpcyBleGNlZWRzIHRoZSBo YW5nCj4gICAgKiAgICAgICAgIGxpbWl0IG9mIHRoZSBzY2hlZHVsZXIgdGhlbiB0aGUgam9iIGlz IG1hcmtlZCBndWlsdHkgYW5kIHdpbGwgbm90Cj4gQEAgLTE5NSw3ICsxOTMsNiBAQCBzdHJ1Y3Qg ZHJtX3NjaGVkX2pvYiB7Cj4gICAJc3RydWN0IGRtYV9mZW5jZV9jYgkJZmluaXNoX2NiOwo+ICAg CXN0cnVjdCB3b3JrX3N0cnVjdAkJZmluaXNoX3dvcms7Cj4gICAJc3RydWN0IGxpc3RfaGVhZAkJ bm9kZTsKPiAtCXN0cnVjdCBkZWxheWVkX3dvcmsJCXdvcmtfdGRyOwo+ICAgCXVpbnQ2NF90CQkJ aWQ7Cj4gICAJYXRvbWljX3QJCQlrYXJtYTsKPiAgIAllbnVtIGRybV9zY2hlZF9wcmlvcml0eQkJ c19wcmlvcml0eTsKPiBAQCAtMjU5LDYgKzI1Niw4IEBAIHN0cnVjdCBkcm1fc2NoZWRfYmFja2Vu ZF9vcHMgewo+ICAgICogICAgICAgICAgICAgICAgIGZpbmlzaGVkLgo+ICAgICogQGh3X3JxX2Nv dW50OiB0aGUgbnVtYmVyIG9mIGpvYnMgY3VycmVudGx5IGluIHRoZSBoYXJkd2FyZSBxdWV1ZS4K PiAgICAqIEBqb2JfaWRfY291bnQ6IHVzZWQgdG8gYXNzaWduIHVuaXF1ZSBpZCB0byB0aGUgZWFj aCBqb2IuCj4gKyAqIEB3b3JrX3Rkcjogc2NoZWR1bGVzIGEgZGVsYXllZCBjYWxsIHRvIEBkcm1f c2NoZWRfam9iX3RpbWVkb3V0IGFmdGVyIHRoZQo+ICsgKiAgICAgICAgICAgIHRpbWVvdXQgaW50 ZXJ2YWwgaXMgb3Zlci4KPiAgICAqIEB0aHJlYWQ6IHRoZSBrdGhyZWFkIG9uIHdoaWNoIHRoZSBz Y2hlZHVsZXIgd2hpY2ggcnVuLgo+ICAgICogQHJpbmdfbWlycm9yX2xpc3Q6IHRoZSBsaXN0IG9m IGpvYnMgd2hpY2ggYXJlIGN1cnJlbnRseSBpbiB0aGUgam9iIHF1ZXVlLgo+ICAgICogQGpvYl9s aXN0X2xvY2s6IGxvY2sgdG8gcHJvdGVjdCB0aGUgcmluZ19taXJyb3JfbGlzdC4KPiBAQCAtMjc4 LDYgKzI3Nyw3IEBAIHN0cnVjdCBkcm1fZ3B1X3NjaGVkdWxlciB7Cj4gICAJd2FpdF9xdWV1ZV9o ZWFkX3QJCWpvYl9zY2hlZHVsZWQ7Cj4gICAJYXRvbWljX3QJCQlod19ycV9jb3VudDsKPiAgIAlh dG9taWM2NF90CQkJam9iX2lkX2NvdW50Owo+ICsJc3RydWN0IGRlbGF5ZWRfd29yawkJd29ya190 ZHI7Cj4gICAJc3RydWN0IHRhc2tfc3RydWN0CQkqdGhyZWFkOwo+ICAgCXN0cnVjdCBsaXN0X2hl YWQJCXJpbmdfbWlycm9yX2xpc3Q7Cj4gICAJc3BpbmxvY2tfdAkJCWpvYl9saXN0X2xvY2s7Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK