From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D778CD5BC9 for ; Mon, 25 May 2026 13:35:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD82310E36B; Mon, 25 May 2026 13:35:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="cHlgJ/mC"; dkim-atps=neutral Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6129710E36B for ; Mon, 25 May 2026 13:35:11 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-43d75312379so8030417f8f.1 for ; Mon, 25 May 2026 06:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779716110; x=1780320910; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9XVHRPBSt9KXo5wrulw6nEDVPqzcFN/DF35DZwL4F0c=; b=cHlgJ/mC/Ss3ADRJgm1FGw0NOmKtRMIrE6E0BHrO33kpnI7P+OdRp4KB3VhrM0BBVa 0cGF3ucW+7qDmxU4vAgmW7ybj6zbZvhZj8na4yWhHbzF9sBkw2LTMDTFY4DjGnPzzDmu hBSNFyzOXN7Kg6Gbrc6LR7OQcCbLVuapB95D/P/zZdCKeE/wjwP4e6ll+vLwSq1HVruf n/MepGWWcSk2wimo7dYuM/ra5evbRVef/iFwjKF1LnJ9roUCrv40IK8Iil8Y8/PTgkZ/ pGjf2QHxh0scfkYvd+lLpncu7aDFdL6X/5gnbaV090luYRXlpDFqVCu5QnRhM5RS+7gO ug2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779716110; x=1780320910; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9XVHRPBSt9KXo5wrulw6nEDVPqzcFN/DF35DZwL4F0c=; b=qsJ6aBblZXEptY9bxOkiOFtwMxvmIwooYjJVSio1ZAzzD3jQY1KIhNMvrxoa3yOwW5 NgcGvzLoDDeexI+E8MVusDNZ2lVGQaKBUFRETpna0xMZKM3Mnq/pQrofBCPosnRK/21t OmUdtL4Ld0wKGKkJNYWprFml1sam8BWnp2mZ8mF8okyrbRjYiGT1npNo1EPKdDEIxevE +3UPueKr9PR6FaTSConfqNw61huuFlpOv6Jq2FehR4+0hNIop9pPpcg1QVI1paZFkUt3 s2Vj1MxX14Qeuh7Qy6niw9ZmIQ6y9HkpkvIebqwhcSKqRAVesqEl2IvBKiP3NtRZGc9x LOwQ== X-Forwarded-Encrypted: i=1; AFNElJ/aWCfuNagpfQ1GQGyoBGPbms6B2v6as3gPlN3CfiDMh32PmeqQWmr5SbTHTxDHccxKqT2S5/tWLJs=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwdKTJDlygXSyN+QFaaMyewuCwDZ6x6sS2eWg1psNaKxs27A+xA veef8a7ea9Ow9FAWMPNqheKaY6Vm4BAEhl+Dmzo4eixZoERgfVpTZNR1LQw8hp/gcdA= X-Gm-Gg: Acq92OHPqQVL+LoSSxyXeLoejlwaxlg5/LlP/Wv4LSaluYCB2741PIEdbyYppbs46xu AhULuajflxDgjgpJzhp9YbAv7DUBTeXjK3eSfblbVu2IXclkeEx9DCVXbWHejTRXZ9QXRsShh4D k0HDFTC1+u4lEWZdV5DDu5CCmnAv3Ks8r7J0JTHYJnnPjyGUvX7tVFsF8lgd0fKDpvpJ/R2e5xd jd6bCvpcQttg2nzv9gNL2OmbUhG56hL74Ds+O4YJexzFxjCWtLZ4Hm9w6xnpbKtV3iKJzvlEHlM ckmQiJb9nwWO4SZfmKuGUb6+Gv+jgEXIDvSR2VKZcG+AfiUkE0sf2eaD/1yzdtEMkCiEQAoS8cO p6mpsIKU/NjvmvjV4j9flj41xt8bXpNpGqnol0fUOUcNy2gLIWZnWNvsdO/1RF0YQwfb1WxiHtO kzgNZRNZpAYfPT4zGQs0P2u9P5AOQKZACh4LM2thVQhdnae61Y3UJTRWI09kZ+Mj2STzR7GuEI6 ITOkIaEQxgAkQRNETfnCuFN26HohWULVAo8D2Ft0Ivg6eDiN4ruEZ9WG+tqdcgp0tQZuw== X-Received: by 2002:a05:6000:2008:b0:45e:8cdc:4ee8 with SMTP id ffacd0b85a97d-45ea3128ccdmr31052715f8f.6.1779716109692; Mon, 25 May 2026 06:35:09 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d5cb9asm29456456f8f.27.2026.05.25.06.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 06:35:09 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 15:35:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] treewide: Convert struct kernel_param_ops initializers to DEFINE_KERNEL_PARAM_OPS To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-4-kees@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260521133326.2465264-4-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 5/21/26 3:33 PM, Kees Cook wrote: > Using Coccinelle, rewrite every struct kernel_param_ops initializer that > sets .get into a DEFINE_KERNEL_PARAM_OPS-family macro invocation, > for example: > > @@ > declarer name DEFINE_KERNEL_PARAM_OPS; > identifier OPS; > expression SET, GET; > @@ > - const struct kernel_param_ops OPS = { > - .set = SET, > - .get = GET, > - }; > + DEFINE_KERNEL_PARAM_OPS(OPS, SET, GET); > > Using the macro for initialization means future changes can manipulate > the struct layout and callback prototypes without having to change every > initializer. Nit: For consistency, I suggest also converting the few remaining kernel_param_ops instances that specify only .set and no .get, such as simdisk_param_ops_filename. -- Thanks, Petr