From: "Christian König" <christian.koenig@amd.com>
To: xinhui pan <xinhui.pan@amd.com>, amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: Put BO in its memory manager's lru list
Date: Tue, 9 Nov 2021 13:20:50 +0100 [thread overview]
Message-ID: <da46c607-1a3c-7ea9-92ef-78a2b60d38c9@amd.com> (raw)
In-Reply-To: <20211109111954.41968-1-xinhui.pan@amd.com>
Am 09.11.21 um 12:19 schrieb xinhui pan:
> After we move BO to a new memory region, we should put it to
> the new memory manager's lru list regardless we unlock the resv or not.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
Interesting find, did you trigger that somehow or did you just stumbled
over it by reading the code?
Patch is Reviewed-by: Christian König <christian.koenig@amd.com>, I will
pick that up for drm-misc-next.
Thanks,
Christian.
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index f1367107925b..e307004f0b28 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -701,6 +701,8 @@ int ttm_mem_evict_first(struct ttm_device *bdev,
> ret = ttm_bo_evict(bo, ctx);
> if (locked)
> ttm_bo_unreserve(bo);
> + else
> + ttm_bo_move_to_lru_tail_unlocked(bo);
>
> ttm_bo_put(bo);
> return ret;
next prev parent reply other threads:[~2021-11-09 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 11:19 [PATCH] drm/ttm: Put BO in its memory manager's lru list xinhui pan
2021-11-09 12:20 ` Christian König [this message]
2021-11-09 12:28 ` 回复: " Pan, Xinhui
2021-11-09 12:35 ` Christian König
2021-11-09 13:05 ` 回复: " Pan, Xinhui
2021-11-09 13:16 ` Pan, Xinhui
2021-11-09 13:18 ` Christian König
2021-11-09 13:41 ` 回复: " Pan, Xinhui
2021-11-09 13:59 ` Christian König
2022-01-11 8:47 ` Chen, Guchun
2022-01-11 11:27 ` Christian König
2022-01-12 2:19 ` Chen, Guchun
2022-01-12 7:00 ` Christian König
2021-11-09 13:16 ` 回复: " Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da46c607-1a3c-7ea9-92ef-78a2b60d38c9@amd.com \
--to=christian.koenig@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=xinhui.pan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox