From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [ADV7393] DRM Encoder Slave or DRM Bridge Date: Mon, 26 Sep 2016 15:30:04 +0300 Message-ID: References: <52026ed7-fbfc-48a0-b2ea-07577d49231d@ti.com> <3958e459-2127-4450-9749-913365949996@ti.com> <406769ce-bbd0-c517-3006-c5f1ab6ff511@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0548816919==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F8F76E41A for ; Mon, 26 Sep 2016 12:30:11 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vikas Patil Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org --===============0548816919== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6SAT7PRPxIXkrHgMEHleGSv3TCIDKMcIX" --6SAT7PRPxIXkrHgMEHleGSv3TCIDKMcIX Content-Type: multipart/mixed; boundary="wbset49lWpLXx55HXDLWWWdrMKttijPa3"; protected-headers="v1" From: Tomi Valkeinen To: Vikas Patil Cc: "dri-devel@lists.freedesktop.org" , Rob Clark , architt@codeaurora.org Message-ID: Subject: Re: [ADV7393] DRM Encoder Slave or DRM Bridge References: <52026ed7-fbfc-48a0-b2ea-07577d49231d@ti.com> <3958e459-2127-4450-9749-913365949996@ti.com> <406769ce-bbd0-c517-3006-c5f1ab6ff511@ti.com> In-Reply-To: --wbset49lWpLXx55HXDLWWWdrMKttijPa3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/09/16 15:25, Vikas Patil wrote: > On Fri, Sep 23, 2016 at 4:30 PM, Tomi Valkeinen = wrote: >> On 22/09/16 16:22, Vikas Patil wrote: >> >>> Could you help me to understand if I could use =E2=80=9Cinterlace=3Df= alse=E2=80=9D? >>> ADV7393 seems to be supporting non-interlaced mode. From datasheet: >>> =E2=80=9CThe ADV7390/ADV7391/ADV7392/ADV7393 support an SD noninterla= ced mode. >>> Using this mode, progressive inputs at twice the frame rate of NTSC >>> and PAL (240p/59.94 Hz and 288p/50 Hz, respectively) can be input int= o >>> the ADV7390/ ADV7391/ADV7392/ADV7393. The SD noninterlaced mode can b= e >>> enabled using Subaddress 0x88, Bit 1.=E2=80=9D >> >> Difficult to say... So OMAP4+ DSS hardware does support interlace outp= ut >> for DPI. The driver has never supported it, nor do I have any hardware= >> to test it. It might be quite easy to add, though. >> > If it is easy and doable then could you describe what I need to do to > support it? I think there are a few problems there, as the analog connector wasn't designed to support detection. But you can check the detect callback from the encoder/connector drivers. The problem is, it returns a bool, whereas we need a tristate return value here to represent connected, not connected, unknown. >> If I read the above snippet right, to use progressive input, the DISPC= >> needs to output at double refresh rate. So probably what you would hav= e >> to do is in ADV driver, you have your set_timings function, where you >> should double the pix clock before you pass the timings forward to the= >> DISPC's DPI driver. >> >=20 > I have configured ADV7393 chip in following mode with the timing below > in connector-analog.tv.c. With this I am seeing continuous flicker > with nothing on display (black screen) and sometime could see the > kmscube but it seems it renders in four quadrant(i.e. once in each > quadrant). I have also tried doubling the pixel clock from 27MHz to > 54MHz in timing for non-interlaced mode of ADV7393 but with it also > nothing on display and continuous flicker. >=20 > Do you know what might be going wrong? What should I look for to fix th= is? >=20 > ** ADV config: > - 16-bit SD RGB input > - NTSC mode > - YPrPb component output (CVBS) > - non-interlaced mode >=20 > ** Timing configured in in connector-analog.tv.c >=20 > static const struct omap_video_timings harman_ntsc_timings =3D { > .x_res =3D 720, > .y_res =3D 480, > .pixelclock =3D 270000000, That's 270MHz. Tomi --wbset49lWpLXx55HXDLWWWdrMKttijPa3-- --6SAT7PRPxIXkrHgMEHleGSv3TCIDKMcIX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6RTNAAoJEPo9qoy8lh71jSYP/RO8z5tVYSuoZsJtBt41AdyN z8HeUckpcnPt9HsbTBg1468sCliK3mTsNxPLKWmjKh9HnlQDrxqbZU6/fHSsWdaz arZTBapeet1QT6bnnhdtwFqDpokk4CgocQ65TVQ7A4XUU++iP4NxoH7jatXqAibk VpgqgdTN+uYDBIrNhANQTb46GBA+m7J/s3vQRXLFcfEPYh4PLKl/gkrqxbnb1I0V 7tjBZCMUpAKdP459PfwhlYhZhCr00uZ5IIwjykESfahe/esY/odTQUjCaSOF8Ims MPO+xKkEUIumFbXNGyy9T7gORAh2nmVhI/yedLX8gLBHqg+7/Cpr38eh8Om6ypEX a3IuKJFoHyhSAxH7zZH6d4wyYCiKAsx4iUR/VjERHd0oEhzrj4ichUE4cb+PHPMx i1SKfPsrxmD6OFu01pHikrBTf+72JzZvJmqOSY5H9bpcc2NAOFDlsK/dhG/HqOec C5HWRu/lHClcKMl5oxxs5MurJ06xFQpdOZx9d86msPsMOFazHX83MQ9BZiTJkSH2 YdCcrOnN1T53YVUEOC1EBaBt6llZsWHl5PQRKAh2hYKntRuOgCFljsggCZAZlwNk huA8iK187TEqJkFlRGxDkSFdGKJgKiOgNRh4m0fkEbFXUjd/KQ34UkraAab+nqnO 8g9DSLxqe2RXQzKYcG28 =/SRR -----END PGP SIGNATURE----- --6SAT7PRPxIXkrHgMEHleGSv3TCIDKMcIX-- --===============0548816919== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0548816919==--