From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F901C433E1 for ; Fri, 10 Jul 2020 07:53:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F9B22077D for ; Fri, 10 Jul 2020 07:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F9B22077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13B546EBA6; Fri, 10 Jul 2020 07:53:04 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 181D96E04B for ; Thu, 9 Jul 2020 10:47:19 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 72D912A3CAC Subject: Re: [RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder From: Enric Balletbo i Serra To: Boris Brezillon References: <20200518173909.2259259-1-enric.balletbo@collabora.com> <20200518173909.2259259-4-enric.balletbo@collabora.com> <20200701134128.6a967a89@collabora.com> <3f7338ad-b83d-da1d-2b07-f5225c56d7f9@collabora.com> Message-ID: Date: Thu, 9 Jul 2020 12:47:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3f7338ad-b83d-da1d-2b07-f5225c56d7f9@collabora.com> Content-Language: en-US X-Mailman-Approved-At: Fri, 10 Jul 2020 07:52:58 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , drinkcat@chromium.org, narmstrong@baylibre.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, a.hajda@samsung.com, linux-mediatek@lists.infradead.org, laurent.pinchart@ideasonboard.com, hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi again, On 8/7/20 17:12, Enric Balletbo i Serra wrote: > Hi Boris, > > Thank you to spend some time to review the patches. > > On 1/7/20 13:41, Boris Brezillon wrote: >> On Mon, 18 May 2020 19:39:09 +0200 >> Enric Balletbo i Serra wrote: >> >>> The mtk_dpi driver uses an empty implementation for its encoder. Replace >>> the code with the generic simple encoder. >>> >>> Signed-off-by: Enric Balletbo i Serra >>> Reviewed-by: Chun-Kuang Hu >>> --- >>> >>> drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++----------- >>> 1 file changed, 3 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c >>> index baad198c69eb..80778b2aac2a 100644 >>> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c >>> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c >>> @@ -20,6 +20,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include "mtk_dpi_regs.h" >>> #include "mtk_drm_ddp_comp.h" >>> @@ -510,15 +511,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi, >>> return 0; >>> } >>> >>> -static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder) >>> -{ >>> - drm_encoder_cleanup(encoder); >>> -} >>> - >>> -static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = { >>> - .destroy = mtk_dpi_encoder_destroy, >>> -}; >>> - >>> static int mtk_dpi_bridge_attach(struct drm_bridge *bridge, >>> enum drm_bridge_attach_flags flags) >>> { >>> @@ -591,8 +583,8 @@ static int mtk_dpi_bind(struct device *dev, struct device *master, void *data) >>> return ret; >>> } >>> >>> - ret = drm_encoder_init(drm_dev, &dpi->encoder, &mtk_dpi_encoder_funcs, >>> - DRM_MODE_ENCODER_TMDS, NULL); >>> + ret = drm_simple_encoder_init(drm_dev, &dpi->encoder, >>> + DRM_MODE_ENCODER_TMDS); >> >> Not related to this change, but shouldn't we have DRM_MODE_ENCODER_DPI >> here? >> > Thinking a bit more about this and this patchset in general, I think I'll drop this patch from the series, at the end, all the encoder creation stuff should be moved to mtk_drm_drv. > Right, I'll add a patch to fix this. > >>> if (ret) { >>> dev_err(dev, "Failed to initialize decoder: %d\n", ret); >>> goto err_unregister; >> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel