From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F1CAC71136 for ; Fri, 13 Jun 2025 14:02:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77C2210E9D0; Fri, 13 Jun 2025 14:02:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="JBCe5/Uo"; dkim-atps=neutral Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9F6410E9D0 for ; Fri, 13 Jun 2025 14:02:37 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4530e6f4db4so2122525e9.2 for ; Fri, 13 Jun 2025 07:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749823356; x=1750428156; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=BR72CRYf/tZsZyJh78bV+xCODP+r79zbrQtaAW04L5w=; b=JBCe5/UomoLSinTXOnRk2vc5P8xNetUKJc1VfKW4jvI0fVLpC1IRHDxyNW0q3uGS2H aIlcTOqrxTd5IEbZoCUEvsNxCT81262zs1rvFxtpqPotf2TaVeSn/v3LCx4xJ5IwG0e9 H52F9PDyndsx3mNypomL00d8cMwzL8CFRVTOyVoQCefhYiZtHBHHbVIBww2G71zzcY1E QW2RqHg9QoKG75iTs06x+r+4Ke9MrxQkcOe+csCrIyWV9DgNAsBBOufe/sS2Q48CAHs8 nRY0tRfWm3bgyMVckLpKoJ/3gkL9XDiJqgBRfgxLp7/uApQXhJKERBSOXlWnUeTFP2EH OSxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749823356; x=1750428156; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BR72CRYf/tZsZyJh78bV+xCODP+r79zbrQtaAW04L5w=; b=harWDZt7KTWVZrIsGHCs8ojdaKL+I12wZ9dBHz+8jGD8P202PRTsR5kGuCBG3xgjyw Q4HxSsAeOi+3iEzhZl6+pAhc2ANFXKk5uswmbxmYjKTAGqVL79zrPnTJ8szsmpchMlsV xPfrNI/9HL3pfVo+nCvgTb08iLw3IgKliSP0fwj4yesaNawCc27Hg2bt8ya3wQg3n/E8 o3uBgSkqWd0aZJR+BGAYJv3/zHBziw5jIK1vyV+SIVZh0PGdoNRuT96zG8oleIJPU1ro KOn5DE3J2M38vqN2mU2QwY2wTXCppJ0eqvxS+zpmKC228LO1ZlUYwTaqOBrcgshVIuI9 WMCQ== X-Forwarded-Encrypted: i=1; AJvYcCVAIWC6Z44QDNjs/CSk8LMzfwasBX8D6BjDH/r7yHpXgBmMF28qIOGZbmZ07nuTxuRWLNzstktQIPI=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxEQVYrpAfep0y0MFDUCXCHMOl27f69DIR2utAjzkrJfHa7P5Ec zGqACfobj5i61hhPxSzShh5P12Xm2fPrpZBrofNSC4G+Y1MOrI2WGpHPq62Cq+yQTJk= X-Gm-Gg: ASbGncusficDVyioaXJw85uCLenm+9q9I6WY6idWWbI5m8vi34bKu2rQuqTodRLiTAs DdmV2moQdbi5vof95ySjjxdcr/c+B1MgofYnRRlmXiiaK+NB48C1skrMAW39ieNs+Rn6RZSF67j 0VfN1JDJE8e1VCF5UzNP60i5WzlDKMjoCTPHLBf9Tl1zBXOeKEo5Y+Cv9H83dNjWh4+HxUQ/swB O/EoypADJT3reNWov15ut2DC4yrjC5R0oJOcq3YReBbH8SOGIq3GsCS0QXYwh98JkdzKounKOao vo0cSQi/aOKTj9rPR/EQv/CGju+jYYAOmpMCb1aFlsHpItyuQ+w+oAevxjzUIlkLFN8MrqC2PP1 hK0uoY/w= X-Google-Smtp-Source: AGHT+IFFm+p6A3s3c92JdQ/PjxjL4ne6Il5/xS3QixUN9WcusvUDpgO0/WQqRAfuIGx27EXI54dhVA== X-Received: by 2002:a05:600c:858d:b0:439:a30f:2e49 with SMTP id 5b1f17b1804b1-45334ad8375mr9408615e9.5.1749823354507; Fri, 13 Jun 2025 07:02:34 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a612d8sm2464566f8f.24.2025.06.13.07.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 07:02:33 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 16:02:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 08/17] drm/msm/dsi/phy: Fix reading zero as PLL rates when unprepared To: Dmitry Baryshkov Cc: Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Clark , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Abel Vesa , Srinivas Kandagatla References: <20250610-b4-sm8750-display-v6-0-ee633e3ddbff@linaro.org> <20250610-b4-sm8750-display-v6-8-ee633e3ddbff@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 13/06/2025 15:55, Dmitry Baryshkov wrote: >> >> @@ -361,24 +373,47 @@ static int dsi_pll_7nm_lock_status(struct dsi_pll_7nm *pll) >> >> static void dsi_pll_disable_pll_bias(struct dsi_pll_7nm *pll) >> { >> + unsigned long flags; >> u32 data; >> >> + spin_lock_irqsave(&pll->pll_enable_lock, flags); >> + --pll->pll_enable_cnt; >> + if (pll->pll_enable_cnt < 0) { >> + spin_unlock_irqrestore(&pll->pll_enable_lock, flags); >> + DRM_DEV_ERROR_RATELIMITED(&pll->phy->pdev->dev, >> + "bug: imbalance in disabling PLL bias\n"); >> + return; >> + } else if (pll->pll_enable_cnt > 0) { >> + spin_unlock_irqrestore(&pll->pll_enable_lock, flags); >> + return; >> + } /* else: == 0 */ >> + >> data = readl(pll->phy->base + REG_DSI_7nm_PHY_CMN_CTRL_0); >> data &= ~DSI_7nm_PHY_CMN_CTRL_0_PLL_SHUTDOWNB; >> writel(0, pll->phy->pll_base + REG_DSI_7nm_PHY_PLL_SYSTEM_MUXES); >> writel(data, pll->phy->base + REG_DSI_7nm_PHY_CMN_CTRL_0); >> + spin_unlock_irqrestore(&pll->pll_enable_lock, flags); >> ndelay(250); > > What is this ndelay protecting? Is is to let the hardware to wind down > correctly? I'm worried about dsi_pll_disable_pll_bias() beng followed up > by dsi_pll_enable_pll_bias() in another thread, which would mean that > corresponding writes to the REG_DSI_7nm_PHY_CMN_CTRL_0 can come up > without any delay between them. > Great question, but why do you ask me? The code was there already and MSM DRM drivers are not something I know and could provide context about. Best regards, Krzysztof