Re: [PATCH 21/33] drm/panel-simple: Fix dotclock for Logic PD Type 28

Ville Syrjälä
2020-03-11T14:46:56Z

On Tue, Mar 03, 2020 at 07:00:12AM -0600, Adam Ford wrote:
> On Mon, Mar 2, 2020 at 2:36 PM Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The currently listed dotclock disagrees with the currently
> > listed vrefresh rate. Change the dotclock to match the vrefresh.
> >
> > Someone tell me which (if either) of the dotclock or vreresh is
> > correct?
> >
> > Cc: Adam Ford <aford173@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 225be4757a85..3a46b82722f5 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2277,7 +2277,7 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> > };
> >
> > static const struct drm_display_mode logicpd_type_28_mode = {
> > - .clock = 9000,
> > + .clock = 9107,
>
> This should be OK. The max dotclk frequency of this panel is 12MHz,
> so 9.107MHz should be just fine.
>
> Reviewed-by: Adam Ford <aford173@gmail.com>

Thanks. Pushed to drm-misc-next.

--
Ville Syrjälä
Intel