Re: [PATCH 21/33] drm/panel-simple: Fix dotclock for Logic PD Type 28

Adam Ford
2020-03-03T13:00:26Z

On Mon, Mar 2, 2020 at 2:36 PM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The currently listed dotclock disagrees with the currently
> listed vrefresh rate. Change the dotclock to match the vrefresh.
>
> Someone tell me which (if either) of the dotclock or vreresh is
> correct?
>
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 225be4757a85..3a46b82722f5 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2277,7 +2277,7 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> };
>
> static const struct drm_display_mode logicpd_type_28_mode = {
> - .clock = 9000,
> + .clock = 9107,

This should be OK. The max dotclk frequency of this panel is 12MHz,
so 9.107MHz should be just fine.

Reviewed-by: Adam Ford <aford173@gmail.com>

adam
> .hdisplay = 480,
> .hsync_start = 480 + 3,
> .hsync_end = 480 + 3 + 42,
> --
> 2.24.1