Re: [PATCH 05/33] drm/panel-leadtek-ltk500hd1829: Fix dotclock

Heiko Stuebner
2020-04-03T06:54:32Z

Am Donnerstag, 2. April 2020, 15:13:10 CEST schrieb Ville Syrjälä:
> On Tue, Mar 03, 2020 at 01:52:27PM +0100, Heiko Stuebner wrote:
> > Hi,
> >
> > Am Montag, 2. März 2020, 21:34:24 CET schrieb Ville Syrjala:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The currently listed dotclock disagrees with the currently
> > > listed vrefresh rate. Change the dotclock to match the vrefresh.
> > >
> > > Someone tell me which (if either) of the dotclock or vreresh is
> > > correct?
> >
> > The values came that way from the vendor .
> > And lookin at other Leadtek display datasheets, 60Hz should be the
> > correct refresh rate.
> >
> > The display is also running happily at the 69MHz of
> > your patch, so
> >
> > Tested-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> Thanks for confirming.
>
> I think this patch the last one with a huge difference between
> vrefresh and clock. So once this goes in I'm thinking of declaring
> the remaining patches as not important and pushing ahead with the
> mode dieting. Can someone ack this so I can get it in?

hmm, not sure which one you want, so please pick one
Acked-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

or for the address I use whan applying drm-misc commits:
Acked-by: Heiko Stuebner <heiko@sntech.de>

Heiko

> > >
> > > Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
> > > index 76ecf2de9c44..113ab9c0396b 100644
> > > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
> > > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
> > > @@ -377,7 +377,7 @@ static const struct drm_display_mode default_mode = {
> > > .vsync_end = 1280 + 30 + 4,
> > > .vtotal = 1280 + 30 + 4 + 12,
> > > .vrefresh = 60,
> > > - .clock = 41600,
> > > + .clock = 69217,
> > > .width_mm = 62,
> > > .height_mm = 110,
> > > };
> > >
> >
> >
> >