From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Kuehling Subject: Re: [PATCH 1/1] drm/amdkfd: Do not ignore requested queue size during allocation Date: Fri, 1 Dec 2017 14:37:30 -0500 Message-ID: References: <20171116213631.3987-1-jan.vesely@rutgers.edu> <21e77adc-4fbe-a3e9-0a02-5d84eb201561@amd.com> <1511991803.2978.67.camel@rutgers.edu> <772df39e-167a-6404-4330-913718560b2f@amd.com> <1512085889.3631.50.camel@rutgers.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1512085889.3631.50.camel-kgbqMDwikbSVc3sceRu5cw@public.gmane.org> Content-Language: en-CA List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Jan Vesely , Oded Gabbay Cc: amd-gfx list , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org Ck9uIDIwMTctMTEtMzAgMDY6NTEgUE0sIEphbiBWZXNlbHkgd3JvdGU6Cj4KPiBJdCdzIG5vdCBh IHVzZXJzcGFjZSBxdWV1ZSB0aGF0IHN0b3BzLiBJJ20gdXNpbmcga2VybmVsIGRiZ2RldiB0byBp c3N1ZQo+IHdhdmVfcmVzdW1lIGNvbW1hbmRzLiAod2F2ZXMgYXJlIGhhbHRlZCBhZnRlciBleGVj dXRpbmcKPiBzX3NlbmRtc2dfaGFsdCkuCj4gSSBidW1wZWQgS0ZEX0tFUk5FTF9RVUVVRV9TSVpF IHRvIDE2S0IgdG8gbWFrZSBzdXJlIGFsbCAzMjAgcmVzdW1lCj4gY29tbWFkcyBmaXQgKG90aGVy d2lzZSBJIGdldCBzcHVyaW91cyBFTk9NRU0gd2hlbiB0aGUgcXVldWUgaXMgZnVsbCBidXQKPiBz dGlsbCBhZHZhbmNpbmcpLgoKU29ycnksIGRpZG4ndCBzZWUgdGhpcyBwYXJ0IG9mIHlvdXIgbWVz c2FnZSBiZWZvcmUuCgpUbyBzZWUgdGhlIGFjdHVhbCBzdGF0ZSBvZiB0aGUgRElRIGluIHRoZSBo YXJkd2FyZSwgeW91IHNob3VsZCBsb29rIGF0CnRoZSBIUUQuIFlvdSBjYW4gZmluZCB0aGUgbWF0 Y2hpbmcgSFFEIGJ5IGxvb2tpbmcgYXQgdGhlIHF1ZXVlIGJhc2UKYWRkcmVzcyAoY3BfaHFkX3Bx X2Jhc2UpIHdoaWNoIGlzIGF0IG9mZnNldCAweDIyMCBpbiB0aGUgTVFEIGFuZCBvZmZzZXQKMHhj OTM0IGluIHRoZSByZWdpc3RlciBzcGFjZSAoSFFEKS4KCkkndmUgZGVidWdnZWQgc29tZSBvYnNj dXJlIENQIGhhbmdzIGludm9sdmluZyB0aGUgRElRIGFuZCB3YXZlIGNvbnRyb2wKY29tbWFuZHMg YmVmb3JlLCB0aGF0IHJlcXVpcmVkIGhlbHAgZnJvbSB0aGUgZmlybXdhcmUgdGVhbS4gVGhlIGZp eCB3YXMKdG8gcmVtb3ZlIHN5bmNocm9uaXphdGlvbiB3aXRoIHJlbGVhc2VfbWVtIHBhY2tldHMg dGhhdCBjb3VsZCBoYW5nIGluCmNvbWJpbmF0aW9uIHdpdGggd2F2ZSBjb250cm9sLiBJdCB0dXJu ZWQgb3V0IHRoZSBzeW5jaHJvbml6YXRpb24gd2Fzbid0CnJlYWxseSBuZWVkZWQgYW55d2F5LiBC dXQgaXQgaGFkIHNvbWUgaW1wbGljYXRpb25zIGZvciBob3cgbWVtb3J5IHdhcwptYW5hZ2VkLiBJ IGhhZCB0byBhZGQgY29kZSB0byBhbGxvY2F0ZSB0aGUgSUIgb24gdGhlIHF1ZXVlICh1c2luZyBh IE5PUApjb21tYW5kKSwgc28gSSB3b3VsZG4ndCBoYXZlIHRvIGZyZWUgaXQgZXhwbGljaXRseSAo d2hpY2ggd291bGQgcmVxdWlyZQpzeW5jaHJvbml6YXRpb24pLiBJIHRoaW5rIHRoYXQgY29kZSBp cyBzdGlsbCBub3QgMTAwJSBjb3JyZWN0LiBXaGVuIHRoZQpxdWV1ZSBpcyBuZWFybHkgZnVsbCwg YW4gSUIgbWF5IGdldCBvdmVyd3JpdHRlbi4gSSdkIGhhdmUgdG8gcmVzdHJ1Y3R1cmUKdGhlIGNv ZGUgdG8gYWxsb2NhdGUgdGhlIElCIGFmdGVyIHRoZSBjb21tYW5kcyB0aGF0IHN1Ym1pdCB0aGUg SUIsIHNvCnRoYXQgdGhlIElCIGNhbid0IGdldCBvdmVyd3JpdHRlbiB1bnRpbCBhZnRlciB0aGUg SUIgZXhlY3V0aW9uIGlzIGZpbmlzaGVkLgoKUmVnYXJkcywKwqAgRmVsaXgKCj4KPiB0aGFua3Ms Cj4gSmFuCj4KPj4gUmVnYXJkcywKPj4gICBGZWxpeAo+Pgo+Pgo+PiBPbiAyMDE3LTExLTI5IDA0 OjQzIFBNLCBKYW4gVmVzZWx5IHdyb3RlOgo+Pj4gT24gTW9uLCAyMDE3LTExLTIwIGF0IDE0OjIy IC0wNTAwLCBGZWxpeCBLdWVobGluZyB3cm90ZToKPj4+PiBJIHRoaW5rIHRoaXMgcGF0Y2ggaXMg bm90IGNvcnJlY3QuIFRoZSBFT1AtbWVtIGlzIG5vdCBhc3NvY2lhdGVkIHdpdGgKPj4+PiB0aGUg cXVldWUgc2l6ZS4gVGhlIEVPUCBidWZmZXIgaXMgYSBzZXBhcmF0ZSBidWZmZXIgdXNlZCBieSB0 aGUgZmlybXdhcmUKPj4+PiB0byBoYW5kbGUgY29tbWFuZCBjb21wbGV0aW9uLiBBcyBJIHVuZGVy c3RhbmQgaXQsIHRoaXMgYWxsb3dzIG1vcmUKPj4+PiBjb25jdXJyZW5jeSwgd2hpbGUgc3RpbGwg bWFraW5nIGl0IGxvb2sgbGlrZSBhbGwgY29tbWFuZHMgaW4gdGhlIHF1ZXVlCj4+Pj4gYXJlIGNv bXBsZXRpbmcgaW4gb3JkZXIuCj4+PiB0aGFua3MgZm9yIHRoZSBleHBsYW5hdGlvbi4gSSB3YXMg bG9va2luZyBmb3IgYSBzb3VyY2Ugb2YgYSBDUCBoYW5nCj4+PiAocnB0ciBzdG9wcyBhZHZhbmNp bmcpLCBidXQgYnVtcGluZyB0aGUgZW9wIHNpemUgYWN0dWFsbHkgbW9kZSB0aGluZ3MKPj4+IHdv cnNlLiBJcyB0aGVyZSBhIHdheSB0byBmaW5kIG91dCBpZiBhIHF1ZXVlIGdvdCBkaXNhYmxlZCBh bmQgZm9yIHdoYXQKPj4+IHJlYXNvbj8gKEknbSBydW5uaW5nIFJPQ0stMS42LnggYmFzZWQga2Vy bmVsKQo+Pj4KPj4+IHRoYW5rcywKPj4+IEphbgo+Pj4KPj4+PiBSZWdhcmRzLAo+Pj4+ICAgRmVs aXgKPj4+Pgo+Pj4+Cj4+Pj4gT24gMjAxNy0xMS0xOSAwMzoxOSBBTSwgT2RlZCBHYWJiYXkgd3Jv dGU6Cj4+Pj4+IE9uIFRodSwgTm92IDE2LCAyMDE3IGF0IDExOjM2IFBNLCBKYW4gVmVzZWx5IDxq YW4udmVzZWx5QHJ1dGdlcnMuZWR1PiB3cm90ZToKPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEphbiBW ZXNlbHkgPGphbi52ZXNlbHlAcnV0Z2Vycy5lZHU+Cj4+Pj4+PiAtLS0KPj4+Pj4+ICBkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfa2VybmVsX3F1ZXVlX3ZpLmMgfCA1ICsrKy0tCj4+Pj4+ PiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Pj4+ Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2tlcm5l bF9xdWV1ZV92aS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2tlcm5lbF9xdWV1 ZV92aS5jCj4+Pj4+PiBpbmRleCBmMWQ0ODI4MWUzMjIuLmIzYmVlMzk2NjFhYiAxMDA2NDQKPj4+ Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9rZXJuZWxfcXVldWVfdmku Ywo+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2tlcm5lbF9xdWV1 ZV92aS5jCj4+Pj4+PiBAQCAtMzcsMTUgKzM3LDE2IEBAIHN0YXRpYyBib29sIGluaXRpYWxpemVf dmkoc3RydWN0IGtlcm5lbF9xdWV1ZSAqa3EsIHN0cnVjdCBrZmRfZGV2ICpkZXYsCj4+Pj4+PiAg ICAgICAgICAgICAgICAgICAgICAgICBlbnVtIGtmZF9xdWV1ZV90eXBlIHR5cGUsIHVuc2lnbmVk IGludCBxdWV1ZV9zaXplKQo+Pj4+Pj4gIHsKPj4+Pj4+ICAgICAgICAgaW50IHJldHZhbDsKPj4+ Pj4+ICsgICAgICAgdW5zaWduZWQgaW50IHNpemUgPSBBTElHTihxdWV1ZV9zaXplLCBQQUdFX1NJ WkUpOwo+Pj4+Pj4KPj4+Pj4+IC0gICAgICAgcmV0dmFsID0ga2ZkX2d0dF9zYV9hbGxvY2F0ZShk ZXYsIFBBR0VfU0laRSwgJmtxLT5lb3BfbWVtKTsKPj4+Pj4+ICsgICAgICAgcmV0dmFsID0ga2Zk X2d0dF9zYV9hbGxvY2F0ZShkZXYsIHNpemUsICZrcS0+ZW9wX21lbSk7Cj4+Pj4+PiAgICAgICAg IGlmIChyZXR2YWwgIT0gMCkKPj4+Pj4+ICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+ Pj4+Pgo+Pj4+Pj4gICAgICAgICBrcS0+ZW9wX2dwdV9hZGRyID0ga3EtPmVvcF9tZW0tPmdwdV9h ZGRyOwo+Pj4+Pj4gICAgICAgICBrcS0+ZW9wX2tlcm5lbF9hZGRyID0ga3EtPmVvcF9tZW0tPmNw dV9wdHI7Cj4+Pj4+Pgo+Pj4+Pj4gLSAgICAgICBtZW1zZXQoa3EtPmVvcF9rZXJuZWxfYWRkciwg MCwgUEFHRV9TSVpFKTsKPj4+Pj4+ICsgICAgICAgbWVtc2V0KGtxLT5lb3Bfa2VybmVsX2FkZHIs IDAsIHNpemUpOwo+Pj4+Pj4KPj4+Pj4+ICAgICAgICAgcmV0dXJuIHRydWU7Cj4+Pj4+PiAgfQo+ Pj4+Pj4gLS0KPj4+Pj4+IDIuMTMuNgo+Pj4+Pj4KPj4+Pj4+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+Pj4+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+ Pj4+Pj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4+Pj4+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+Pj4+PiBUaGFua3MhCj4+ Pj4+IEFwcGxpZWQgdG8gLW5leHQgdHJlZQo+Pj4+PiBPZGVkCj4+Pj4+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+Pj4+IGFtZC1nZnggbWFpbGluZyBs aXN0Cj4+Pj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+Pj4+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+PgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==