From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CC3C4742C for ; Fri, 30 Oct 2020 08:48:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74D3820704 for ; Fri, 30 Oct 2020 08:48:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="q7rEr/ql" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74D3820704 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 255C16ED12; Fri, 30 Oct 2020 08:48:38 +0000 (UTC) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by gabe.freedesktop.org (Postfix) with ESMTPS id D20EF6ED12 for ; Fri, 30 Oct 2020 08:48:35 +0000 (UTC) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09U8fYuC114276; Fri, 30 Oct 2020 03:41:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604047294; bh=wYGicATp84soVO9OZKDCZJuGrwdPVbdb6gu0/OJ7Vgc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=q7rEr/qlDFYTvGj3Ug/5RYZ8gapYI63xNwt6N2EsLkGnOpgdR+FcWwi1FgGuJFwZI bK/wOE/qzVuyka6bXlXL2v8o+54YCG8aAPuzm74LJRYqJWGCeAoBNnOBEoMqaI2+xr 76gstRfgljZtgLDx2EXx+ShMykMdzGC/g1D9k0gI= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09U8fY6k034442 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 30 Oct 2020 03:41:34 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 30 Oct 2020 03:40:48 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 30 Oct 2020 03:40:48 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09U8elaU047546; Fri, 30 Oct 2020 03:40:47 -0500 Subject: Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings To: Boris Brezillon References: <20201016103917.26838-1-nikhil.nd@ti.com> <20201016103917.26838-4-nikhil.nd@ti.com> <20201028143453.njt3lak542wwx6jb@NiksLab> <20201029224817.GH15024@pendragon.ideasonboard.com> <20201030090815.7133637b@collabora.com> From: Tomi Valkeinen Message-ID: Date: Fri, 30 Oct 2020 10:40:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201030090815.7133637b@collabora.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Swapnil Jakhade , Sekhar Nori , Laurent Pinchart , dri-devel@lists.freedesktop.org, Nikhil Devshatwar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Boris, On 30/10/2020 10:08, Boris Brezillon wrote: > The "propagate output flags" and soon to be added "use > timing->input_flags if present" logic should only be used as a fallback > for bridges that do not support dynamic bus format/flags negotiation > IMHO. Ideally we'd want to convert all bridges to do this dynamic bus > format/flags negotiation and get rid of timings->input_bus_flags once > this is done, but that's likely to take time. So, if your driver > implements the ->atomic_check() hook and needs specific input flags, > I'd recommend setting the input flags there instead of specifying it > through timings->input_bus_flags. What is bus flags negotiation? Don't we have negotiation only for bus formats? Bus flags are just set, and the previous bridge in the chain has to use those flags. Or do you just refer to setting the bus flags dynamically in atomic_check, versus static in input_bus_flags? Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel