From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EAFAC3064D for ; Tue, 25 Jun 2024 01:23:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E36110E11E; Tue, 25 Jun 2024 01:23:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=testtoast.com header.i=@testtoast.com header.b="A4CF6qCJ"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="M9xgx79/"; dkim-atps=neutral Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) by gabe.freedesktop.org (Postfix) with ESMTPS id 817CA10E11E for ; Tue, 25 Jun 2024 01:23:47 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 5B2E41140214; Mon, 24 Jun 2024 21:23:46 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute5.internal (MEProxy); Mon, 24 Jun 2024 21:23:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=testtoast.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1719278626; x= 1719365026; bh=ys+1zZVloT/gls+QxuvRvXMQGJI5jghGSzU2+KtdtYU=; b=A 4CF6qCJiFWrx49ZQFRT+kEC4JaidhvO/7xFwzqpd4NUxFxKPT0Q8bKksDRNiyp2K t7MFm6e6YbZK24H+r1xPphM4abeni+HFb49otomGtVZ6DK+iCM/AlcJzLjurxOFJ c6PBlmIoph0kbavmOFwTdQ7lj/kn5UxUuToNSdbqG7hR2NBhWzC2oQYEAv9ilXRu GKAgZIFdur2ke6+srbnDyPYayKtfYXIwYDU5JGBIPu6BbMOW7hO5REL46JDf7k+4 Ega2WU7vPDbhm+gbHZPz49MeWkCT/l16cpO60HMWb610bS+YJJza+8P5XGaYIQgw J+QTN+DiRsSHw8IgWvbqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719278626; x=1719365026; bh=ys+1zZVloT/gls+QxuvRvXMQGJI5 jghGSzU2+KtdtYU=; b=M9xgx79/tc5kCutE8JV0ubl7LaAWxnkyMqX03MwlHRUj +dRd1GMJf4ypkFpw8H0sZnU2jdBRpvyBhsdz1xQkxZADpRTQg4wjyDLFjEBUlHXg iQA5w/63dgfuV9ZVexXfIhq5ilmUFY2z5YhC4RSYvY+z/d7vIpImFNIQXCsCpn6K Up5PNU3YJLlxB5L4+fI5myLgLIBG7Y05IYqBvaTmtMmmaz8Jdm28tuOueWgS3uni u1sSEvaN7hXiG8ltVX3jBRf00E7KnUpk5yc9pgonTKuQt9Egrgvj4RRth71BvQiV hLwN/O1plO/eCRUPru5NhB7gvQ/uOUUqEKceMcN9HA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeegvddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftfih rghnucghrghlkhhlihhnfdcuoehrhigrnhesthgvshhtthhorghsthdrtghomheqnecugg ftrfgrthhtvghrnhephedvveeigedujeeufeegffehhfffveduhfeijefgtdffteelgfet ueevieduieejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheprhihrghnsehtvghsthhtohgrshhtrdgtohhm X-ME-Proxy: Feedback-ID: idc0145fc:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C0238A6007A; Mon, 24 Jun 2024 21:23:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa MIME-Version: 1.0 Message-Id: In-Reply-To: <20240625012804.27e55708@minigeek.lan> References: <20240620113150.83466-1-ryan@testtoast.com> <20240620113150.83466-15-ryan@testtoast.com> <20240625012804.27e55708@minigeek.lan> Date: Tue, 25 Jun 2024 13:23:24 +1200 From: "Ryan Walklin" To: "Andre Przywara" Cc: "Maxime Ripard" , "Chen-Yu Tsai" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Michael Turquette" , "Stephen Boyd" , "Chris Morgan" , "John Watts" , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 14/23] drm: sun4i: de2/de3: refactor mixer initialisation Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Andre, On Tue, 25 Jun 2024, at 12:28 PM, Andre Przywara wrote: Thanks for the review! >> regmap_write(mixer->engine.regs, SUN50I_MIXER_CDC1_EN, 0); >> - } else { >> + > > That seems to add an extra line, which shouldn't be here. This was intentional to add some whitespace between the block of register writes and the next if/then block, but happy to remove delete if that is the style preference. > > Verified that the rest is indeed just a code move, from below into a > separate function. So with the two minor bits above fixed: > > Reviewed-by: Andre Przywara > Thanks again! Ryan