From: "Wachowski, Karol" <karol.wachowski@linux.intel.com>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com,
karol.wachowski@linux.intel.com, lizhi.hou@amd.com,
andrzej.kacprowski@linux.intel.com
Subject: Re: [PATCH 0/3] accel/ivpu: Rework HW IP generation detection and dispatch
Date: Mon, 5 Oct 2026 09:08:56 +0200 [thread overview]
Message-ID: <df9d2be3-6b75-4640-8a98-8a131889cc8d@linux.intel.com> (raw)
In-Reply-To: <20261001110401.2866557-1-dawid.osuchowski@linux.intel.com>
On 01-Oct-26 13:03, Dawid Osuchowski wrote:
> This series reworks how the driver determines the HW IP generation and
> buttress version, and how it dispatches on them.
>
> Today ivpu_hw_ip_gen() and ivpu_hw_btrs_gen() run a switch over the PCI
> device ID on every call, and an unknown ID only triggers a WARN() while
> probe continues with an undefined generation. Patch 1 resolves both
> values once during device init and fails probe with -EINVAL on an
> unrecognized device ID.
>
> With that guarantee in place, patch 2 changes the stored values and their
> accessors to the real enum types and drops the default: labels from the
> switches that dispatch on them, so -Wswitch flags a generation that is
> added later but not handled.
>
> Patch 3 splits the remaining per-generation dispatch in
> ivpu_hw_ip_soc_cpu_boot() and pwr_island_delay_set() into helpers that
> return directly from each case, removing the locals that were left
> uninitialized on the path past the last case.
>
> No functional change is intended beyond failing probe on an unknown PCI
> device ID and logging the SOC CPU boot mode even when the boot fails.
>
> Andrzej Kacprowski (1):
> accel/ivpu: Improve HW IP gen and buttress version checks
>
> Dawid Osuchowski (1):
> accel/ivpu: Convert hw_ip_gen/btrs_gen to enum types
>
> Karol Wachowski (1):
> accel/ivpu: Split HW IP generation dispatch into helpers
>
> drivers/accel/ivpu/ivpu_drv.c | 69 +++++++++++++++++++-------
> drivers/accel/ivpu/ivpu_drv.h | 65 +++++++++----------------
> drivers/accel/ivpu/ivpu_hw.h | 1 -
> drivers/accel/ivpu/ivpu_hw_ip.c | 86 ++++++++++++++++-----------------
> 4 files changed, 117 insertions(+), 104 deletions(-)
>
Applied to drm-misc-next.
prev parent reply other threads:[~2026-10-05 7:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 11:03 [PATCH 0/3] accel/ivpu: Rework HW IP generation detection and dispatch Dawid Osuchowski
2026-10-01 11:03 ` [PATCH 1/3] accel/ivpu: Improve HW IP gen and buttress version checks Dawid Osuchowski
2026-10-01 13:57 ` Wachowski, Karol
2026-10-02 15:19 ` Jeff Hugo
2026-10-01 11:04 ` [PATCH 2/3] accel/ivpu: Convert hw_ip_gen/btrs_gen to enum types Dawid Osuchowski
2026-10-01 13:58 ` Wachowski, Karol
2026-10-01 14:33 ` Andrzej Kacprowski
2026-10-02 15:20 ` Jeff Hugo
2026-10-01 11:04 ` [PATCH 3/3] accel/ivpu: Split HW IP generation dispatch into helpers Dawid Osuchowski
2026-10-01 14:34 ` Andrzej Kacprowski
2026-10-02 15:21 ` Jeff Hugo
2026-10-05 7:08 ` Wachowski, Karol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9d2be3-6b75-4640-8a98-8a131889cc8d@linux.intel.com \
--to=karol.wachowski@linux.intel.com \
--cc=andrzej.kacprowski@linux.intel.com \
--cc=dawid.osuchowski@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=lizhi.hou@amd.com \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox