From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 3/3] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb. Date: Mon, 27 Feb 2017 13:01:17 +0100 Message-ID: References: <1487685102-31991-1-git-send-email-maarten.lankhorst@linux.intel.com> <1487685102-31991-4-git-send-email-maarten.lankhorst@linux.intel.com> <20170223152430.GC17822@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170223152430.GC17822@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sean Paul Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMjMtMDItMTcgb20gMTY6MjQgc2NocmVlZiBTZWFuIFBhdWw6Cj4gT24gVHVlLCBGZWIgMjEs IDIwMTcgYXQgMDI6NTE6NDJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4+IFRo aXMgaW50cm9kdWNlcyBhIHNsaWdodCBiZWhhdmlvcmFsIGNoYW5nZSB0byBybWZiLiBJbnN0ZWFk IG9mCj4+IGRpc2FibGluZyBhIGNydGMgd2hlbiB0aGUgcHJpbWFyeSBwbGFuZSBpcyBkaXNhYmxl ZCwgd2UgdHJ5IHRvCj4+IHByZXNlcnZlIGl0Lgo+Pgo+PiBBcGFydCBmcm9tIG9sZCB2ZXJzaW9u cyBvZiB0aGUgdm13Z2Z4IHhvcmcgZHJpdmVyLCB0aGVyZSBpcwo+PiBub3RoaW5nIGRlcGVuZGlu ZyBvbiBybWZiIGRpc2FibGluZyBhIGNydGMuIFNpbmNlIHZtd2dmeCBpcwo+PiBhIGxlZ2FjeSBk cml2ZXIgd2UgY2FuIHNhZmVseSBvbmx5IGRpc2FibGUgdGhlIHBsYW5lIHdpdGggYXRvbWljLgo+ PiBJbiB0aGUgY29udmVyc2lvbiB0byBhdG9taWMgdGhlIGRyaXZlciB3aWxsIHJlamVjdCB0aGUg Y29uZmlnCj4+IHdpdGhvdXQgcHJpbWFyeSBwbGFuZS4KPj4KPj4gSWYgdGhpcyBjb21taXQgaXMg cmVqZWN0ZWQgYnkgdGhlIGRyaXZlciB0aGVuIHdlIHdpbGwgc3RpbGwgZmFsbAo+PiBiYWNrIHRv IHRoZSBvbGQgYmVoYXZpb3IgYW5kIHR1cm4gb2ZmIHRoZSBjcnRjLgo+Pgo+PiBTaWduZWQtb2Zm LWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29t Pgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgfCAyMiArKysrKysrKysr KysrKysrKysrKy0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4+IGluZGV4IDI4NWUxYzIzZThjOS4uMGQ1 YjAwNjUyMDhlIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPj4gQEAgLTIwNzAsNyArMjA3MCw3 IEBAIGludCBkcm1fYXRvbWljX3JlbW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikK Pj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubjsKPj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv cl9zdGF0ZSAqY29ubl9zdGF0ZTsKPj4gIAlpbnQgaSwgcmV0ID0gMDsKPj4gLQl1bnNpZ25lZCBw bGFuZV9tYXNrOwo+PiArCXVuc2lnbmVkIHBsYW5lX21hc2ssIGRpc2FibGVfY3J0Y3MgPSBmYWxz ZTsKPj4gIAo+PiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+PiAgCWlm ICghc3RhdGUpCj4+IEBAIC0yMDk3LDcgKzIwOTcsMTMgQEAgaW50IGRybV9hdG9taWNfcmVtb3Zl X2ZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+PiAgCQkJZ290byB1bmxvY2s7Cj4+ICAJ CX0KPj4gIAo+PiAtCQlpZiAocGxhbmVfc3RhdGUtPmNydGMtPnByaW1hcnkgPT0gcGxhbmUpIHsK Pj4gKwkJLyoKPj4gKwkJICogU29tZSBkcml2ZXJzIGRvIG5vdCBzdXBwb3J0IGtlZXBpbmcgY3J0 YyBhY3RpdmUgd2l0aCB0aGUKPj4gKwkJICogcHJpbWFyeSBwbGFuZSBkaXNhYmxlZC4gSWYgd2Ug ZmFpbCB0byBjb21taXQgd2l0aCAtRUlOVkFMCj4+ICsJCSAqIHRoZW4gd2Ugd2lsbCB0cnkgdG8g cGVyZm9ybSB0aGUgc2FtZSBjb21taXQgYnV0IHdpdGggYWxsCj4+ICsJCSAqIGNydGMncyBkaXNh YmxlZCBmb3IgcHJpbWFyeSBwbGFuZXMgYXMgd2VsbC4KPj4gKwkJICovCj4+ICsJCWlmIChkaXNh YmxlX2NydGNzICYmIHBsYW5lX3N0YXRlLT5jcnRjLT5wcmltYXJ5ID09IHBsYW5lKSB7Cj4+ICAJ CQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+ICAKPj4gIAkJCWNydGNfc3Rh dGUgPSBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLCBwbGFuZV9zdGF0 ZS0+Y3J0Yyk7Cj4+IEBAIC0yMTIyLDYgKzIxMjgsNyBAQCBpbnQgZHJtX2F0b21pY19yZW1vdmVf ZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4+ICAJCXBsYW5lLT5vbGRfZmIgPSBwbGFu ZS0+ZmI7Cj4+ICAJfQo+PiAgCj4+ICsJLyogVGhpcyBsaXN0IGlzIG9ubHkgbm90IGVtcHR5IHdo ZW4gZGlzYWJsZV9jcnRjcyBpcyBzZXQuICovCj4+ICAJZm9yX2VhY2hfY29ubmVjdG9yX2luX3N0 YXRlKHN0YXRlLCBjb25uLCBjb25uX3N0YXRlLCBpKSB7Cj4+ICAJCXJldCA9IGRybV9hdG9taWNf c2V0X2NydGNfZm9yX2Nvbm5lY3Rvcihjb25uX3N0YXRlLCBOVUxMKTsKPj4gIAo+PiBAQCAtMjE0 Myw2ICsyMTUwLDE3IEBAIGludCBkcm1fYXRvbWljX3JlbW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1l YnVmZmVyICpmYikKPj4gIAo+PiAgCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPj4gIAo+ PiArCWlmIChyZXQgPT0gLUVJTlZBTCAmJiAhZGlzYWJsZV9jcnRjcykgewo+PiArCQlkaXNhYmxl X2NydGNzID0gdHJ1ZTsKPj4gKwo+PiArCQlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2Mo ZGV2KTsKPj4gKwkJaWYgKHN0YXRlKSB7Cj4+ICsJCQlzdGF0ZS0+YWNxdWlyZV9jdHggPSAmY3R4 Owo+PiArCQkJZ290byByZXRyeTsKPiBSZS11c2luZyB0aGUgcmV0cnkgbGFiZWwgaXMgYSBsaXR0 bGUgZmlzaHkgaGVyZS4gWW91IG5lZWQgdG8gcmUtYWxsb2NhdGUgc3RhdGUsCj4gYnV0IHdlIGRv bid0IGRyb3AgdGhlIGxvY2tzLCB3aGljaCBtYWtlcyB0aGluZ3MgYSBsaXR0bGUgdW5iYWxhbmNl ZCAoSSByZWFsaXplCj4gbW9kZXNldF9sb2NrIHdpbGwgcy9FQUxSRUFEWS8wLykuCmRybV9tb2Rl c2V0X2xvY2sgY2FuIGJlIGNhbGxlZCBhbnkgYXJiaXRyYXJ5IG51bWVyIG9mIHRpbWVzLiBJJ20g bm90IHdvcnJpZWQgYWJvdXQgaXQuIDopCj4gUGVyaGFwcyBzb21ldGhpbmcgbGlrZSB0aGlzIGFi b3ZlIHdvdWxkIGJlIG1vcmUgY2xlYXI6Cj4KPiArICAgICAgIGRybV9tb2Rlc2V0X2FjcXVpcmVf aW5pdCgmY3R4LCAwKTsKPiArcmV0cnk6Cj4gKyAgICAgICBwbGFuZV9tYXNrID0gMDsKPiArICAg ICAgIHJldCA9IGRybV9tb2Rlc2V0X2xvY2tfYWxsX2N0eChkZXYsICZjdHgpOwo+ICsgICAgICAg aWYgKHJldCkKPiArICAgICAgICAgICAgICAgZ290byB1bmxvY2s7Cj4gKwo+ICtyZXRyeV9kaXNh YmxlOgo+ICsgICAgICAgc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gKyAg ICAgICBpZiAoIXN0YXRlKQo+ICsgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiArICAg ICAgIHN0YXRlLT5hY3F1aXJlX2N0eCA9ICZjdHg7Cj4gKwo+Cj4gVGhlbiB5b3UgY2FuIGRvOgo+ Cj4KPiArCWlmIChyZXQgPT0gLUVJTlZBTCAmJiAhZGlzYWJsZV9jcnRjcykgewo+ICsJCWRpc2Fi bGVfY3J0Y3MgPSB0cnVlOwo+ICsJCWdvdG8gcmV0cnlfZGlzYWJsZTsKPiArICAgICAgIH0KPgo+ ICh5b3Ugd291bGQgYWxzbyBuZWVkIHRvIGVuc3VyZSB5b3UgbW92ZWQgdGhlIHN0YXRlX3B1dCBh Ym92ZSB0aGUgRURFQURMSwo+IGhhbmRsaW5nKS4KPgo+IFRob3VnaHRzPwpJbiBnZW5lcmFsIHdl IHRyeSB0byBjYWxsIGRybV9hdG9taWNfc3RhdGVfY2xlYXIgaW5zdGVhZCBvZiBkcm1fYXRvbWlj X3N0YXRlX3B1dCwgdGhpcyB3b3VsZCBiZSBhIHNvdXJjZSBvZiBjb25mdXNpb24gZm9yIGJlaW5n IGRpZmZlcmVudCBmcm9tIG90aGVyIHVzZXJzIG9mIGF0b21pYy4KCn5NYWFydGVuCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=