From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 062FFC4167B for ; Thu, 7 Dec 2023 10:48:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 604F510E1D8; Thu, 7 Dec 2023 10:48:24 +0000 (UTC) Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by gabe.freedesktop.org (Postfix) with ESMTP id 1171410E1D8 for ; Thu, 7 Dec 2023 10:48:21 +0000 (UTC) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 335198062; Thu, 7 Dec 2023 18:48:18 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 7 Dec 2023 18:48:15 +0800 Received: from [192.168.60.132] (180.164.60.184) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 7 Dec 2023 18:48:16 +0800 Message-ID: Date: Thu, 7 Dec 2023 18:48:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3 5/6] drm/vs: Add hdmi driver Content-Language: en-US To: Andy Yan References: <20231204123315.28456-1-keith.zhao@starfivetech.com> <20231204123315.28456-6-keith.zhao@starfivetech.com> <94a1f9fc-82fb-4a04-a44b-f9b20c2bdfdd@starfivetech.com> <40cdd3c7-174e-4611-9ea6-22cb56d1f62b@starfivetech.com> From: Keith Zhao In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "aou@eecs.berkeley.edu" , "suijingfeng@loongson.cn" , "krzysztof.kozlowski+dt@linaro.org" , "paul.walmsley@sifive.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Xingyu Wu , Jack Zhu , "palmer@dabbelt.com" , Maxime Ripard , "tzimmermann@suse.de" , William Qiu , Shengyang Chen , "linux-riscv@lists.infradead.org" , Changhuang Liang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023/12/7 17:02, Andy Yan wrote: >=20 >=20 >=20 >=20 > Hi Keith=EF=BC=9A >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 > At 2023-12-06 22:11:33, "Keith Zhao" wrot= e: >> >> >>On 2023/12/6 20:56, Maxime Ripard wrote: >>> On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >>>> >> +static const struct of_device_id starfive_hdmi_dt_ids[] =3D { >>>> >> + { .compatible =3D "starfive,jh7110-inno-hdmi",}, >>>> >=20 >>>> > So it's inno hdmi, just like Rockchip then? >>>> >=20 >>>> > This should be a common driver. >>>> >>>> Rockchip has a inno hdmi IP. and Starfive has a inno hdmi IP. >>>> but the harewawre difference of them is big , it is not easy to use = the common driver >>>> maybe i need the inno hdmi version here to make a distinction >>>=20 >>> I just had a look at the rockchip header file: all the registers but = the >>> STARFIVE_* ones are identical. >>>=20 >>> There's no need to have two identical drivers then, please use the >>> rockchip driver instead. >>>=20 >>> Maxime >> >>ok, have a simple test , edid can get . i will continue=20 >=20 > Maybe you can take drivers/gpu/drm/bridge/synopsys/dw-hdmi as a referen= ce=EF=BC=8C this > is also a hdmi ip used by rockchip/meson/sunxi/jz/imx=E3=80=82 > We finally make it share one driver=E3=80=82 >> hi Andy: dw_hdmi seems a good choice , it can handle inno hdmi hardware by define = its dw_hdmi_plat_data. does it means i can write own driver files such as(dw_hdmi-starfive.c) ba= sed on dw_hdmi instead of add plat_data in inno_hdmi.c Thanks for pointing this out!!! >> >>_______________________________________________ >>linux-riscv mailing list >>linux-riscv@lists.infradead.org >>http://lists.infradead.org/mailman/listinfo/linux-riscv