From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: add check for valid init_clock_gating-pointer Date: Thu, 16 Jun 2011 16:47:53 +0100 Message-ID: References: <1308176679-13766-1-git-send-email-w.sang@pengutronix.de> <20110615153000.00438750@jbarnes-desktop> <20110616132846.GE23579@pengutronix.de> <20110616081557.5f64f603@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id DC5619E774 for ; Thu, 16 Jun 2011 08:47:56 -0700 (PDT) In-Reply-To: <20110616081557.5f64f603@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , Wolfram Sang Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes wrote: > On Thu, 16 Jun 2011 15:28:46 +0200 > Wolfram Sang wrote: > > How about BUG_ON(!ptr) in the init-routine for a bit more grace? And/or > > a warning in the else-block? It seems to happen to users... > > Yeah, a BUG_ON would be fine. if (WARN_ON(!ptr, "no display vtable")) return -ENODEV; -Chris -- Chris Wilson, Intel Open Source Technology Centre