From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [RESEND 2/3] drm :fsl-dcu: Cleanup vblank interrupt mask and status setting code Date: Wed, 02 Dec 2015 17:56:20 -0800 Message-ID: References: <1448957768-14627-1-git-send-email-dongsheng.wang@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109]) by gabe.freedesktop.org (Postfix) with ESMTPS id E80D06EB65 for ; Wed, 2 Dec 2015 17:57:55 -0800 (PST) In-Reply-To: <1448957768-14627-1-git-send-email-dongsheng.wang@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dongsheng Wang , jianwei.wang.chn@gmail.com Cc: Yi Meng , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org W2Fsc28gYWRkZWQgSmlhbndlaSBXYW5nLCBzaW5jZSBoZSBpcyB0aGUgY3VycmVudCBtYWludGFp bmVyIG9mIHRoaXMKZHJpdmVyXQoKT24gMjAxNS0xMi0wMSAwMDoxNiwgRG9uZ3NoZW5nIFdhbmcg d3JvdGU6Cj4gRnJvbTogSmlhbndlaSBXYW5nIDxqaWFud2VpLndhbmcuY2huQGdtYWlsLmNvbT4K PiAKPiBTd2l0Y2ggdXBkYXRlIGludGVycnVwdCBtYXNrIGJpdCB3aXRoIHJlZ21hcF91cGRhdGVf Yml0cywgYW5kIGNsZWFyCj4gaW50ZXJydXB0IHN0YXR1cyBieSB3cml0aW5nIDEgdG8gcmVsZXZh bnQgYml0IGJlZm9yZSBzZXR0aW5nIG1hc2sgaW4KPiBmc2xfZGN1X2RybV9pcnFfaW5pdCBmdW5j dGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKaWFud2VpIFdhbmcgPGppYW53ZWkud2FuZy5jaG5A Z21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFlpIE1lbmcgPGI1Njc5OUBmcmVlc2NhbGUuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IFdhbmcgRG9uZ3NoZW5nIDxkb25nc2hlbmcud2FuZ0BmcmVlc2Nh bGUuY29tPgo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZnNsLWRjdS9mc2xfZGN1 X2RybV9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2ZzbC1kY3UvZnNsX2RjdV9kcm1fZHJ2LmMK PiBpbmRleCAxOTMwMjM0Li41YzI5ZmY3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9m c2wtZGN1L2ZzbF9kY3VfZHJtX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2ZzbC1kY3Uv ZnNsX2RjdV9kcm1fZHJ2LmMKPiBAQCAtMzgsMjEgKzM4LDE3IEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgcmVnbWFwX2NvbmZpZyBmc2xfZGN1X3JlZ21hcF9jb25maWcgPSB7Cj4gIHN0YXRpYyBpbnQg ZnNsX2RjdV9kcm1faXJxX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+ICAJc3Ry dWN0IGZzbF9kY3VfZHJtX2RldmljZSAqZnNsX2RldiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gLQl1 bnNpZ25lZCBpbnQgdmFsdWU7Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCXJldCA9IGRybV9pcnFfaW5z dGFsbChkZXYsIGZzbF9kZXYtPmlycSk7Cj4gIAlpZiAocmV0IDwgMCkKPiAgCQlkZXZfZXJyKGRl di0+ZGV2LCAiZmFpbGVkIHRvIGluc3RhbGwgSVJRIGhhbmRsZXJcbiIpOwo+ICAKPiAtCXJldCA9 IHJlZ21hcF93cml0ZShmc2xfZGV2LT5yZWdtYXAsIERDVV9JTlRfU1RBVFVTLCAwKTsKPiArCXJl dCA9IHJlZ21hcF93cml0ZShmc2xfZGV2LT5yZWdtYXAsIERDVV9JTlRfU1RBVFVTLCAweGZmZmZm ZmZmKTsKPiAgCWlmIChyZXQpCj4gIAkJZGV2X2VycihkZXYtPmRldiwgInNldCBEQ1VfSU5UX1NU QVRVUyBmYWlsZWRcbiIpOwo+IC0JcmV0ID0gcmVnbWFwX3JlYWQoZnNsX2Rldi0+cmVnbWFwLCBE Q1VfSU5UX01BU0ssICZ2YWx1ZSk7Cj4gLQlpZiAocmV0KQo+IC0JCWRldl9lcnIoZGV2LT5kZXYs ICJyZWFkIERDVV9JTlRfTUFTSyBmYWlsZWRcbiIpOwo+IC0JdmFsdWUgJj0gRENVX0lOVF9NQVNL X1ZCTEFOSzsKPiAtCXJldCA9IHJlZ21hcF93cml0ZShmc2xfZGV2LT5yZWdtYXAsIERDVV9JTlRf TUFTSywgdmFsdWUpOwo+ICsJcmV0ID0gcmVnbWFwX3VwZGF0ZV9iaXRzKGZzbF9kZXYtPnJlZ21h cCwgRENVX0lOVF9NQVNLLAo+ICsJCQkJIERDVV9JTlRfTUFTS19WQkxBTkssIH5EQ1VfSU5UX01B U0tfVkJMQU5LKTsKCkp1c3QgcmVhbGl6ZWQgdGhhdCBwYXRjaCB0cmllcyB0byBzb2x2ZSB0aGUg aXNzdWU6Cmh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE1LzExLzE4Lzk1MQoKSG93ZXZlciwgaW4g bXkgdmFyaWFudCwgVkJMQU5LIGlzIG5vdCBlbmFibGVkIG9uIGluaXQuIEFmYWlrLAplbmFibGVf dmJsYW5rIHdpbGwgYmUgY2FsbGVkIGFueXdheSwgaGVuY2UgdGhlcmUgaXMgbm8gbmVlZCB0byB1 bm1hc2sKVkJMQU5LIGhlcmUuLi4KClRoaXMgcGF0Y2hzZXQgYW5kIG15IHBhdGNoc2V0IGhhdmUg c29tZSBvdmVybGFwLCB3ZSBuZWVkIHRvIHNlcmlhbGl6ZQp0aGlzIHBhdGNoZXMuCgpASmlhbndl aS9EUk0gbWFpbnRhaW5lcnMsIHdoYXQgZG8geW91IHRoaW5rLCBob3cgZG8gd2UgcHJvY2VlZCBv biB0aGlzPwoKLS0KU3RlZmFuCgo+ICAJaWYgKHJldCkKPiAgCQlkZXZfZXJyKGRldi0+ZGV2LCAi c2V0IERDVV9JTlRfTUFTSyBmYWlsZWRcbiIpOwo+ICAJcmV0ID0gcmVnbWFwX3dyaXRlKGZzbF9k ZXYtPnJlZ21hcCwgRENVX1VQREFURV9NT0RFLAo+IEBAIC0xNDMsMTQgKzEzOSwxMCBAQCBzdGF0 aWMgaXJxcmV0dXJuX3QgZnNsX2RjdV9kcm1faXJxKGludCBpcnEsIHZvaWQgKmFyZykKPiAgc3Rh dGljIGludCBmc2xfZGN1X2RybV9lbmFibGVfdmJsYW5rKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHVuc2lnbmVkIGludCBwaXBlKQo+ICB7Cj4gIAlzdHJ1Y3QgZnNsX2RjdV9kcm1fZGV2aWNlICpm c2xfZGV2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXVuc2lnbmVkIGludCB2YWx1ZTsKPiAgCWlu dCByZXQ7Cj4gIAo+IC0JcmV0ID0gcmVnbWFwX3JlYWQoZnNsX2Rldi0+cmVnbWFwLCBEQ1VfSU5U X01BU0ssICZ2YWx1ZSk7Cj4gLQlpZiAocmV0KQo+IC0JCWRldl9lcnIoZGV2LT5kZXYsICJyZWFk IERDVV9JTlRfTUFTSyBmYWlsZWRcbiIpOwo+IC0JdmFsdWUgJj0gfkRDVV9JTlRfTUFTS19WQkxB Tks7Cj4gLQlyZXQgPSByZWdtYXBfd3JpdGUoZnNsX2Rldi0+cmVnbWFwLCBEQ1VfSU5UX01BU0ss IHZhbHVlKTsKPiArCXJldCA9IHJlZ21hcF91cGRhdGVfYml0cyhmc2xfZGV2LT5yZWdtYXAsIERD VV9JTlRfTUFTSywKPiArCQkJCSBEQ1VfSU5UX01BU0tfVkJMQU5LLCB+RENVX0lOVF9NQVNLX1ZC TEFOSyk7Cj4gIAlpZiAocmV0KQo+ICAJCWRldl9lcnIoZGV2LT5kZXYsICJzZXQgRENVX0lOVF9N QVNLIGZhaWxlZFxuIik7Cj4gIAlyZXR1cm4gMDsKPiBAQCAtMTYwLDE0ICsxNTIsMTAgQEAgc3Rh dGljIHZvaWQgZnNsX2RjdV9kcm1fZGlzYWJsZV92Ymxhbmsoc3RydWN0Cj4gZHJtX2RldmljZSAq ZGV2LAo+ICAJCQkJICAgICAgIHVuc2lnbmVkIGludCBwaXBlKQo+ICB7Cj4gIAlzdHJ1Y3QgZnNs X2RjdV9kcm1fZGV2aWNlICpmc2xfZGV2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXVuc2lnbmVk IGludCB2YWx1ZTsKPiAgCWludCByZXQ7Cj4gIAo+IC0JcmV0ID0gcmVnbWFwX3JlYWQoZnNsX2Rl di0+cmVnbWFwLCBEQ1VfSU5UX01BU0ssICZ2YWx1ZSk7Cj4gLQlpZiAocmV0KQo+IC0JCWRldl9l cnIoZGV2LT5kZXYsICJyZWFkIERDVV9JTlRfTUFTSyBmYWlsZWRcbiIpOwo+IC0JdmFsdWUgfD0g RENVX0lOVF9NQVNLX1ZCTEFOSzsKPiAtCXJldCA9IHJlZ21hcF93cml0ZShmc2xfZGV2LT5yZWdt YXAsIERDVV9JTlRfTUFTSywgdmFsdWUpOwo+ICsJcmV0ID0gcmVnbWFwX3VwZGF0ZV9iaXRzKGZz bF9kZXYtPnJlZ21hcCwgRENVX0lOVF9NQVNLLAo+ICsJCQkJIERDVV9JTlRfTUFTS19WQkxBTkss IERDVV9JTlRfTUFTS19WQkxBTkspOwo+ICAJaWYgKHJldCkKPiAgCQlkZXZfZXJyKGRldi0+ZGV2 LCAic2V0IERDVV9JTlRfTUFTSyBmYWlsZWRcbiIpOwo+ICB9Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==