From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C0A3C4167B for ; Fri, 8 Dec 2023 03:00:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D30D710E9BD; Fri, 8 Dec 2023 03:00:44 +0000 (UTC) Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by gabe.freedesktop.org (Postfix) with ESMTP id 269AC10E9BD for ; Fri, 8 Dec 2023 03:00:42 +0000 (UTC) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 8FB4581DC; Fri, 8 Dec 2023 11:00:32 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 8 Dec 2023 11:00:32 +0800 Received: from [192.168.1.115] (180.164.60.184) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 8 Dec 2023 11:00:31 +0800 Message-ID: Date: Fri, 8 Dec 2023 11:00:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3 5/6] drm/vs: Add hdmi driver Content-Language: en-US To: Andy Yan References: <20231204123315.28456-1-keith.zhao@starfivetech.com> <20231204123315.28456-6-keith.zhao@starfivetech.com> <94a1f9fc-82fb-4a04-a44b-f9b20c2bdfdd@starfivetech.com> <40cdd3c7-174e-4611-9ea6-22cb56d1f62b@starfivetech.com> <43e42269.314.18c46dbb4c5.Coremail.andyshrk@163.com> From: Keith Zhao In-Reply-To: <43e42269.314.18c46dbb4c5.Coremail.andyshrk@163.com> Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "aou@eecs.berkeley.edu" , "suijingfeng@loongson.cn" , "krzysztof.kozlowski+dt@linaro.org" , "paul.walmsley@sifive.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Xingyu Wu , Jack Zhu , "palmer@dabbelt.com" , Maxime Ripard , "tzimmermann@suse.de" , William Qiu , Shengyang Chen , "linux-riscv@lists.infradead.org" , Changhuang Liang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023/12/8 8:37, Andy Yan wrote: > Hi Keth=EF=BC=9A >=20 >=20 >=20 >=20 >=20 >=20 > =E5=9C=A8 2023-12-07 18:48:13=EF=BC=8C"Keith Zhao" =E5=86=99=E9=81=93=EF=BC=9A >> >> >>On 2023/12/7 17:02, Andy Yan wrote: >>>=20 >>>=20 >>>=20 >>>=20 >>> Hi Keith=EF=BC=9A >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> At 2023-12-06 22:11:33, "Keith Zhao" wr= ote: >>>> >>>> >>>>On 2023/12/6 20:56, Maxime Ripard wrote: >>>>> On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >>>>>> >> +static const struct of_device_id starfive_hdmi_dt_ids[] =3D { >>>>>> >> + { .compatible =3D "starfive,jh7110-inno-hdmi",}, >>>>>> >=20 >>>>>> > So it's inno hdmi, just like Rockchip then? >>>>>> >=20 >>>>>> > This should be a common driver. >>>>>> >>>>>> Rockchip has a inno hdmi IP. and Starfive has a inno hdmi IP. >>>>>> but the harewawre difference of them is big , it is not easy to us= e the common driver >>>>>> maybe i need the inno hdmi version here to make a distinction >>>>>=20 >>>>> I just had a look at the rockchip header file: all the registers bu= t the >>>>> STARFIVE_* ones are identical. >>>>>=20 >>>>> There's no need to have two identical drivers then, please use the >>>>> rockchip driver instead. >>>>>=20 >>>>> Maxime >>>> >>>>ok, have a simple test , edid can get . i will continue=20 >>>=20 >>> Maybe you can take drivers/gpu/drm/bridge/synopsys/dw-hdmi as a refer= ence=EF=BC=8C this >>> is also a hdmi ip used by rockchip/meson/sunxi/jz/imx=E3=80=82 >>> We finally make it share one driver=E3=80=82 >>>> >>hi Andy: >> >>dw_hdmi seems a good choice , it can handle inno hdmi hardware by defin= e its dw_hdmi_plat_data. >>does it means i can write own driver files such as(dw_hdmi-starfive.c) = based on dw_hdmi instead of add plat_data in inno_hdmi.c >> >=20 > I think the process maybe like this=EF=BC=9A >=20 > 1. split the inno_hdmi.c under rockchip to inno_hdmi.c(the common part= ), inno_hdmi-rockchip.c(the soc specific part) > 2. move the common part inno_hdmi.c to drivers/gpu/drm/bridge/innosilic= on/ > 3. add startfive specific part, inno_hdmi-startfive.c >=20 > bellow git log from kernel three show how we convert dw_hdmi to a comm= on driver:=20 >=20 >=20 >=20 > 12b9f204e804 drm: bridge/dw_hdmi: add rockchip rk3288 support > 74af9e4d03b8 dt-bindings: Add documentation for rockchip dw hdmi > d346c14eeea9 drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare > a4d3b8b050d5 drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_w= ait_i2c_done > 632d035bace2 drm: bridge/dw_hdmi: add mode_valid support > 0cd9d1428322 drm: bridge/dw_hdmi: add support for multi-byte register w= idth access > cd152393967e dt-bindings: add document for dw_hdmi > b21f4b658df8 drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi > aaa757a092c2 drm: imx: imx-hdmi: split phy configuration to platform dr= iver > 3d1b35a3d9f3 drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode > c2c3848851a7 drm: imx: imx-hdmi: return defer if can't get ddc i2c adap= ter > b587833933de drm: imx: imx-hdmi: make checkpatch happy >=20 hi Andy: I got you means,=20 as I don't have a rockchip board on hand , to split the inno_hdmi.c can n= ot be tested. how adout this idea: 1=E3=80=81split the starfive_hdmi.c under verisilicion to inno_hdmi.c(th= e common part), inno_hdmi-starfive.c(the soc specific part) 2. move the common part inno_hdmi.c to drivers/gpu/drm/bridge/innosilicon= / 3. In the future, inno hdmi.c under rockchip will reuse the public driver= . >=20 >>Thanks for pointing this out!!! >> >>>> >>>>_______________________________________________ >>>>linux-riscv mailing list >>>>linux-riscv@lists.infradead.org >>>>http://lists.infradead.org/mailman/listinfo/linux-riscv >> >>_______________________________________________ >>linux-riscv mailing list >>linux-riscv@lists.infradead.org >>http://lists.infradead.org/mailman/listinfo/linux-riscv