From: Archit Taneja <architt@codeaurora.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: elfring@users.sourceforge.net, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures
Date: Wed, 9 Aug 2017 18:06:24 +0530 [thread overview]
Message-ID: <e1ebeb44-cfe8-0ec7-13ef-e52f911ce67c@codeaurora.org> (raw)
In-Reply-To: <2774445.RGyCgtBS77@avalon>
On 08/09/2017 02:08 PM, Laurent Pinchart wrote:
> Hi Arvind,
>
> Thank you for the patch.
>
> On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote:
>> snd_pcm_ops are not supposed to change at runtime. All functions
>> working with snd_pcm_ops provided by <sound/pcm.h> work with
>> const snd_pcm_ops. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
queued to drm-misc-next
Thanks,
Archit
>
>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index
>> 8f2d137..cf3f0ca 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct
>> snd_pcm_substream *substream) return bytes_to_frames(runtime,
>> dw->buf_offset);
>> }
>>
>> -static struct snd_pcm_ops snd_dw_hdmi_ops = {
>> +static const struct snd_pcm_ops snd_dw_hdmi_ops = {
>> .open = dw_hdmi_open,
>> .close = dw_hdmi_close,
>> .ioctl = snd_pcm_lib_ioctl,
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-08-09 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 7:38 [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures Arvind Yadav
2017-08-09 8:38 ` Laurent Pinchart
2017-08-09 12:36 ` Archit Taneja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ebeb44-cfe8-0ec7-13ef-e52f911ce67c@codeaurora.org \
--to=architt@codeaurora.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox