From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v5 2/4] drm: Add vrr_enabled property to drm CRTC Date: Sat, 13 Oct 2018 19:38:41 +0200 Message-ID: References: <20181012164458.12864-1-nicholas.kazlauskas@amd.com> <20181012164458.12864-3-nicholas.kazlauskas@amd.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181012164458.12864-3-nicholas.kazlauskas@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicholas Kazlauskas , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, michel@daenzer.net, Marek.Olsak@amd.com, manasi.d.navare@intel.com, Alexander.Deucher@amd.com, Christian.Koenig@amd.com List-Id: dri-devel@lists.freedesktop.org QW0gMTIuMTAuMjAxOCB1bSAxODo0NCBzY2hyaWViIE5pY2hvbGFzIEthemxhdXNrYXM6Cj4gVGhp cyBwYXRjaCBpbnRyb2R1Y2VzIHRoZSAndnJyX2VuYWJsZWQnIENSVEMgcHJvcGVydHkgdG8gYWxs b3cKPiBkeW5hbWljIGNvbnRyb2wgb3ZlciB2YXJpYWJsZSByZWZyZXNoIHJhdGUgc3VwcG9ydCBm b3IgYSBDUlRDLgo+Cj4gVGhpcyBwcm9wZXJ0eSBzaG91bGQgYmUgdHJlYXRlZCBsaWtlIGEgY29u dGVudCBoaW50IHRvIHRoZSBkcml2ZXIgLQo+IGlmIHRoZSBoYXJkd2FyZSBvciBkcml2ZXIgaXMg bm90IGNhcGFibGUgb2YgZHJpdmluZyB2YXJpYWJsZSByZWZyZXNoCj4gdGltaW5ncyB0aGVuIHRo aXMgaXMgbm90IGNvbnNpZGVyZWQgYW4gZXJyb3IuCj4KPiBDYXBhYmlsaXR5IGZvciB2YXJpYWJs ZSByZWZyZXNoIHJhdGUgc3VwcG9ydCBzaG91bGQgYmUgZGV0ZXJtaW5lZAo+IGJ5IHF1ZXJ5aW5n IHRoZSB2cnJfY2FwYWJsZSBkcm0gY29ubmVjdG9yIHByb3BlcnR5Lgo+Cj4gSXQgaXMgd29ydGgg bm90aW5nIHRoYXQgd2hpbGUgdGhlIHByb3BlcnR5IGlzIGludGVuZGVkIGZvciBhdG9taWMgdXNl Cj4gaXQgaXNuJ3QgZmlsdGVyZWQgZnJvbSBsZWdhY3kgdXNlcnNwYWNlIHF1ZXJpZXMuIFRoaXMg YWxsb3dzIGZvciBYb3JnCj4gdXNlcnNwYWNlIGRyaXZlcnMgdG8gaW1wbGVtZW50IHN1cHBvcnQu CgpJJ20gaG9uZXN0bHkgc3RpbGwgbm90IGNvbnZpbmNlZCB0aGF0IGEgcGVyIENSVEMgcHJvcGVy dHkgaXMgYWN0dWFsbHkgCnRoZSByaWdodCBhcHByb2FjaC4KCldoYXQgd2Ugc2hvdWxkIHJhdGhl ciBkbyBpbnN0ZWFkIGlzIHRvIGltcGxlbWVudCBhIHRhcmdldCB0aW1lc3RhbXAgZm9yIAp0aGUg cGFnZSBmbGlwLgoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPgo+IFNpZ25lZC1vZmYtYnk6IE5pY2hv bGFzIEthemxhdXNrYXMgPG5pY2hvbGFzLmthemxhdXNrYXNAYW1kLmNvbT4KPiAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYyB8IDQgKysrKwo+ICAgZHJpdmVycy9ncHUv ZHJtL2RybV9jcnRjLmMgICAgICAgIHwgMiArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9tb2Rl X2NvbmZpZy5jIHwgNiArKysrKysKPiAgIGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAgICAgICAg ICB8IDkgKysrKysrKysrCj4gICBpbmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaCAgICAgfCA1 ICsrKysrCj4gICA1IGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY191YXBpLmMKPiBpbmRleCBkNWI3ZjMxNTA5OGMuLmVlYzM5NmE1N2I4OCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMKPiBAQCAtNDMzLDYgKzQzMyw4IEBAIHN0YXRp YyBpbnQgZHJtX2F0b21pY19jcnRjX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMs Cj4gICAJCXJldCA9IGRybV9hdG9taWNfc2V0X21vZGVfcHJvcF9mb3JfY3J0YyhzdGF0ZSwgbW9k ZSk7Cj4gICAJCWRybV9wcm9wZXJ0eV9ibG9iX3B1dChtb2RlKTsKPiAgIAkJcmV0dXJuIHJldDsK PiArCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29uZmlnLT5wcm9wX3Zycl9lbmFibGVkKSB7Cj4g KwkJc3RhdGUtPnZycl9lbmFibGVkID0gdmFsOwo+ICAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0g Y29uZmlnLT5kZWdhbW1hX2x1dF9wcm9wZXJ0eSkgewo+ICAgCQlyZXQgPSBkcm1fYXRvbWljX3Jl cGxhY2VfcHJvcGVydHlfYmxvYl9mcm9tX2lkKGRldiwKPiAgIAkJCQkJJnN0YXRlLT5kZWdhbW1h X2x1dCwKPiBAQCAtNDkxLDYgKzQ5Myw4IEBAIGRybV9hdG9taWNfY3J0Y19nZXRfcHJvcGVydHko c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAgCQkqdmFsID0gc3RhdGUtPmFjdGl2ZTsKPiAgIAll bHNlIGlmIChwcm9wZXJ0eSA9PSBjb25maWctPnByb3BfbW9kZV9pZCkKPiAgIAkJKnZhbCA9IChz dGF0ZS0+bW9kZV9ibG9iKSA/IHN0YXRlLT5tb2RlX2Jsb2ItPmJhc2UuaWQgOiAwOwo+ICsJZWxz ZSBpZiAocHJvcGVydHkgPT0gY29uZmlnLT5wcm9wX3Zycl9lbmFibGVkKQo+ICsJCSp2YWwgPSBz dGF0ZS0+dnJyX2VuYWJsZWQ7Cj4gICAJZWxzZSBpZiAocHJvcGVydHkgPT0gY29uZmlnLT5kZWdh bW1hX2x1dF9wcm9wZXJ0eSkKPiAgIAkJKnZhbCA9IChzdGF0ZS0+ZGVnYW1tYV9sdXQpID8gc3Rh dGUtPmRlZ2FtbWFfbHV0LT5iYXNlLmlkIDogMDsKPiAgIAllbHNlIGlmIChwcm9wZXJ0eSA9PSBj b25maWctPmN0bV9wcm9wZXJ0eSkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9j cnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+IGluZGV4IDVmNDg4YWE4MGJjZC4u ZTRlYjJjODk3ZmY0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBAQCAtMzQwLDYgKzM0MCw4IEBAIGlu dCBkcm1fY3J0Y19pbml0X3dpdGhfcGxhbmVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPiAgIAkJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHkoJmNydGMt PmJhc2UsIGNvbmZpZy0+cHJvcF9tb2RlX2lkLCAwKTsKPiAgIAkJZHJtX29iamVjdF9hdHRhY2hf cHJvcGVydHkoJmNydGMtPmJhc2UsCj4gICAJCQkJCSAgIGNvbmZpZy0+cHJvcF9vdXRfZmVuY2Vf cHRyLCAwKTsKPiArCQlkcm1fb2JqZWN0X2F0dGFjaF9wcm9wZXJ0eSgmY3J0Yy0+YmFzZSwKPiAr CQkJCQkgICBjb25maWctPnByb3BfdnJyX2VuYWJsZWQsIDApOwo+ICAgCX0KPiAgIAo+ICAgCXJl dHVybiAwOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVfY29uZmlnLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVfY29uZmlnLmMKPiBpbmRleCBlZTgwNzg4ZjJjNDAu LjU2NzBjNjdmMjhkNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVfY29u ZmlnLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVfY29uZmlnLmMKPiBAQCAtMzEw LDYgKzMxMCwxMiBAQCBzdGF0aWMgaW50IGRybV9tb2RlX2NyZWF0ZV9zdGFuZGFyZF9wcm9wZXJ0 aWVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+ICAgCWRl di0+bW9kZV9jb25maWcucHJvcF9tb2RlX2lkID0gcHJvcDsKPiAgIAo+ICsJcHJvcCA9IGRybV9w cm9wZXJ0eV9jcmVhdGVfYm9vbChkZXYsIDAsCj4gKwkJCSJWUlJfRU5BQkxFRCIpOwo+ICsJaWYg KCFwcm9wKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsJZGV2LT5tb2RlX2NvbmZpZy5wcm9wX3Zy cl9lbmFibGVkID0gcHJvcDsKPiArCj4gICAJcHJvcCA9IGRybV9wcm9wZXJ0eV9jcmVhdGUoZGV2 LAo+ICAgCQkJRFJNX01PREVfUFJPUF9CTE9CLAo+ICAgCQkJIkRFR0FNTUFfTFVUIiwgMCk7Cj4g ZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRjLmggYi9pbmNsdWRlL2RybS9kcm1fY3J0 Yy5oCj4gaW5kZXggYjIxNDM3YmM5NWJmLi4zOWMzOTAwYWFiM2MgMTAwNjQ0Cj4gLS0tIGEvaW5j bHVkZS9kcm0vZHJtX2NydGMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRjLmgKPiBAQCAt MjkwLDYgKzI5MCwxNSBAQCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgewo+ICAgCSAqLwo+ICAgCXUz MiBwYWdlZmxpcF9mbGFnczsKPiAgIAo+ICsJLyoqCj4gKwkgKiBAdnJyX2VuYWJsZWQ6Cj4gKwkg Kgo+ICsJICogSW5kaWNhdGVzIGlmIHZhcmlhYmxlIHJlZnJlc2ggcmF0ZSBzaG91bGQgYmUgZW5h YmxlZCBmb3IgdGhlIENSVEMuCj4gKwkgKiBTdXBwb3J0IGZvciB0aGUgcmVxdWVzdGVkIHZyciBz dGF0ZSB3aWxsIGRlcGVuZCBvbiBkcml2ZXIgYW5kCj4gKwkgKiBoYXJkd2FyZSBjYXBhYmlsdGl5 IC0gbGFja2luZyBzdXBwb3J0IGlzIG5vdCB0cmVhdGVkIGFzIGZhaWx1cmUuCj4gKwkgKi8KPiAr CWJvb2wgdnJyX2VuYWJsZWQ7Cj4gKwo+ICAgCS8qKgo+ICAgCSAqIEBldmVudDoKPiAgIAkgKgo+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaCBiL2luY2x1ZGUvZHJt L2RybV9tb2RlX2NvbmZpZy5oCj4gaW5kZXggOTI4ZTQxNzJhMGJiLi40OWYyZmNmZGI1ZmMgMTAw NjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29uZmlnLmgKPiArKysgYi9pbmNsdWRl L2RybS9kcm1fbW9kZV9jb25maWcuaAo+IEBAIC02MzksNiArNjM5LDExIEBAIHN0cnVjdCBkcm1f bW9kZV9jb25maWcgewo+ICAgCSAqIGNvbm5lY3RvcnMgbXVzdCBiZSBvZiBhbmQgYWN0aXZlIG11 c3QgYmUgc2V0IHRvIGRpc2FibGVkLCB0b28uCj4gICAJICovCj4gICAJc3RydWN0IGRybV9wcm9w ZXJ0eSAqcHJvcF9tb2RlX2lkOwo+ICsJLyoqCj4gKwkgKiBAcHJvcF92cnJfZW5hYmxlZDogRGVm YXVsdCBhdG9taWMgQ1JUQyBwcm9wZXJ0eSB0byBpbmRpY2F0ZQo+ICsJICogd2hldGhlciB2YXJp YWJsZSByZWZyZXNoIHJhdGUgc2hvdWxkIGJlIGVuYWJsZWQgb24gdGhlIENSVEMuCj4gKwkgKi8K PiArCXN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3BfdnJyX2VuYWJsZWQ7Cj4gICAKPiAgIAkvKioK PiAgIAkgKiBAZHZpX2lfc3ViY29ubmVjdG9yX3Byb3BlcnR5OiBPcHRpb25hbCBEVkktSSBwcm9w ZXJ0eSB0bwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==