From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [PATCH] drm/meson: Fix an un-handled error path in 'meson_drv_bind_master()' Date: Tue, 26 Jun 2018 10:26:19 +0200 Message-ID: References: <20180611165335.24542-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 784136E49B for ; Tue, 26 Jun 2018 08:26:22 +0000 (UTC) Received: by mail-wr0-x243.google.com with SMTP id p12-v6so14630842wrn.11 for ; Tue, 26 Jun 2018 01:26:22 -0700 (PDT) In-Reply-To: <20180611165335.24542-1-christophe.jaillet@wanadoo.fr> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christophe JAILLET , weiyongjun1@huawei.com, airlied@linux.ie, carlo@caione.org, khilman@baylibre.com Cc: linux-amlogic@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMTEvMDYvMjAxOCAxODo1MywgQ2hyaXN0b3BoZSBKQUlMTEVUIHdyb3RlOgo+IElmICdwbGF0 Zm9ybV9nZXRfcmVzb3VyY2VfYnluYW1lKCknIGZhaWxzLCB3ZSBzaG91bGQgcmVsZWFzZSBzb21l IHJlc291cmNlcwo+IGJlZm9yZSBsZWF2aW5nLCBhcyBhbHJlYWR5IGRvbmUgaW4gdGhlIG90aGVy IGVycm9yIGhhbmRsaW5nIHBhdGggb2YgdGhlCj4gZnVuY3Rpb24uCj4gCj4gRml4ZXM6IGFjYWEz ZjEzYjhkZCAoImRybS9tZXNvbjogRml4IHBvdGVudGlhbCBOVUxMIGRlcmVmZXJlbmNlIGluIG1l c29uX2Rydl9iaW5kX21hc3RlcigpIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGhlIEpBSUxM RVQgPGNocmlzdG9waGUuamFpbGxldEB3YW5hZG9vLmZyPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vbWVzb24vbWVzb25fZHJ2LmMgfCAxMiArKysrKysrKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDggaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL21lc29uL21lc29uX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29u X2Rydi5jCj4gaW5kZXggMzJiMWE2Y2RlY2ZjLi5kMzQ0MzEyNWU2NjEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29uX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L21lc29uL21lc29uX2Rydi5jCj4gQEAgLTE5Nyw4ICsxOTcsMTAgQEAgc3RhdGljIGludCBtZXNv bl9kcnZfYmluZF9tYXN0ZXIoc3RydWN0IGRldmljZSAqZGV2LCBib29sIGhhc19jb21wb25lbnRz KQo+ICAJcHJpdi0+aW9fYmFzZSA9IHJlZ3M7Cj4gIAo+ICAJcmVzID0gcGxhdGZvcm1fZ2V0X3Jl c291cmNlX2J5bmFtZShwZGV2LCBJT1JFU09VUkNFX01FTSwgImhoaSIpOwo+IC0JaWYgKCFyZXMp Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwlpZiAoIXJlcykgewo+ICsJCXJldCA9IC1FSU5WQUw7 Cj4gKwkJZ290byBmcmVlX2RybTsKPiArCX0KPiAgCS8qIFNpbXBseSBpb3JlbWFwIHNpbmNlIGl0 IG1heSBiZSBhIHNoYXJlZCByZWdpc3RlciB6b25lICovCj4gIAlyZWdzID0gZGV2bV9pb3JlbWFw KGRldiwgcmVzLT5zdGFydCwgcmVzb3VyY2Vfc2l6ZShyZXMpKTsKPiAgCWlmICghcmVncykgewo+ IEBAIC0yMTUsOCArMjE3LDEwIEBAIHN0YXRpYyBpbnQgbWVzb25fZHJ2X2JpbmRfbWFzdGVyKHN0 cnVjdCBkZXZpY2UgKmRldiwgYm9vbCBoYXNfY29tcG9uZW50cykKPiAgCX0KPiAgCj4gIAlyZXMg PSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2VfYnluYW1lKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAiZG1j Iik7Cj4gLQlpZiAoIXJlcykKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiArCWlmICghcmVzKSB7Cj4g KwkJcmV0ID0gLUVJTlZBTDsKPiArCQlnb3RvIGZyZWVfZHJtOwo+ICsJfQo+ICAJLyogU2ltcGx5 IGlvcmVtYXAgc2luY2UgaXQgbWF5IGJlIGEgc2hhcmVkIHJlZ2lzdGVyIHpvbmUgKi8KPiAgCXJl Z3MgPSBkZXZtX2lvcmVtYXAoZGV2LCByZXMtPnN0YXJ0LCByZXNvdXJjZV9zaXplKHJlcykpOwo+ ICAJaWYgKCFyZWdzKSB7Cj4gCgpBcHBsaWVkIHRvIGRybS1taXNjLWZpeGVzCgpUaGFua3MsCk5l aWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==