From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
"open list:DRM DRIVERS FOR RENESAS R-CAR"
<dri-devel@lists.freedesktop.org>,
"open list:DRM DRIVERS FOR RENESAS R-CAR"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 3/4] drm: rcar-mipi-dsi: Add support for R8A779H0
Date: Wed, 19 Jun 2024 14:11:05 +0200 [thread overview]
Message-ID: <e39c6168-a5a9-4bf8-9612-2a88e8c70d1d@kernel.org> (raw)
In-Reply-To: <kcwneoju3vzz7rdlan3uklgrurk3ewgsk4qbzcqanx3r7ptjyx@hoszmps27r3s>
On 19/06/2024 14:00, Jacopo Mondi wrote:
> Hi Krzysztof
>
> On Wed, Jun 19, 2024 at 01:07:24PM GMT, Krzysztof Kozlowski wrote:
>> On 19/06/2024 12:22, Jacopo Mondi wrote:
>>> Add support for R-Car R8A779H0 V4M which has the same characteristics
>>> of the already supported R-Car V4H R8A779G0.
>>>
>>> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>>>
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then please
>> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
>> Some warnings can be ignored, especially from --strict run, but the code
>> here looks like it needs a fix. Feel free to get in touch if the warning
>> is not clear.
>>
>
> The only report I got was
>
> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
> which for such trivial addition seems overkill, and I presume the
> patch will go through geert or drm anyway
That's still the preference. Having patches, even when trivial, tested
via automation as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-19 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 10:22 [PATCH 0/4] drm: rcar-du: Add support for R8A779H0 Jacopo Mondi
2024-06-19 10:22 ` [PATCH 1/4] drm: rcar-mipi-dsi: Fix CLOCKSET1_LOCK definition Jacopo Mondi
2024-06-19 19:29 ` Laurent Pinchart
2024-06-20 6:40 ` Tomi Valkeinen
2024-06-19 10:22 ` [PATCH 2/4] drm: ti-sn65dsi86: Check bridge connection failure Jacopo Mondi
2024-06-19 19:32 ` Laurent Pinchart
2024-06-20 6:43 ` Tomi Valkeinen
2024-06-20 10:42 ` Laurent Pinchart
2024-06-20 11:00 ` Tomi Valkeinen
2024-06-19 10:22 ` [PATCH 3/4] drm: rcar-mipi-dsi: Add support for R8A779H0 Jacopo Mondi
2024-06-19 11:07 ` Krzysztof Kozlowski
2024-06-19 12:00 ` Jacopo Mondi
2024-06-19 12:11 ` Krzysztof Kozlowski [this message]
2024-06-19 10:22 ` [PATCH 4/4] drm: rcar-du: " Jacopo Mondi
2024-06-19 19:44 ` Laurent Pinchart
2024-06-20 12:48 ` Geert Uytterhoeven
2024-06-20 16:48 ` Jacopo Mondi
2024-06-20 16:57 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e39c6168-a5a9-4bf8-9612-2a88e8c70d1d@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox