From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data() Date: Tue, 20 Sep 2016 12:32:43 +0200 Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <3c9785ef-4553-2e3d-2cb2-5cf6d1f31ccd@users.sourceforge.net> <287833f5-f1ad-b7f0-c614-d4c903b1c890@users.sourceforge.net> <87shsulw9k.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87shsulw9k.fsf@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jani Nikula Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Patrik Jakobsson , Julia Lawall , kernel-janitors@vger.kernel.org, LKML List-Id: dri-devel@lists.freedesktop.org >> A single error message should be sufficient to inform about >> the detection of an unknown GCT revision at the end. >> Thus return after the logging call in this case directly. > > Did you test this? What is your software development opinion for this update suggestion? Regards, Markus