Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

Thomas Hellström
2022-01-27T12:45:34Z

On 1/27/22 13:38, Maarten Lankhorst wrote:
> Op 27-01-2022 om 13:09 schreef Thomas Hellström:
>> On 1/27/22 13:05, Thomas Hellström wrote:
>>>> The bug on vm_close is a separate bug, and would probably best be
>>>> fixed in a separate patch.
>>>>
>>>> Could I get a r-b on this? It should fix some issues, even if the
>>>> unbind there is a separate bug.
>>>>
>>>> ~Maarten
>>>>
>>> Recognizing that it doesn't fix the vm_close issue,
>>>
>>> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Oh, BTW should probably carefully review those seemingly unrelated stall warnings from BAT to check whether the newly introduced object lock might stall a workqueue causing those.
>>
>> /Thomas
> Which ones? I mostly see ext4 failures, where it doesn't seem to have any i915 lock held at all.
>
Oh, I was looking at v1 version of the patch, but just noticed a hang.
Didn't look to carefully at what was the cause.

/Thomas