From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A47E4C4167B for ; Wed, 8 Nov 2023 21:07:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFDEB10E85B; Wed, 8 Nov 2023 21:07:46 +0000 (UTC) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 250D610E85B for ; Wed, 8 Nov 2023 21:07:43 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A16D580918; Wed, 8 Nov 2023 16:07:41 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 16:07:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=FzEkiJbbsOcjeyoGRwxvz+27m/0EEN52kEtbmSfnSLxjsunhTiL NfUpLQ2lMaNQM96rJSWMhX1vu2lvWTmYQ+94rPQoTRikLBiEjVkhx122mvhBFjKQ U5TGFlasJtrQz1D7CH1hVXq/4CUXHEmC0SXgOgbsxsmqVBXPjJ6IiWR1L/VYLFZD XaGxAnAinQklWeTyoPeeAGtYUUQIZX8H/zBze0un/GO9mbGPspFKceZcmPF+unL4 kNNYqyz4Nnv3vLyDQfTWJAwW2so0MUevk7DJxqisp5Xl7R8/m+axDeNitBypskfX D8Rsn3kpcQJ2fu6hUerp+k7/Bpi8xmjAE2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699477661; x=1699484861; bh=D9PBCL8QJKdjrKS2aPJfuUQXeRbWRMeFHOK ckMk8fx4=; b=LmqNAy3jRW8lY5IcykLYM+OvjkcYQjDv2Cd5j1qdrakTjXXA/j+ /E3SAMCFGeXJAd+vBXJDuwGp38C0j3EBw7K0I7TFk+KdegquYjjlo+2qe+Ss6fEx vTFJPMC1jaxZ1RiQPNLyTH4/PtfJEIBJRBDr+VVRztDGI1MBoVaVcWj5nK9n57lT IBiw5NhM15aVUl9nTNk4GEH/jjyPtDc5nRFt1GtJMHbfoOK2CNQf2Dsq4mugP1kK dALzlNsXk+kultkDq6XTINxe/wKYr9lcblw8RuAMeZQf5KYd1CJy2yk9Lj+caD2x oxDrnMalA2nkjbwEcTlCPYvCvjr0Nrwhw/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48539B60089; Wed, 8 Nov 2023 16:07:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> Date: Wed, 08 Nov 2023 22:07:18 +0100 From: "Arnd Bergmann" To: "Geert Uytterhoeven" , "Arnd Bergmann" Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , linux-fbdev@vger.kernel.org, x86@kernel.org, loongarch@lists.linux.dev, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Netdev , guoren , Anil S Keshavamurthy , Helge Deller , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Vincenzo Frascino , Will Deacon , Ard Biesheuvel , Nicolas Schier , linux-s390@vger.kernel.org, Vincent Guittot , Michael Ellerman , Masahiro Yamada , Huacai Chen , Russell King , Christophe Leroy , Greg Ungerer , "linux-bcachefs@vger.kernel.org" , Ingo Molnar , Vineet Gupta , "Naveen N. Rao" , Matt Turner , linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, Kees Cook , linux-kbuild@vger.kernel.org, Heiko Carstens , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Nathan Chancellor , linux-m68k@lists.linux-m68k.org, "linux-csky@vger.kernel.org" , Steven Rostedt , Andy Lutomirski , John Paul Adrian Glaubitz , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Michal Simek , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Timur Tabi , Geoff Levand , Greg Kroah-Hartman , Kent Overstreet , Nick Desaulniers , linux-kernel@vger.kernel.org, Sudip Mukherjee , Dinh Nguyen , linux-usb@vger.kernel.org, Palmer Dabbelt , Masami Hiramatsu , linux-alpha@vger.kernel.org, linux-mtd@lists.infradead.org, Andrew Morton , David Woodhouse , "David S . Miller" , Alexander Viro Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01=E2=80=AFPM Arnd Bergmann = wrote: >> From: Arnd Bergmann >> >> Microblaze runs into a single -Wmissing-prototypes warning when that = is >> enabled: >> >> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype f= or 'trap_init' [-Wmissing-prototypes] >> >> Include the right header to avoid this. >> >> Signed-off-by: Arnd Bergmann > > Thanks for your patch! > >> arch/alpha/kernel/traps.c | 1 + >> arch/csky/include/asm/traps.h | 2 -- >> arch/csky/kernel/traps.c | 1 + >> arch/m68k/coldfire/vectors.c | 3 +-- >> arch/m68k/coldfire/vectors.h | 3 --- > > Ah, so this is where the m68k changes listed in the cover letter are > hiding ;-) > >> arch/microblaze/kernel/traps.c | 1 + >> arch/sparc/kernel/traps_32.c | 1 + >> arch/sparc/kernel/traps_64.c | 1 + >> arch/x86/include/asm/traps.h | 1 - >> arch/x86/kernel/traps.c | 1 + >> 10 files changed, 7 insertions(+), 8 deletions(-) >> delete mode 100644 arch/m68k/coldfire/vectors.h > > Obviously the non-microblaze changes should be spun off in separate > patches. I messed up one of my rebases here and accidentally sent the wrong changelog text. My intention was to have the combined patch but with this text: arch: include linux/cpu.h for trap_init() prototype =20 some architectures run into a -Wmissing-prototypes warning for trap_init() =20 arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype = for 'trap_init' [-Wmissing-prototypes] =20 Include the right header to avoid this consistently, removing the extra declarations on m68k and x86 that were added as local workarounds already. =20 Signed-off-by: Arnd Bergmann I made the same mistake with the "arch: add do_page_fault prototypes" patch that was missing an explanation. Arnd