From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH] drm/omap: fix crash if there's no video PLL Date: Thu, 5 Apr 2018 13:05:14 +0530 Message-ID: References: <20180405065537.29818-1-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 357BE6E6C1 for ; Thu, 5 Apr 2018 07:35:23 +0000 (UTC) In-Reply-To: <20180405065537.29818-1-tomi.valkeinen@ti.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen , dri-devel@lists.freedesktop.org Cc: Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org CgpPbiBUaHVyc2RheSAwNSBBcHJpbCAyMDE4IDEyOjI1IFBNLCBUb21pIFZhbGtlaW5lbiB3cm90 ZToKPiBDb21taXQgOGE3ZWRhNzY4NjY3NWI3M2Q3NGMyMmMwZDViODMwNTlmOWQ3ODNmNiAoImRy bTogb21hcGRybTogZGlzcGM6Cj4gUGFzcyBESVNQQyBwb2ludGVyIHRvIHJlbWFpbmluZyBkaXNw YyBBUEkgZnVuY3Rpb25zIikgbWFkZSBkcGkuYyB1c2UKPiBjdHgtPnBsbCBldmVuIHdoZW4gdGhl cmUncyBubyBQTEwsIGNhdXNpbmcgYSBjcmFzaCBhdCBtb2Rlc2V0IG9uIEFNNAo+IEVWTSwgYW5k IHByZXN1bWFibHkgYWxsIE9NQVAyLzMgYm9hcmRzLgo+IAo+IEZpeCB0aGlzIGJ5IGhhdmluZyBz dHJ1Y3QgZHBpX2RhdGEgcG9pbnRlciBpbiB0aGUgY3R4IGluc3RlYWQsIGdpdmluZwo+IGFjY2Vz cyB0byBkaXNwYyB3aXRob3V0IGdvaW5nIHRocm91Z2ggdGhlIHBsbC4KClRlc3RlZCBmb3IgZGlz cGxheSBjb21pbmcgdXAgb24gYm9vdCB3aGljaCB3YXMgZWFybGllciBicm9rZW4gb24KYW00Mzd4 LWdwLWV2bS4KClRlc3RlZC1ieTogS2VlcnRoeSA8ai1rZWVydGh5QHRpLmNvbT4KCj4gCj4gU2ln bmVkLW9mZi1ieTogVG9taSBWYWxrZWluZW4gPHRvbWkudmFsa2VpbmVuQHRpLmNvbT4KPiBSZXBv cnRlZC1ieTogS2VlcnRoeSA8ai1rZWVydGh5QHRpLmNvbT4KPiBDYzogTGF1cmVudCBQaW5jaGFy dCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vb21hcGRybS9kc3MvZHBpLmMgfCAxNSArKysrKysrKy0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2RwaS5jIGIvZHJpdmVycy9ncHUvZHJtL29tYXBk cm0vZHNzL2RwaS5jCj4gaW5kZXggZmIxYzI3ZjY5ZTNhLi4zZDY2MmU2ODA1ZWIgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2RwaS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL29tYXBkcm0vZHNzL2RwaS5jCj4gQEAgLTE0Miw3ICsxNDIsNyBAQCBzdGF0aWMgZW51 bSBkc3NfY2xrX3NvdXJjZSBkcGlfZ2V0X2Nsa19zcmMoc3RydWN0IGRwaV9kYXRhICpkcGkpCj4g IH0KPiAgCj4gIHN0cnVjdCBkcGlfY2xrX2NhbGNfY3R4IHsKPiAtCXN0cnVjdCBkc3NfcGxsICpw bGw7Cj4gKwlzdHJ1Y3QgZHBpX2RhdGEgKmRwaTsKPiAgCXVuc2lnbmVkIGludCBjbGtvdXRfaWR4 Owo+ICAKPiAgCS8qIGlucHV0cyAqLwo+IEBAIC0xOTEsNyArMTkxLDcgQEAgc3RhdGljIGJvb2wg ZHBpX2NhbGNfaHNkaXZfY2IoaW50IG1fZGlzcGMsIHVuc2lnbmVkIGxvbmcgZGlzcGMsCj4gIAlj dHgtPnBsbF9jaW5mby5tWFtjdHgtPmNsa291dF9pZHhdID0gbV9kaXNwYzsKPiAgCWN0eC0+cGxs X2NpbmZvLmNsa291dFtjdHgtPmNsa291dF9pZHhdID0gZGlzcGM7Cj4gIAo+IC0JcmV0dXJuIGRp c3BjX2Rpdl9jYWxjKGN0eC0+cGxsLT5kc3MtPmRpc3BjLCBkaXNwYywKPiArCXJldHVybiBkaXNw Y19kaXZfY2FsYyhjdHgtPmRwaS0+ZHNzLT5kaXNwYywgZGlzcGMsCj4gIAkJCSAgICAgIGN0eC0+ cGNrX21pbiwgY3R4LT5wY2tfbWF4LAo+ICAJCQkgICAgICBkcGlfY2FsY19kaXNwY19jYiwgY3R4 KTsKPiAgfQo+IEBAIC0yMDgsOCArMjA4LDggQEAgc3RhdGljIGJvb2wgZHBpX2NhbGNfcGxsX2Ni KGludCBuLCBpbnQgbSwgdW5zaWduZWQgbG9uZyBmaW50LAo+ICAJY3R4LT5wbGxfY2luZm8uZmlu dCA9IGZpbnQ7Cj4gIAljdHgtPnBsbF9jaW5mby5jbGtkY28gPSBjbGtkY287Cj4gIAo+IC0JcmV0 dXJuIGRzc19wbGxfaHNkaXZfY2FsY19hKGN0eC0+cGxsLCBjbGtkY28sCj4gLQkJY3R4LT5wY2tf bWluLCBkc3NfZ2V0X21heF9mY2tfcmF0ZShjdHgtPnBsbC0+ZHNzKSwKPiArCXJldHVybiBkc3Nf cGxsX2hzZGl2X2NhbGNfYShjdHgtPmRwaS0+cGxsLCBjbGtkY28sCj4gKwkJY3R4LT5wY2tfbWlu LCBkc3NfZ2V0X21heF9mY2tfcmF0ZShjdHgtPmRwaS0+ZHNzKSwKPiAgCQlkcGlfY2FsY19oc2Rp dl9jYiwgY3R4KTsKPiAgfQo+ICAKPiBAQCAtMjE5LDcgKzIxOSw3IEBAIHN0YXRpYyBib29sIGRw aV9jYWxjX2Rzc19jYih1bnNpZ25lZCBsb25nIGZjaywgdm9pZCAqZGF0YSkKPiAgCj4gIAljdHgt PmZjayA9IGZjazsKPiAgCj4gLQlyZXR1cm4gZGlzcGNfZGl2X2NhbGMoY3R4LT5wbGwtPmRzcy0+ ZGlzcGMsIGZjaywKPiArCXJldHVybiBkaXNwY19kaXZfY2FsYyhjdHgtPmRwaS0+ZHNzLT5kaXNw YywgZmNrLAo+ICAJCQkgICAgICBjdHgtPnBja19taW4sIGN0eC0+cGNrX21heCwKPiAgCQkJICAg ICAgZHBpX2NhbGNfZGlzcGNfY2IsIGN0eCk7Cj4gIH0KPiBAQCAtMjMwLDcgKzIzMCw3IEBAIHN0 YXRpYyBib29sIGRwaV9wbGxfY2xrX2NhbGMoc3RydWN0IGRwaV9kYXRhICpkcGksIHVuc2lnbmVk IGxvbmcgcGNrLAo+ICAJdW5zaWduZWQgbG9uZyBjbGtpbjsKPiAgCj4gIAltZW1zZXQoY3R4LCAw LCBzaXplb2YoKmN0eCkpOwo+IC0JY3R4LT5wbGwgPSBkcGktPnBsbDsKPiArCWN0eC0+ZHBpID0g ZHBpOwo+ICAJY3R4LT5jbGtvdXRfaWR4ID0gZHNzX3BsbF9nZXRfY2xrb3V0X2lkeF9mb3Jfc3Jj KGRwaS0+Y2xrX3NyYyk7Cj4gIAo+ICAJY2xraW4gPSBjbGtfZ2V0X3JhdGUoZHBpLT5wbGwtPmNs a2luKTsKPiBAQCAtMjQ0LDcgKzI0NCw3IEBAIHN0YXRpYyBib29sIGRwaV9wbGxfY2xrX2NhbGMo c3RydWN0IGRwaV9kYXRhICpkcGksIHVuc2lnbmVkIGxvbmcgcGNrLAo+ICAJCXBsbF9taW4gPSAw Owo+ICAJCXBsbF9tYXggPSAwOwo+ICAKPiAtCQlyZXR1cm4gZHNzX3BsbF9jYWxjX2EoY3R4LT5w bGwsIGNsa2luLAo+ICsJCXJldHVybiBkc3NfcGxsX2NhbGNfYShjdHgtPmRwaS0+cGxsLCBjbGtp biwKPiAgCQkJCXBsbF9taW4sIHBsbF9tYXgsCj4gIAkJCQlkcGlfY2FsY19wbGxfY2IsIGN0eCk7 Cj4gIAl9IGVsc2UgeyAvKiBEU1NfUExMX1RZUEVfQiAqLwo+IEBAIC0yNzUsNiArMjc1LDcgQEAg c3RhdGljIGJvb2wgZHBpX2Rzc19jbGtfY2FsYyhzdHJ1Y3QgZHBpX2RhdGEgKmRwaSwgdW5zaWdu ZWQgbG9uZyBwY2ssCj4gIAkJYm9vbCBvazsKPiAgCj4gIAkJbWVtc2V0KGN0eCwgMCwgc2l6ZW9m KCpjdHgpKTsKPiArCQljdHgtPmRwaSA9IGRwaTsKPiAgCQlpZiAocGNrID4gMTAwMCAqIGkgKiBp ICogaSkKPiAgCQkJY3R4LT5wY2tfbWluID0gbWF4KHBjayAtIDEwMDAgKiBpICogaSAqIGksIDBs dSk7Cj4gIAkJZWxzZQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK