From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09F0BC433FE for ; Wed, 5 Oct 2022 13:33:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3C4710E625; Wed, 5 Oct 2022 13:32:58 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3B6610E625; Wed, 5 Oct 2022 13:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664976776; x=1696512776; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=eILrqrbum5QwAkBtdxqbrJnoct2lE9sWsCAfF3dyF/Q=; b=dIpC8Ho1up6yISb9Wnuo3kmC5PINc/OCO+fS7FgYvPCDcUhTukQK8qSL 5THj7i9GYm8Dl0RFXJWgK3ldJPYDZjarllruxE1Ys7U3MDQYGTPLwZQQi 9dIKAl8r/sBxXd9bxNme2ugBfLrsL1i0WhmsiTuCVbysQ6pdB59L2fx6G FDaxeG9QQsXC5xZnVnDKrg10k7H8cQ1GtGWfc3BtvNAKf2zdWMshjNHwF N5/w+ZNsHDdIb/yffzl83E5MX7syc7N3yHbdQFXbz0MYSmdi12zbdmYY3 wvbgvM4sYuL9pg6QMksANo20jeuq8nqvon1BULdcIIZNRZY+WAFfwp2O4 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="329571263" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="329571263" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2022 06:32:56 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="624309124" X-IronPort-AV: E=Sophos;i="5.95,159,1661842800"; d="scan'208";a="624309124" Received: from vadimbel-mobl2.ger.corp.intel.com (HELO [10.252.23.121]) ([10.252.23.121]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2022 06:32:54 -0700 Message-ID: Date: Wed, 5 Oct 2022 14:32:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.3.1 Subject: Re: [PATCH RESEND] drm/i915: Fix display problems after resume Content-Language: en-GB To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org References: <20221005121159.340245-1-thomas.hellstrom@linux.intel.com> From: Matthew Auld In-Reply-To: <20221005121159.340245-1-thomas.hellstrom@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Boulain , David de Sousa , stable@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas, On 05/10/2022 13:11, Thomas Hellström wrote: > Commit 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt > binding / unbinding") introduced a regression that due to the vma resource > tracking of the binding state, dpt ptes were not correctly repopulated. > Fix this by clearing the vma resource state before repopulating. > The state will subsequently be restored by the bind_vma operation. > > Fixes: 39a2bd34c933 ("drm/i915: Use the vma resource as argument for gtt binding / unbinding") > Signed-off-by: Thomas Hellström > Link: https://patchwork.freedesktop.org/patch/msgid/20220912121957.31310-1-thomas.hellstrom@linux.intel.com > Cc: Matthew Auld > Cc: intel-gfx@lists.freedesktop.org > Cc: # v5.18+ > Reported-and-tested-by: Kevin Boulain > Tested-by: David de Sousa Reviewed-by: Matthew Auld