Re: [PATCH v5] drm/panel: simple: Add TFC S9700RTWV43TR-01B 800x480 panel support

[Jyri Sarha <jsarha@ti.com>]

On 04/27/18 17:25, Rob Herring wrote:
> On Thu, Apr 26, 2018 at 10:48:22PM +0300, Jyri Sarha wrote:
>> Add support for Three Five displays TFC S9700RTWV43TR-01B 800x480
>> panel with resistive touch found on TI's AM335X-EVM.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> cc: Thierry Reding <thierry.reding@gmail.com>
>> ---
>> Thanks Thierry, for reminding me about this!
>>
>> Changes since v4:
>> - Add tfc to vendor-prefixes.txt
>>
>>  .../display/panel/tfc,s9700rtwv43tr-01b.txt        | 10 +++++++++
>>  .../devicetree/bindings/vendor-prefixes.txt        |  1 +
>>  drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++++++++++
>>  3 files changed, 37 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt b/Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
>> new file mode 100644
>> index 0000000..0b1cc71
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
>> @@ -0,0 +1,10 @@
>> +TFC S9700RTWV43TR-01B 7" Three Five Corp 800x480 LCD panel with
>> +resistive touch
>> +
>> +The panel is found on TI AM335x-evm.
>> +
>> +Required properties:
>> +- compatible: should be "tfc,S9700RTWV43tr-01b"
>> +
>> +This binding is compatible with the simple-panel binding, which is specified
>> +in simple-panel.txt in this directory.
> 
> You need to state what properties from this apply. For example, I don't 
> know if power-supply is not used, used, or you made a mistake and the 
> panel has more than one supply.
> 

The implementation is the same as with the other panels supported by the
simple panel driver. So all the properties are supported. However, the
"power" regulator is taken with devm_regulator_get(), which will supply
a dummy regulator in case there is no regulator in the device node.

So the power property is in fact optional. Should the simple-panel
binding be updated?

In AM335x-evm, that has the panel in question, there is no regulator to
control and the panel is powered all the time when the board is on. But
for sure there can be a board design that has a regulator to control
power supply for the display. The panel need power after all.

BR,
Jyri

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel