From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>, Conor Dooley <conor@kernel.org>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
Date: Thu, 16 Nov 2023 18:17:31 +0100 [thread overview]
Message-ID: <e9daa8cc-9cdd-4b76-96b9-b9a6b1ef6f5e@linaro.org> (raw)
In-Reply-To: <20231116162855.GA2435337-robh@kernel.org>
On 16/11/2023 17:28, Rob Herring wrote:
> On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
>> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
>>> When number of clock varies between variants, the Devicetree bindings
>>> coding convention expects to have widest constraints in top-level
>>> definition of the properties and narrow them in allOf:if:then block.
>>>
>>> This is more readable and sometimes allows to spot some errors in the
>>> bindings.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>>
>> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
>
> ^
>
> Not an 'A'. I only caught this because I go thru everything
> Acked/Reviewed-by first and this one was missed.
And in Norwegian it is pronounced as "o", so this would be ocked-by :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-16 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
2023-11-12 18:44 ` [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention Krzysztof Kozlowski
2023-11-13 13:50 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
2023-11-13 13:51 ` Conor Dooley
2023-11-16 16:28 ` Rob Herring
2023-11-16 17:17 ` Krzysztof Kozlowski [this message]
2023-11-16 17:24 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains Krzysztof Kozlowski
2023-11-13 13:49 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 5/5] dt-bindings: gpu: samsung-scaler: " Krzysztof Kozlowski
2023-11-13 13:49 ` Conor Dooley
2023-11-13 13:48 ` [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Conor Dooley
2023-11-14 15:21 ` Rob Herring
2023-12-08 13:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9daa8cc-9cdd-4b76-96b9-b9a6b1ef6f5e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).