From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734BCC433FE for ; Sun, 13 Dec 2020 17:36:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CFCA23355 for ; Sun, 13 Dec 2020 17:36:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CFCA23355 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E33389AC2; Sun, 13 Dec 2020 17:36:35 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E27C89AC2; Sun, 13 Dec 2020 17:36:34 +0000 (UTC) IronPort-SDR: hPP8FTV86WFYVW1XcYfqy1cCKlklCg774NMN6joh07fmUSOzZLZgMpD17//Izv9jzn8HkFaagW oVrdMqR2iu0g== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="173850610" X-IronPort-AV: E=Sophos;i="5.78,416,1599548400"; d="scan'208";a="173850610" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2020 09:36:33 -0800 IronPort-SDR: Pwj4vBd4+/AJTcB25ebZmGqzfCCiYOvpGgtNEDqDXwX4CSCpGOqk3MLanJaILp4+g+miHImprY Dk/9NOeS6l3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,416,1599548400"; d="scan'208";a="350915894" Received: from irsmsx602.ger.corp.intel.com ([163.33.146.8]) by orsmga002.jf.intel.com with ESMTP; 13 Dec 2020 09:36:31 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by irsmsx602.ger.corp.intel.com (163.33.146.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 13 Dec 2020 17:36:30 +0000 Received: from orsmsx610.amr.corp.intel.com ([10.22.229.23]) by ORSMSX610.amr.corp.intel.com ([10.22.229.23]) with mapi id 15.01.1713.004; Sun, 13 Dec 2020 09:36:28 -0800 From: "Souza, Jose" To: "contact@emersion.fr" Subject: Re: [PATCH] drm/damage_helper: Check if damage clips has valid values Thread-Topic: [PATCH] drm/damage_helper: Check if damage clips has valid values Thread-Index: AQHW0XJpc9Vzs4eMcESLWmawfA0ONqn1zGMAgAAD6gA= Date: Sun, 13 Dec 2020 17:36:28 +0000 Message-ID: References: <20201213170728.290406-1-jose.souza@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.100] Content-ID: <43BA5157097E434B81C69318A90DB45B@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "drawat@vmware.com" , "seanpaul@chromium.org" , "dri-devel@lists.freedesktop.org" , "Mun, Gwan-gyeong" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, 2020-12-13 at 17:22 +0000, Simon Ser wrote: > Can you add some drm_dbg_atomic logs when the damage is invalid, to make it > easier for user-space to understand why an atomic commit failed? sure, this is enough? will wait for a couple of more days before send another version. diff --git a/drivers/gpu/drm/drm_damage_helper.c b/drivers/gpu/drm/drm_damage_helper.c index 9adb369440ba..b598b137d27f 100644 --- a/drivers/gpu/drm/drm_damage_helper.c +++ b/drivers/gpu/drm/drm_damage_helper.c @@ -33,6 +33,7 @@ #include #include #include +#include /** * DOC: overview @@ -152,16 +153,25 @@ int drm_atomic_helper_check_plane_damage(struct drm_atomic_state *state, for (; num_clips; num_clips--, damaged_clips++) { if (damaged_clips->x1 < 0 || damaged_clips->x2 < 0 || - damaged_clips->y1 < 0 || damaged_clips->y2 < 0) + damaged_clips->y1 < 0 || damaged_clips->y2 < 0) { + drm_dbg_atomic(state->dev, + "Invalid damage clip, negative coordinate\n"); return -EINVAL; + } if (damaged_clips->x2 < damaged_clips->x1 || - damaged_clips->y2 < damaged_clips->y1) + damaged_clips->y2 < damaged_clips->y1) { + drm_dbg_atomic(state->dev, + "Invalid damage clip, negative width or height\n"); return -EINVAL; + } if ((damaged_clips->x2 - damaged_clips->x1) > w || - (damaged_clips->y2 - damaged_clips->y1) > h) + (damaged_clips->y2 - damaged_clips->y1) > h) { + drm_dbg_atomic(state->dev, + "Invalid damage clip, width or height larger than plane\n"); return -EINVAL; + } } return 0; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel