dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krishna Manikandan <quic_mkrishn@quicinc.com>,
	Jonathan Marek <jonathan@marek.ca>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Rob Clark <robin.clark@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Abel Vesa <abel.vesa@linaro.org>,
	Srinivas Kandagatla <srini@kernel.org>
Subject: Re: [PATCH v6 13/17] drm/msm/dpu: Consistently use u32 instead of uint32_t
Date: Tue, 10 Jun 2025 16:10:05 +0200	[thread overview]
Message-ID: <eb9bd4e4-3032-4f36-94e7-b89ff74bf327@linaro.org> (raw)
In-Reply-To: <20250610-b4-sm8750-display-v6-13-ee633e3ddbff@linaro.org>

On 10/06/2025 16:05, Krzysztof Kozlowski wrote:
> Linux coding style asks to use kernel types like u32 instead of uint32_t
> and code already has it in other places, so unify the remaining pieces.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 
> Changes in v6:
> 1. New patch
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index a4b0fe0d9899b32141928f0b6a16503a49b3c27a..92f6c39eee3dc090bd957239e58793e5b0437548 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -323,8 +323,8 @@ static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer,
>   		struct dpu_plane_state *pstate, const struct msm_format *format)
>   {
>   	struct dpu_hw_mixer *lm = mixer->hw_lm;
> -	uint32_t blend_op;
> -	uint32_t fg_alpha, bg_alpha;
> +	u32 blend_op;
> +	u32 fg_alpha, bg_alpha;
>   
>   	fg_alpha = pstate->base.alpha >> 8;
>   	bg_alpha = 0xff - fg_alpha;
> @@ -402,7 +402,7 @@ static void _dpu_crtc_blend_setup_pipe(struct drm_crtc *crtc,
>   				       struct dpu_hw_stage_cfg *stage_cfg
>   				      )
>   {
> -	uint32_t lm_idx;
> +	u32 lm_idx;
>   	enum dpu_sspp sspp_idx;
>   	struct drm_plane_state *state;
>   
> @@ -442,8 +442,7 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
>   	struct dpu_plane_state *pstate = NULL;
>   	const struct msm_format *format;
>   	struct dpu_hw_ctl *ctl = mixer->lm_ctl;
> -
> -	uint32_t lm_idx;
> +	u32 lm_idx;
>   	bool bg_alpha_enable = false;
>   	DECLARE_BITMAP(active_fetch, SSPP_MAX);
>   
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

  reply	other threads:[~2025-06-10 14:10 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 14:05 [PATCH v6 00/17] drm/msm: Add support for SM8750 Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 01/17] dt-bindings: display/msm: dsi-phy-7nm: Add SM8750 Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 02/17] dt-bindings: display/msm: dsi-controller-main: " Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 03/17] dt-bindings: display/msm: dp-controller: " Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 04/17] dt-bindings: display/msm: qcom,sm8650-dpu: " Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 05/17] dt-bindings: display/msm: qcom,sm8750-mdss: " Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 06/17] drm/msm/dsi/phy: Toggle back buffer resync after preparing PLL Krzysztof Kozlowski
2025-08-13 18:25   ` Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 07/17] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields Krzysztof Kozlowski
2025-06-10 22:23   ` Dmitry Baryshkov
2025-06-10 14:05 ` [PATCH v6 08/17] drm/msm/dsi/phy: Fix reading zero as PLL rates when unprepared Krzysztof Kozlowski
2025-06-13 13:55   ` Dmitry Baryshkov
2025-06-13 14:02     ` Krzysztof Kozlowski
2025-06-13 14:04       ` Dmitry Baryshkov
2025-06-18  8:28         ` Krzysztof Kozlowski
2025-06-18 13:07           ` Dmitry Baryshkov
2025-06-18 13:34             ` Krzysztof Kozlowski
2025-06-18 13:35               ` Krzysztof Kozlowski
2025-06-18 13:39               ` Dmitry Baryshkov
2025-06-18 13:54                 ` Krzysztof Kozlowski
2025-06-18 13:58                   ` Dmitry Baryshkov
2025-06-18 14:01                     ` Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 09/17] drm/msm/dsi/phy_7nm: Fix missing initial VCO rate Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 10/17] drm/msm/dsi/phy: Add support for SM8750 Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 11/17] drm/msm/dsi: " Krzysztof Kozlowski
2025-06-10 22:25   ` Dmitry Baryshkov
2025-06-10 14:05 ` [PATCH v6 12/17] drm/msm/dpu: " Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 13/17] drm/msm/dpu: Consistently use u32 instead of uint32_t Krzysztof Kozlowski
2025-06-10 14:10   ` Neil Armstrong [this message]
2025-06-10 22:25   ` Dmitry Baryshkov
2025-06-10 14:05 ` [PATCH v6 14/17] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU Krzysztof Kozlowski
2025-06-10 14:10   ` Neil Armstrong
2025-06-11  6:21     ` Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 15/17] drm/msm/dpu: Implement CTL_PIPE_ACTIVE " Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 16/17] drm/msm/dpu: Implement LM crossbar " Krzysztof Kozlowski
2025-06-10 14:05 ` [PATCH v6 17/17] drm/msm/mdss: Add support for SM8750 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb9bd4e4-3032-4f36-94e7-b89ff74bf327@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jonathan@marek.ca \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_mkrishn@quicinc.com \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sboyd@kernel.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=srini@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).