From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
jgross@suse.com, konrad.wilk@oracle.com
Cc: daniel.vetter@intel.com, dongwon.kim@intel.com,
matthew.d.roper@intel.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 2/8] xen/balloon: Move common memory reservation routines to a module
Date: Tue, 29 May 2018 16:03:09 -0400 [thread overview]
Message-ID: <edfa937b-3311-98db-2e6f-b4083598f796@oracle.com> (raw)
In-Reply-To: <89de7bdb-8759-419f-63bf-8ed0d57650f0@gmail.com>
On 05/29/2018 02:22 PM, Oleksandr Andrushchenko wrote:
> On 05/29/2018 09:04 PM, Boris Ostrovsky wrote:
>> On 05/25/2018 11:33 AM, Oleksandr Andrushchenko wrote:
>> @@ -463,11 +457,6 @@ static enum bp_state
>> increase_reservation(unsigned long nr_pages)
>> int rc;
>> unsigned long i;
>> struct page *page;
>> - struct xen_memory_reservation reservation = {
>> - .address_bits = 0,
>> - .extent_order = EXTENT_ORDER,
>> - .domid = DOMID_SELF
>> - };
>> if (nr_pages > ARRAY_SIZE(frame_list))
>> nr_pages = ARRAY_SIZE(frame_list);
>> @@ -486,9 +475,7 @@ static enum bp_state
>> increase_reservation(unsigned long nr_pages)
>> page = balloon_next_page(page);
>> }
>> - set_xen_guest_handle(reservation.extent_start, frame_list);
>> - reservation.nr_extents = nr_pages;
>> - rc = HYPERVISOR_memory_op(XENMEM_populate_physmap, &reservation);
>> + rc = xenmem_reservation_increase(nr_pages, frame_list);
>> if (rc <= 0)
>> return BP_EAGAIN;
>> @@ -496,29 +483,7 @@ static enum bp_state
>> increase_reservation(unsigned long nr_pages)
>> page = balloon_retrieve(false);
>> BUG_ON(page == NULL);
>> -#ifdef CONFIG_XEN_HAVE_PVMMU
>> - /*
>> - * We don't support PV MMU when Linux and Xen is using
>> - * different page granularity.
>> - */
>> - BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE);
>> -
>> - if (!xen_feature(XENFEAT_auto_translated_physmap)) {
>> - unsigned long pfn = page_to_pfn(page);
>> -
>> - set_phys_to_machine(pfn, frame_list[i]);
>> -
>> - /* Link back into the page tables if not highmem. */
>> - if (!PageHighMem(page)) {
>> - int ret;
>> - ret = HYPERVISOR_update_va_mapping(
>> - (unsigned long)__va(pfn << PAGE_SHIFT),
>> - mfn_pte(frame_list[i], PAGE_KERNEL),
>> - 0);
>> - BUG_ON(ret);
>> - }
>> - }
>> -#endif
>> + xenmem_reservation_va_mapping_update(1, &page, &frame_list[i]);
>>
>> Can you make a single call to xenmem_reservation_va_mapping_update(rc,
>> ...)? You need to keep track of pages but presumable they can be put
>> into an array (or a list). In fact, perhaps we can have
>> balloon_retrieve() return a set of pages.
> This is actually how it is used later on for dma-buf, but I just
> didn't want
> to alter original balloon code too much, but this can be done, in
> order of simplicity:
>
> 1. Similar to frame_list, e.g. static array of struct page* of size
> ARRAY_SIZE(frame_list):
> more static memory is used, but no allocations
>
> 2. Allocated at run-time with kcalloc: allocation can fail
If this is called in freeing DMA buffer code path or in error path then
we shouldn't do it.
>
> 3. Make balloon_retrieve() return a set of pages: will require
> list/array allocation
> and handling, allocation may fail, balloon_retrieve prototype change
balloon pages are strung on the lru list. Can we keep have
balloon_retrieve return a list of pages on that list?
-boris
>
> Could you please tell which of the above will fit better?
>
>>
>>
next prev parent reply other threads:[~2018-05-29 20:03 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 15:33 [PATCH 0/8] xen: dma-buf support for grant device Oleksandr Andrushchenko
2018-05-25 15:33 ` [PATCH 1/8] xen/grant-table: Make set/clear page private code shared Oleksandr Andrushchenko
2018-05-29 17:39 ` Boris Ostrovsky
2018-05-30 4:24 ` Juergen Gross
2018-05-30 5:27 ` Oleksandr Andrushchenko
2018-05-30 21:34 ` Dongwon Kim
2018-05-31 5:37 ` Oleksandr Andrushchenko
2018-05-25 15:33 ` [PATCH 2/8] xen/balloon: Move common memory reservation routines to a module Oleksandr Andrushchenko
2018-05-29 18:04 ` Boris Ostrovsky
2018-05-29 18:22 ` Oleksandr Andrushchenko
2018-05-29 20:03 ` Boris Ostrovsky [this message]
2018-05-30 8:29 ` Oleksandr Andrushchenko
2018-05-30 15:54 ` Boris Ostrovsky
2018-05-30 17:46 ` Oleksandr Andrushchenko
2018-05-30 19:24 ` Boris Ostrovsky
2018-05-31 7:51 ` Oleksandr Andrushchenko
2018-05-31 14:29 ` Oleksandr Andrushchenko
2018-05-29 18:24 ` Boris Ostrovsky
2018-05-29 18:23 ` Oleksandr Andrushchenko
2018-05-30 4:32 ` Juergen Gross
2018-05-30 5:30 ` Oleksandr Andrushchenko
2018-05-25 15:33 ` [PATCH 3/8] xen/grant-table: Allow allocating buffers suitable for DMA Oleksandr Andrushchenko
2018-05-29 19:10 ` Boris Ostrovsky
2018-05-30 6:34 ` Oleksandr Andrushchenko
2018-05-30 15:20 ` Boris Ostrovsky
2018-05-30 17:49 ` Oleksandr Andrushchenko
2018-05-30 19:25 ` Boris Ostrovsky
2018-05-25 15:33 ` [PATCH 4/8] xen/gntdev: Allow mappings for DMA buffers Oleksandr Andrushchenko
2018-05-29 21:52 ` Boris Ostrovsky
2018-05-30 6:47 ` Oleksandr Andrushchenko
2018-05-25 15:33 ` [PATCH 5/8] xen/gntdev: Add initial support for dma-buf UAPI Oleksandr Andrushchenko
2018-05-29 22:34 ` Boris Ostrovsky
2018-05-30 6:52 ` Oleksandr Andrushchenko
2018-05-30 6:52 ` Oleksandr Andrushchenko
2018-05-25 15:33 ` [PATCH 6/8] xen/gntdev: Implement dma-buf export functionality Oleksandr Andrushchenko
2018-05-30 23:10 ` Dongwon Kim
2018-05-31 5:55 ` Oleksandr Andrushchenko
2018-05-31 14:32 ` Oleksandr Andrushchenko
2018-05-25 15:33 ` [PATCH 7/8] xen/gntdev: Implement dma-buf import functionality Oleksandr Andrushchenko
2018-05-25 15:33 ` [PATCH 8/8] xen/gntdev: Expose gntdev's dma-buf API for in-kernel use Oleksandr Andrushchenko
2018-05-30 8:32 ` Oleksandr Andrushchenko
2018-05-31 1:46 ` [PATCH 0/8] xen: dma-buf support for grant device Boris Ostrovsky
2018-05-31 5:51 ` Oleksandr Andrushchenko
2018-05-31 14:41 ` Oleksandr Andrushchenko
2018-05-31 20:25 ` Boris Ostrovsky
2018-06-01 5:42 ` Oleksandr Andrushchenko
2018-05-31 19:36 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edfa937b-3311-98db-2e6f-b4083598f796@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andr2000@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=dongwon.kim@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthew.d.roper@intel.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).