From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64365C4332F for ; Tue, 8 Nov 2022 09:29:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9BBE10E254; Tue, 8 Nov 2022 09:29:28 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36D0210E254 for ; Tue, 8 Nov 2022 09:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667899762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G/IvXa3Gtc42ocSwbE6e2PTXEI1xHOCM/WDymiGQVjk=; b=EclQgB/BAXWPmHv1CQSriGjM01041EmwLWXrYJNK4SB8YG848WwPaT3gtRThNKwuxzmdw5 WIGW9R+7AM/5gAAZRH/0L5G44XvsMJQpHiO/l6SjGpDw5LLZtlzG5p9K4gQknYqLCl5Jpf 5BIWRtsM4d1QsnoJfX3bzespR7vjkbA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-538-L71vFh6xP-mrl-__uPsktg-1; Tue, 08 Nov 2022 04:29:21 -0500 X-MC-Unique: L71vFh6xP-mrl-__uPsktg-1 Received: by mail-wm1-f69.google.com with SMTP id i82-20020a1c3b55000000b003cf9bd60855so2473987wma.6 for ; Tue, 08 Nov 2022 01:29:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G/IvXa3Gtc42ocSwbE6e2PTXEI1xHOCM/WDymiGQVjk=; b=D/GYkcC7dJwfBf9JhiELU6RQ8lnCdg/UHPoN4ngU8ODt4ukfrXA10BvoNGKdecAi3O E3QZiu5VadGJgDblOZPQMdQDxSdfCmj8+0fNSZnLUYyv0SHIaImy45ZQ475xVLBRqdv7 Sew5Gi9L/D/5AB5/OIRq3YLqLUsUDeCQXeFFd2+Ri6hcgT2bRSLRIe5FMBoKbViYshxG goz+/R+46Z6YiMvcOIpWz7vKH7CeQLe8w4sAkyrgSnOnzEzz+d1i2u+VvqG+L8OqstX8 riiaGbqoxjZmJg/JkPrBcMMlq8gM9sqaxBxxfrLCLTYSeXwUIuZNGBEj3KdR1JYNwRc9 wZkA== X-Gm-Message-State: ACrzQf3VgX03ZbJo/5BvP9t7rKZhUGTQWTRXkX3ml5DZe3j3HmjmJKpx GV/OlGjRUjpp8YwbSP4CG7EeovUCnFZYiIJpUhnAVYpoDDtWxAu7A6dhSjscl48nrhyYjUGdHK7 7eaZG+TPYQyt3/4gZt56RHoa6NerM X-Received: by 2002:a1c:7418:0:b0:3cf:703a:4f0c with SMTP id p24-20020a1c7418000000b003cf703a4f0cmr31192091wmc.63.1667899760176; Tue, 08 Nov 2022 01:29:20 -0800 (PST) X-Google-Smtp-Source: AMsMyM5StZVkpugFYppLkRHp5xlGTjmqFOUyferk1nDQuYzjbb+gdKwEthZaHv8SGYCGJ8Geu++6Xg== X-Received: by 2002:a1c:7418:0:b0:3cf:703a:4f0c with SMTP id p24-20020a1c7418000000b003cf703a4f0cmr31192042wmc.63.1667899759842; Tue, 08 Nov 2022 01:29:19 -0800 (PST) Received: from ?IPV6:2003:cb:c708:db00:6510:da8d:df40:abbb? (p200300cbc708db006510da8ddf40abbb.dip0.t-ipconnect.de. [2003:cb:c708:db00:6510:da8d:df40:abbb]) by smtp.gmail.com with ESMTPSA id n10-20020a5d420a000000b0023682011c1dsm9563940wrq.104.2022.11.08.01.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 01:29:19 -0800 (PST) Message-ID: Date: Tue, 8 Nov 2022 10:29:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH RFC 00/19] mm/gup: remove FOLL_FORCE usage from drivers (reliable R/O long-term pinning) To: Linus Torvalds References: <20221107161740.144456-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, Hugh Dickins , Matthew Wilcox , Jason Gunthorpe , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , etnaviv@lists.freedesktop.org, Peter Xu , Muchun Song , Vlastimil Babka , Greg Kroah-Hartman , Oded Gabbay , linux-kernel@vger.kernel.org, Andrew Morton , Mike Kravetz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 07.11.22 18:27, Linus Torvalds wrote: > On Mon, Nov 7, 2022 at 8:18 AM David Hildenbrand wrote: >> >> So instead, make R/O long-term pinning work as expected, by breaking COW >> in a COW mapping early, such that we can remove any FOLL_FORCE usage from >> drivers. > > Nothing makes me unhappy from a quick scan through these patches. > > And I'd really love to just have this long saga ended, and FOLL_FORCE > finally relegated to purely ptrace accesses. > > So an enthusiastic Ack from me. Thanks Linus! My hope is that we can remove it from all drivers and not have to leave it in for some corner cases; so far it looks promising. -- Thanks, David / dhildenb