From: "Falkowski, Maciej" <maciej.falkowski@linux.intel.com>
To: Karol Wachowski <karol.wachowski@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com,
lizhi.hou@amd.com, andrzej.kacprowski@linux.intel.com
Subject: Re: [PATCH] accel/ivpu: Apply minor code style cleanups to align with kernel style
Date: Wed, 11 Mar 2026 13:24:27 +0100 [thread overview]
Message-ID: <ef872bed-5aa1-4851-bb28-406e42edcc64@linux.intel.com> (raw)
In-Reply-To: <20260310120736.3341679-1-karol.wachowski@linux.intel.com>
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 3/10/2026 1:07 PM, Karol Wachowski wrote:
> Replace direct import_attach test with drm_gem_is_imported()
> in ivpu_bo_bind().
>
> Replace kzalloc(sizeof(*bo), GFP_KERNEL) with kzalloc_obj()
> in ivpu_gem_create_object().
>
> Remove unnecessary cast to bool in ivpu_dbg_bo().
>
> No functional changes.
>
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_gem.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
> index 8009965286e0..4f2005a8d496 100644
> --- a/drivers/accel/ivpu/ivpu_gem.c
> +++ b/drivers/accel/ivpu/ivpu_gem.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (C) 2020-2023 Intel Corporation
> + * Copyright (C) 2020-2026 Intel Corporation
> */
>
> #include <linux/dma-buf.h>
> @@ -31,7 +31,7 @@ static inline void ivpu_dbg_bo(struct ivpu_device *vdev, struct ivpu_bo *bo, con
> "%6s: bo %8p size %9zu ctx %d vpu_addr %9llx pages %d sgt %d mmu_mapped %d wc %d imported %d\n",
> action, bo, ivpu_bo_size(bo), bo->ctx_id, bo->vpu_addr,
> (bool)bo->base.pages, (bool)bo->base.sgt, bo->mmu_mapped, bo->base.map_wc,
> - (bool)drm_gem_is_imported(&bo->base.base));
> + drm_gem_is_imported(&bo->base.base));
> }
>
> static inline int ivpu_bo_lock(struct ivpu_bo *bo)
> @@ -81,7 +81,7 @@ int __must_check ivpu_bo_bind(struct ivpu_bo *bo)
>
> ivpu_dbg_bo(vdev, bo, "bind");
>
> - if (bo->base.base.import_attach)
> + if (drm_gem_is_imported(&bo->base.base))
> sgt = ivpu_bo_map_attachment(vdev, bo);
> else
> sgt = drm_gem_shmem_get_pages_sgt(&bo->base);
> @@ -195,7 +195,7 @@ struct drm_gem_object *ivpu_gem_create_object(struct drm_device *dev, size_t siz
> if (size == 0 || !PAGE_ALIGNED(size))
> return ERR_PTR(-EINVAL);
>
> - bo = kzalloc(sizeof(*bo), GFP_KERNEL);
> + bo = kzalloc_obj(*bo);
> if (!bo)
> return ERR_PTR(-ENOMEM);
>
next prev parent reply other threads:[~2026-03-11 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 12:07 [PATCH] accel/ivpu: Apply minor code style cleanups to align with kernel style Karol Wachowski
2026-03-11 12:24 ` Falkowski, Maciej [this message]
2026-03-11 12:32 ` Karol Wachowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef872bed-5aa1-4851-bb28-406e42edcc64@linux.intel.com \
--to=maciej.falkowski@linux.intel.com \
--cc=andrzej.kacprowski@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=karol.wachowski@linux.intel.com \
--cc=lizhi.hou@amd.com \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox