Re: [PATCH v2] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support

[Jyri Sarha <jsarha@ti.com>]

On 28/02/18 20:44, Thierry Reding wrote:
> On Wed, Feb 28, 2018 at 12:40:43PM +0200, Jyri Sarha wrote:
>> Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's
>> AM335X-EVM.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>> The only change is added "Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>".
>> Who is going to pick this up?
>>
>> The first version of the patch can be found here:
>> https://lists.freedesktop.org/archives/dri-devel/2018-February/166902.html
>>
>>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 5591984..3b0ba9f 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1962,6 +1962,29 @@ static const struct panel_desc tpk_f10a_0102 = {
>>  	},
>>  };
>>  
>> +static const struct drm_display_mode tvc_s9700rtwv43tr_01b_mode = {
>> +	.clock = 3000,
> 
> This seems to be missing a 0. Does the panel even work with 3 MHz? I'd
> be somewhat surprised if it did.
> 

Thanks a lot for catching that!

I am still debugging how the system could even work with that clock
rate. Looks like there is something fishy in our clock framework, the
clock wont go down that much but it reports that it did. In reality it
produced about 12MHz clock but reported that it was 3Mhz. The 12MHz
appeared to be just fine by the panel.

But anyway, that is another story, I'll fix that (it was supposed to be
30MHz indeed) and send another patch for review.

Best regards,
Jyri


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel