From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14A21C64ED8 for ; Mon, 27 Feb 2023 09:00:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2753910E37C; Mon, 27 Feb 2023 09:00:37 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62C8910E37D; Mon, 27 Feb 2023 09:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677488435; x=1709024435; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=xB3vrBV7K2wutMJySEbjon3p/JiP638bbjPY5JzZSnY=; b=Ww7ylsCDBtd03d3bTRTZ/9lATp4yaZslc45k6Pp1y04GGgbmFhu4bLJz VdFyZSVsD9fppKU8DliykLdqvxlycADN33k7ZhNqanXEpmWHm28YKfagA jCf82tNjKgAGzi3EAlXUumKPUZbUM7f49Bm7rFAlXGuGIWI5wL5ajo5d1 CmzTZLCzDRJflZMN3CptTKpHtIwCD8WPwDa0Lxxj6UxlsvjpjMOHZKV0e AL8wjkqNhuMFQq5x5eGUBeqDN69jS2njS7cfbAXUzliyJlXZg3NcIvMdQ 3nK4XTsmr99xUEqJFIzCcz062UFQCJrI3o7gdnEknhiJXiI6RwBgVtAoj Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="420078535" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="420078535" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:00:34 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="675780616" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="675780616" Received: from flayounx-mobl.ger.corp.intel.com (HELO [10.249.254.249]) ([10.249.254.249]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:00:30 -0800 Message-ID: Date: Mon, 27 Feb 2023 10:00:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic Content-Language: en-US To: Maarten Lankhorst , dri-devel@lists.freedesktop.org, Daniel Vetter , Dave Airlie References: <20230224095152.30134-1-thomas.hellstrom@linux.intel.com> <6cddb602-31dd-8854-25dc-11afe9b1a275@linux.intel.com> <6f0b5231-a9c2-e31e-f2d6-61f403d2f94d@lankhorst.se> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: <6f0b5231-a9c2-e31e-f2d6-61f403d2f94d@lankhorst.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Christian Koenig , intel-xe@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Maarten, On 2/27/23 09:55, Maarten Lankhorst wrote: > Hey, > > I can push this to drm-misc-next, I don't think a drm maintainer ack > is needed, as long as we have the acks from the amd folk for merging > through drm-misc-next. > OK, sound good, we have that ack so please go ahead! /Thomas > ~Maarten > > On 2023-02-27 09:11, Thomas Hellström wrote: >> Daniel, Dave >> >> Ack to merge this to drm through drm-misc-next? >> >> /Thomas >> >> >> On 2/24/23 10:51, Thomas Hellström wrote: >>> This series (or at least the suballocator helper) is a prerequisite >>> for the new Xe driver. >>> >>> There was an unresolved issue when the series was last up for review, >>> and that was the per allocation aligment. Last message was from >>> Maarten Lankhorst arguing that the larger per-driver alignment used >>> would only incur a small memory cost. This new variant resolves that. >>> >>> The generic suballocator has been tested with the Xe driver, and a >>> kunit test is under development. >>> The amd- and radeon adaptations are only compile-tested. >>> >>> v3: >>> - Remove stale author information (Christian König) >>> - Update Radeon Kconfig (Thomas Hellström) >>> >>> v4: >>> - Avoid 64-bit integer divisions (kernel test robot ) >>> - Use size_t rather than u64 for the managed range. (Thomas) >>> >>> >>> Maarten Lankhorst (3): >>>    drm/suballoc: Extract amdgpu_sa.c as generic suballocation helper >>>    drm/amd: Convert amdgpu to use suballocation helper. >>>    drm/radeon: Use the drm suballocation manager implementation. >>> >>>   drivers/gpu/drm/Kconfig                    |   4 + >>>   drivers/gpu/drm/Makefile                   |   3 + >>>   drivers/gpu/drm/amd/amdgpu/Kconfig         |   1 + >>>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  26 +- >>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c     |   5 +- >>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |  23 +- >>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h   |   3 +- >>>   drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c     | 324 +-------------- >>>   drivers/gpu/drm/drm_suballoc.c             | 457 >>> +++++++++++++++++++++ >>>   drivers/gpu/drm/radeon/Kconfig             |   1 + >>>   drivers/gpu/drm/radeon/radeon.h            |  55 +-- >>>   drivers/gpu/drm/radeon/radeon_ib.c         |  12 +- >>>   drivers/gpu/drm/radeon/radeon_object.h     |  25 +- >>>   drivers/gpu/drm/radeon/radeon_sa.c         | 316 ++------------ >>>   drivers/gpu/drm/radeon/radeon_semaphore.c  |   4 +- >>>   include/drm/drm_suballoc.h                 | 108 +++++ >>>   16 files changed, 674 insertions(+), 693 deletions(-) >>>   create mode 100644 drivers/gpu/drm/drm_suballoc.c >>>   create mode 100644 include/drm/drm_suballoc.h >>>