From: Marek Vasut <marex@denx.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH V2] drm: simple_kms_helper: Add prepare_fb and cleanup_fb hooks
Date: Sun, 2 Oct 2016 18:49:15 +0200 [thread overview]
Message-ID: <f292cb4e-41ef-a047-9dba-2059c1ae8c48@denx.de> (raw)
In-Reply-To: <CAKMK7uHyAKi6DJaoERnc0SDWXPXYt_6LZ0YUMxSF12CejR24yQ@mail.gmail.com>
On 09/30/2016 11:58 AM, Daniel Vetter wrote:
> On Thu, Sep 29, 2016 at 11:58 PM, Marek Vasut <marex@denx.de> wrote:
>> + /**
>> + * @prepare_fb:
>> + *
>> + * Optional, called by struct &drm_plane_helper_funcs ->prepare_fb .
>> + */
>
>
> You've lost the hint that people should look there for what this hook
> should do. Same with cleanup_fb. I think that was useful, can you pls
> reinsert it? Just something like "Please read the documentation for
> the ->prepare_fb hook in &drm_plane_helper_funcs for more details."
OK, added.
--
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-10-02 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 21:58 [PATCH V2] drm: simple_kms_helper: Add prepare_fb and cleanup_fb hooks Marek Vasut
2016-09-30 9:58 ` Daniel Vetter
2016-10-02 16:49 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f292cb4e-41ef-a047-9dba-2059c1ae8c48@denx.de \
--to=marex@denx.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).