Re: [PATCH] backlight/arcxcnn support newer chips in arcxcnn family and fix vendor prefix

From: Brian Dodge <bdodge09@gmail.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: mark.rutland@arm.com, jingoohan1@gmail.com,
	dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
	jacek.anaszewski@gmail.com, pavel@ucw.cz, lee.jones@linaro.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH] backlight/arcxcnn support newer chips in arcxcnn family and fix vendor prefix
Date: Mon, 5 Nov 2018 20:34:12 -0500	[thread overview]
Message-ID: <f2a94633-e45f-72da-7884-cc4b559eec1f@gmail.com> (raw)
In-Reply-To: <20181103165827.j7yjujcakwg42owp@holly.lan>

Apologies, this patch submission was not done properly and not submitted 
properly.

I have prepared a new patch set which breaks this work into three 
distinct patches.

Brian

On 11/3/18 12:58 PM, Daniel Thompson wrote:
> On Thu, Nov 01, 2018 at 06:49:01PM -0400, Brian Dodge wrote:
>> Support for ArcticSand arc1 and arc3 ships is added. Some ranges
>> and control paths are modified based on the chip id probed via
>> i2c.
> This...
>
>
>> Also updates vendor prefix to arctic from arc which was a
>> mistake in the original driver submission
> ... and this looks like they would be better placed into separate
> patches.
>
>
>> Signed-off-by: Brian Dodge <bdodge09@gmail.com>
> This looks very similar to your patch of 10 minutes ago. Is it an
> updated version? Sorry to get all procedural on you but if it is
> an update then bumping the version number and summary of changes
> would be helpful (even if the change summary is just "decided to
> rewrite the patch header to improve clarity").
>
>
> Daniel.
>
>
>> ---
>>   .../bindings/leds/backlight/arcxcnn_bl.txt           | 20 ++++++++++----------
>>   1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
>> index dcaa239..230abde 100644
>> --- a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
>> +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
>> @@ -1,8 +1,8 @@
>> -Binding for ArcticSand arc family LED drivers
>> +Binding for ArcticSand arc2c0608 LED driver
>>   
>>   Required properties:
>> -- compatible:	"arctic,arc1c0608", "arctic,arc2c0608", "arctic,arc3c0845"
>> -- reg:		slave address
>> +- compatible:		should be "arc,arc2c0608"
>> +- reg:			slave address
>>   
>>   Optional properties:
>>   - default-brightness:	brightness value on boot, value from: 0-4095
>> @@ -11,19 +11,19 @@ Optional properties:
>>   - led-sources:		List of enabled channels from 0 to 5.
>>   			See Documentation/devicetree/bindings/leds/common.txt
>>   
>> -- arctic,led-config-0:	setting for register ILED_CONFIG_0
>> -- arctic,led-config-1:	setting for register ILED_CONFIG_1
>> -- arctic,dim-freq:		PWM mode frequence setting (bits [3:0] used)
>> -- arctic,comp-config:	setting for register CONFIG_COMP
>> -- arctic,filter-config:	setting for register FILTER_CONFIG
>> -- arctic,trim-config:	setting for register IMAXTUNE
>> +- arc,led-config-0:	setting for register ILED_CONFIG_0
>> +- arc,led-config-1:	setting for register ILED_CONFIG_1
>> +- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
>> +- arc,comp-config:	setting for register CONFIG_COMP
>> +- arc,filter-config:	setting for register FILTER_CONFIG
>> +- arc,trim-config:	setting for register IMAXTUNE
>>   
>>   Note: Optional properties not specified will default to values in IC EPROM
>>   
>>   Example:
>>   
>>   arc2c0608@30 {
>> -	compatible = "arctic,arc2c0608";
>> +	compatible = "arc,arc2c0608";
>>   	reg = <0x30>;
>>   	default-brightness = <500>;
>>   	label = "lcd-backlight";
>> -- 
>> 2.7.4
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel