From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2AD0C4167B for ; Tue, 5 Dec 2023 13:15:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 179D010E52A; Tue, 5 Dec 2023 13:15:01 +0000 (UTC) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73FC110E52A for ; Tue, 5 Dec 2023 13:14:59 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id C3CF2580900; Tue, 5 Dec 2023 08:14:58 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 05 Dec 2023 08:14:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701782098; x=1701789298; bh=ei yfcAaW8S/0cnNR5qvKPP9FPzFqObUKOJebJtjaT4g=; b=grEmVeOgHZVU7k2UVR fBuDBLbJtVcdW6JHwpmkRQOApCRyKxLEPPbBQzSFuGL7pTWsUpTnLuLG18JTYSdd r5Ie73b5CxmXV8agvJPks974YXcGcy9PCXZ6SudrBJOn9Si8ehblp8Swj1R/5MFm 0OiWwOsjtefr1JtV2s8B5Z4qdSbziOgyuJH0hZ2Ptm9EE0gppXezrqY08o1pieKU +xigXIbh42rBl2cShzh/dUzqQFJbJLwXAXBOaasKUKMfFc9Y7iBA5CgXSmie6Izq 5ARk+IM3wPGouVUagkm2l3Vu1LYB2frX+EvdD1CyH78dRJQVAgjHL5AH+CXprc+j eI6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701782098; x=1701789298; bh=eiyfcAaW8S/0c nNR5qvKPP9FPzFqObUKOJebJtjaT4g=; b=f1yaUVrL++5MAMGC4cbmDB8dljjUb fA3lfwnxZjPejU0/Xn2sD/whZSTKRDuZTUihGKPhegGz3zDPQO80bET8uckJnIvv 7y7PEYD6gbBGENnRb59ZCJi3Zl8gJYapj2XHp3vS8TuLlZzT0uEvLwWcFPUO4WLJ yT/0WVD6yOcD4+qAk903M1U6dfn+rR6q2UXKCKe+rgZ4b48nCc5rMEjIpUoVCTZl D7oYFZ7J7OgmonTbT7881/tS56EXD3DMx5+yQ0iDU8vAXa/nIFIhEC8zNDxmomr8 pcKmyWIefGXUiHqzCIL9+KOMlhWiIJRaPTn0qgpNbex16PwKdznwA/xUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejkedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7F054B60089; Tue, 5 Dec 2023 08:14:57 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 MIME-Version: 1.0 Message-Id: In-Reply-To: <76bbd45b22ef6cc1fa69369aff908c9c4e366860.1701768028.git.ysato@users.sourceforge.jp> References: <76bbd45b22ef6cc1fa69369aff908c9c4e366860.1701768028.git.ysato@users.sourceforge.jp> Date: Tue, 05 Dec 2023 14:14:37 +0100 From: "Arnd Bergmann" To: "Yoshinori Sato" , linux-sh@vger.kernel.org Subject: Re: [DO NOT MERGE v5 06/37] sh: kernel/setup Update DT support. Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , linux-fbdev@vger.kernel.org, Rich Felker , Herve Codina , Geert Uytterhoeven , Bin Meng , Michael Turquette , linux-pci@vger.kernel.org, Jacky Huang , Palmer Dabbelt , Max Filippov , guoren , Lee Jones , Krzysztof Kozlowski , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jiri Slaby , linux-clk@vger.kernel.org, Stephen Rothwell , Laurent Pinchart , Baoquan He , Jonathan Corbet , Helge Deller , Daniel Lezcano , Magnus Damm , Javier Martinez Canillas , Jernej Skrabec , linux-serial@vger.kernel.org, David Rientjes , Lukas Bulwahn , Lorenzo Pieralisi , Guenter Roeck , devicetree@vger.kernel.org, Conor Dooley , Thomas Zimmermann , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Maxime Ripard , Sam Ravnborg , Rob Herring , dri-devel@lists.freedesktop.org, Chris Morgan , John Paul Adrian Glaubitz , Bjorn Helgaas , Thomas Gleixner , Vlastimil Babka , Sergey Shtylyov , linux-ide@vger.kernel.org, Stephen Boyd , Greg Kroah-Hartman , Randy Dunlap , Biju Das , linux-kernel@vger.kernel.org, Azeem Shaikh , Linux-Renesas , Tom Rix , Damien Le Moal , Michael Karcher , Andrew Morton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > Fix extrnal fdt initialize and bootargs. > > Signed-off-by: Yoshinori Sato > --- > arch/sh/kernel/setup.c | 51 ++++++++++++++++++++++++++++-------------- > 1 file changed, 34 insertions(+), 17 deletions(-) > > diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c > index 3d80515298d2..b299abff68e0 100644 > --- a/arch/sh/kernel/setup.c > +++ b/arch/sh/kernel/setup.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -74,7 +75,13 @@ extern int root_mountflags; > #define RAMDISK_PROMPT_FLAG 0x8000 > #define RAMDISK_LOAD_FLAG 0x4000 > > +#if defined(CONFIG_OF) && !defined(CONFIG_USE_BUILTIN_DTB) > +#define CHOSEN_BOOTARGS > +#endif > + > +#ifndef CHOSEN_BOOTARGS > static char __initdata command_line[COMMAND_LINE_SIZE] = { 0, }; > +#endif I think an appended DTB is generally better than a built-in one, as that allows you to still have a single kernel image across machines and just pick the dtb when installing it. With everything else being equal, I would suggest not actually making this an option for new platforms. Arnd