From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 4/4] video: sm501fb: Adjust 15 checks for null pointers Date: Sun, 26 Nov 2017 11:22:07 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.web.de (mout.web.de [212.227.15.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 04A2689D6C for ; Sun, 26 Nov 2017 10:23:29 +0000 (UTC) In-Reply-To: Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Alexey Khoroshilov , Bartlomiej Zolnierkiewicz , Bhumika Goyal , Colin Ian King , "Gustavo A. R. Silva" , Sudip Mukherjee Cc: kernel-janitors@vger.kernel.org, LKML List-Id: dri-devel@lists.freedesktop.org RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgpEYXRl OiBTdW4sIDI2IE5vdiAyMDE3IDEwOjU2OjQ2ICswMTAwCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRl bnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA4Yml0CgpUaGUgc2NyaXB0IOKAnGNoZWNrcGF0Y2gucGzigJ0gcG9pbnRlZCBpbmZvcm1h dGlvbiBvdXQgbGlrZSB0aGUgZm9sbG93aW5nLgoKQ29tcGFyaXNvbiB0byBOVUxMIGNvdWxkIGJl IHdyaXR0ZW4gIeKApgoKVGh1cyBmaXggdGhlIGFmZmVjdGVkIHNvdXJjZSBjb2RlIHBsYWNlcy4K ClNpZ25lZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdl Lm5ldD4KLS0tCiBkcml2ZXJzL3ZpZGVvL2ZiZGV2L3NtNTAxZmIuYyB8IDMxICsrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAx NyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3NtNTAxZmIu YyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvc201MDFmYi5jCmluZGV4IGYzOGUzNzczY2NjMC4uMzEz YWNjODNiYjcxIDEwMDY0NAotLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3NtNTAxZmIuYworKysg Yi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3NtNTAxZmIuYwpAQCAtMTQ4NCw3ICsxNDg0LDcgQEAgc3Rh dGljIGludCBzbTUwMV9pbml0X2N1cnNvcihzdHJ1Y3QgZmJfaW5mbyAqZmJpLCB1bnNpZ25lZCBp bnQgcmVnX2Jhc2UpCiAJc3RydWN0IHNtNTAxZmJfaW5mbyAqaW5mbzsKIAlpbnQgcmV0OwogCi0J aWYgKGZiaSA9PSBOVUxMKQorCWlmICghZmJpKQogCQlyZXR1cm4gMDsKIAogCXBhciA9IGZiaS0+ cGFyOwpAQCAtMTUzMiw3ICsxNTMyLDcgQEAgc3RhdGljIGludCBzbTUwMWZiX3N0YXJ0KHN0cnVj dCBzbTUwMWZiX2luZm8gKmluZm8sCiAJLyogYWxsb2NhdGUsIHJlc2VydmUgYW5kIHJlbWFwIHJl c291cmNlcyBmb3IgZGlzcGxheQogCSAqIGNvbnRyb2xsZXIgcmVnaXN0ZXJzICovCiAJcmVzID0g cGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsKLQlpZiAocmVz ID09IE5VTEwpIHsKKwlpZiAoIXJlcykgewogCQlkZXZfZXJyKGRldiwgIm5vIHJlc291cmNlIGRl ZmluaXRpb24gZm9yIHJlZ2lzdGVyc1xuIik7CiAJCXJldCA9IC1FTk9FTlQ7CiAJCWdvdG8gZXJy X3JlbGVhc2U7CkBAIC0xNTQxLDE1ICsxNTQxLDE0IEBAIHN0YXRpYyBpbnQgc201MDFmYl9zdGFy dChzdHJ1Y3Qgc201MDFmYl9pbmZvICppbmZvLAogCWluZm8tPnJlZ3NfcmVzID0gcmVxdWVzdF9t ZW1fcmVnaW9uKHJlcy0+c3RhcnQsCiAJCQkJCSAgICByZXNvdXJjZV9zaXplKHJlcyksCiAJCQkJ CSAgICBwZGV2LT5uYW1lKTsKLQotCWlmIChpbmZvLT5yZWdzX3JlcyA9PSBOVUxMKSB7CisJaWYg KCFpbmZvLT5yZWdzX3JlcykgewogCQlkZXZfZXJyKGRldiwgImNhbm5vdCBjbGFpbSByZWdpc3Rl cnNcbiIpOwogCQlyZXQgPSAtRU5YSU87CiAJCWdvdG8gZXJyX3JlbGVhc2U7CiAJfQogCiAJaW5m by0+cmVncyA9IGlvcmVtYXAocmVzLT5zdGFydCwgcmVzb3VyY2Vfc2l6ZShyZXMpKTsKLQlpZiAo aW5mby0+cmVncyA9PSBOVUxMKSB7CisJaWYgKCFpbmZvLT5yZWdzKSB7CiAJCWRldl9lcnIoZGV2 LCAiY2Fubm90IHJlbWFwIHJlZ2lzdGVyc1xuIik7CiAJCXJldCA9IC1FTlhJTzsKIAkJZ290byBl cnJfcmVnc19yZXM7CkBAIC0xNTU4LDcgKzE1NTcsNyBAQCBzdGF0aWMgaW50IHNtNTAxZmJfc3Rh cnQoc3RydWN0IHNtNTAxZmJfaW5mbyAqaW5mbywKIAkvKiBhbGxvY2F0ZSwgcmVzZXJ2ZSBhbmQg cmVtYXAgcmVzb3VyY2VzIGZvciAyZAogCSAqIGNvbnRyb2xsZXIgcmVnaXN0ZXJzICovCiAJcmVz ID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAxKTsKLQlpZiAo cmVzID09IE5VTEwpIHsKKwlpZiAoIXJlcykgewogCQlkZXZfZXJyKGRldiwgIm5vIHJlc291cmNl IGRlZmluaXRpb24gZm9yIDJkIHJlZ2lzdGVyc1xuIik7CiAJCXJldCA9IC1FTk9FTlQ7CiAJCWdv dG8gZXJyX3JlZ3NfbWFwOwpAQCAtMTU2NywxNSArMTU2NiwxNCBAQCBzdGF0aWMgaW50IHNtNTAx ZmJfc3RhcnQoc3RydWN0IHNtNTAxZmJfaW5mbyAqaW5mbywKIAlpbmZvLT5yZWdzMmRfcmVzID0g cmVxdWVzdF9tZW1fcmVnaW9uKHJlcy0+c3RhcnQsCiAJCQkJCSAgICAgIHJlc291cmNlX3NpemUo cmVzKSwKIAkJCQkJICAgICAgcGRldi0+bmFtZSk7Ci0KLQlpZiAoaW5mby0+cmVnczJkX3JlcyA9 PSBOVUxMKSB7CisJaWYgKCFpbmZvLT5yZWdzMmRfcmVzKSB7CiAJCWRldl9lcnIoZGV2LCAiY2Fu bm90IGNsYWltIHJlZ2lzdGVyc1xuIik7CiAJCXJldCA9IC1FTlhJTzsKIAkJZ290byBlcnJfcmVn c19tYXA7CiAJfQogCiAJaW5mby0+cmVnczJkID0gaW9yZW1hcChyZXMtPnN0YXJ0LCByZXNvdXJj ZV9zaXplKHJlcykpOwotCWlmIChpbmZvLT5yZWdzMmQgPT0gTlVMTCkgeworCWlmICghaW5mby0+ cmVnczJkKSB7CiAJCWRldl9lcnIoZGV2LCAiY2Fubm90IHJlbWFwIHJlZ2lzdGVyc1xuIik7CiAJ CXJldCA9IC1FTlhJTzsKIAkJZ290byBlcnJfcmVnczJkX3JlczsKQEAgLTE1ODMsNyArMTU4MSw3 IEBAIHN0YXRpYyBpbnQgc201MDFmYl9zdGFydChzdHJ1Y3Qgc201MDFmYl9pbmZvICppbmZvLAog CiAJLyogYWxsb2NhdGUsIHJlc2VydmUgcmVzb3VyY2VzIGZvciBmcmFtZWJ1ZmZlciAqLwogCXJl cyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMik7Ci0JaWYg KHJlcyA9PSBOVUxMKSB7CisJaWYgKCFyZXMpIHsKIAkJZGV2X2VycihkZXYsICJubyBtZW1vcnkg cmVzb3VyY2UgZGVmaW5lZFxuIik7CiAJCXJldCA9IC1FTlhJTzsKIAkJZ290byBlcnJfcmVnczJk X21hcDsKQEAgLTE1OTIsMTQgKzE1OTAsMTQgQEAgc3RhdGljIGludCBzbTUwMWZiX3N0YXJ0KHN0 cnVjdCBzbTUwMWZiX2luZm8gKmluZm8sCiAJaW5mby0+ZmJtZW1fcmVzID0gcmVxdWVzdF9tZW1f cmVnaW9uKHJlcy0+c3RhcnQsCiAJCQkJCSAgICAgcmVzb3VyY2Vfc2l6ZShyZXMpLAogCQkJCQkg ICAgIHBkZXYtPm5hbWUpOwotCWlmIChpbmZvLT5mYm1lbV9yZXMgPT0gTlVMTCkgeworCWlmICgh aW5mby0+ZmJtZW1fcmVzKSB7CiAJCWRldl9lcnIoZGV2LCAiY2Fubm90IGNsYWltIGZyYW1lYnVm ZmVyXG4iKTsKIAkJcmV0ID0gLUVOWElPOwogCQlnb3RvIGVycl9yZWdzMmRfbWFwOwogCX0KIAog CWluZm8tPmZibWVtID0gaW9yZW1hcChyZXMtPnN0YXJ0LCByZXNvdXJjZV9zaXplKHJlcykpOwot CWlmIChpbmZvLT5mYm1lbSA9PSBOVUxMKSB7CisJaWYgKCFpbmZvLT5mYm1lbSkgewogCQlkZXZf ZXJyKGRldiwgImNhbm5vdCByZW1hcCBmcmFtZWJ1ZmZlclxuIik7CiAJCXJldCA9IC1FTlhJTzsK IAkJZ290byBlcnJfbWVtX3JlczsKQEAgLTE4NjIsMTMgKzE4NjAsMTMgQEAgc3RhdGljIGludCBz bTUwMWZiX3Byb2JlX29uZShzdHJ1Y3Qgc201MDFmYl9pbmZvICppbmZvLAogCXBkID0gKGhlYWQg PT0gSEVBRF9DUlQpID8gaW5mby0+cGRhdGEtPmZiX2NydCA6IGluZm8tPnBkYXRhLT5mYl9wbmw7 CiAKIAkvKiBEbyBub3QgaW5pdGlhbGlzZSBpZiB3ZSd2ZSBub3QgYmVlbiBnaXZlbiBhbnkgcGxh dGZvcm0gZGF0YSAqLwotCWlmIChwZCA9PSBOVUxMKSB7CisJaWYgKCFwZCkgewogCQlkZXZfaW5m byhpbmZvLT5kZXYsICJubyBkYXRhIGZvciBmYiAlcyAoZGlzYWJsZWQpXG4iLCBuYW1lKTsKIAkJ cmV0dXJuIDA7CiAJfQogCiAJZmJpID0gZnJhbWVidWZmZXJfYWxsb2Moc2l6ZW9mKHN0cnVjdCBz bTUwMWZiX3BhciksIGluZm8tPmRldik7Ci0JaWYgKGZiaSA9PSBOVUxMKSB7CisJaWYgKCFmYmkp IHsKIAkJZGV2X2VycihpbmZvLT5kZXYsICJjYW5ub3QgYWxsb2NhdGUgJXMgZnJhbWVidWZmZXJc biIsIG5hbWUpOwogCQlyZXR1cm4gLUVOT01FTTsKIAl9CkBAIC0xOTQ0LDcgKzE5NDIsNyBAQCBz dGF0aWMgaW50IHNtNTAxZmJfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAkJ aW5mby0+cGRhdGEgPSBwZC0+ZmI7CiAJfQogCi0JaWYgKGluZm8tPnBkYXRhID09IE5VTEwpIHsK KwlpZiAoIWluZm8tPnBkYXRhKSB7CiAJCWludCBmb3VuZCA9IDA7CiAjaWYgZGVmaW5lZChDT05G SUdfT0YpCiAJCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAgPSBwZGV2LT5kZXYucGFyZW50LT5vZl9u b2RlOwpAQCAtMTk4Nyw4ICsxOTg1LDcgQEAgc3RhdGljIGludCBzbTUwMWZiX3Byb2JlKHN0cnVj dCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAJCWdvdG8gZXJyX3Byb2JlZF9jcnQ7CiAJfQogCi0J aWYgKGluZm8tPmZiW0hFQURfUEFORUxdID09IE5VTEwgJiYKLQkgICAgaW5mby0+ZmJbSEVBRF9D UlRdID09IE5VTEwpIHsKKwlpZiAoIWluZm8tPmZiW0hFQURfUEFORUxdICYmICFpbmZvLT5mYltI RUFEX0NSVF0pIHsKIAkJZGV2X2VycihkZXYsICJubyBmcmFtZWJ1ZmZlcnMgZm91bmRcbiIpOwog CQlyZXQgPSAtRU5PREVWOwogCQlnb3RvIGVycl9hbGxvYzsKLS0gCjIuMTUuMAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==