From: "Christian König" <christian.koenig@amd.com>
To: Dave Airlie <airlied@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/ttm: ttm_bo_mem_placement doesn't need ctx parameter.
Date: Wed, 21 Oct 2020 11:59:26 +0200 [thread overview]
Message-ID: <f3cd8b5f-5a89-ecce-9aa3-a329c0c0e524@amd.com> (raw)
In-Reply-To: <20201021044031.1752624-3-airlied@gmail.com>
Am 21.10.20 um 06:40 schrieb Dave Airlie:
> From: Dave Airlie <airlied@redhat.com>
>
> Removed unused parameter.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index e2afab3d97ee..5b411252a857 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -830,7 +830,6 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
> * @bo: BO to find memory for
> * @place: where to search
> * @mem: the memory object to fill in
> - * @ctx: operation context
> *
> * Check if placement is compatible and fill in mem structure.
> * Returns -EBUSY if placement won't work or negative error code.
> @@ -838,8 +837,7 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
> */
> static int ttm_bo_mem_placement(struct ttm_buffer_object *bo,
> const struct ttm_place *place,
> - struct ttm_resource *mem,
> - struct ttm_operation_ctx *ctx)
> + struct ttm_resource *mem)
> {
> struct ttm_bo_device *bdev = bo->bdev;
> struct ttm_resource_manager *man;
> @@ -884,7 +882,7 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
> const struct ttm_place *place = &placement->placement[i];
> struct ttm_resource_manager *man;
>
> - ret = ttm_bo_mem_placement(bo, place, mem, ctx);
> + ret = ttm_bo_mem_placement(bo, place, mem);
> if (ret)
> continue;
>
> @@ -910,7 +908,7 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
> for (i = 0; i < placement->num_busy_placement; ++i) {
> const struct ttm_place *place = &placement->busy_placement[i];
>
> - ret = ttm_bo_mem_placement(bo, place, mem, ctx);
> + ret = ttm_bo_mem_placement(bo, place, mem);
> if (ret)
> continue;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-21 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 4:40 [PATCH 0/3] ttm: change move notify + revised multi hop patch Dave Airlie
2020-10-21 4:40 ` [PATCH 1/3] drm/ttm: replace last move_notify with delete_mem_notify Dave Airlie
2020-10-21 9:58 ` Christian König
2020-10-28 9:16 ` Daniel Vetter
2020-10-28 9:53 ` Christian König
2020-10-28 10:19 ` Daniel Vetter
2020-10-21 4:40 ` [PATCH 2/3] drm/ttm: ttm_bo_mem_placement doesn't need ctx parameter Dave Airlie
2020-10-21 9:59 ` Christian König [this message]
2020-10-21 4:40 ` [PATCH 3/3] drm/ttm: avoid multihop moves in drivers Dave Airlie
2020-10-21 8:33 ` Daniel Vetter
2020-10-21 10:58 ` Christian König
2020-10-28 2:02 ` Dave Airlie
2020-10-28 9:39 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3cd8b5f-5a89-ecce-9aa3-a329c0c0e524@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox