From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Adam Skladowski <a39.skl@gmail.com>
Cc: freedreno@lists.freedesktop.org,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, David Airlie <airlied@gmail.com>,
Andy Gross <agross@kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
~postmarketos/upstreaming@lists.sr.ht,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
phone-devel@vger.kernel.org, Sean Paul <sean@poorly.run>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH 5/8] dt-bindings: drm/msm/gpu: Document AON clock for A506/A510
Date: Mon, 22 Jan 2024 09:51:59 +0100 [thread overview]
Message-ID: <f525b63f-a32c-41cf-b80f-5d85b6eb50c8@linaro.org> (raw)
In-Reply-To: <20240121194221.13513-6-a39.skl@gmail.com>
On 21/01/2024 20:41, Adam Skladowski wrote:
> Adreno 506(MSM8953) and Adreno 510(MSM8976) require
> Always-on branch clock to be enabled, describe it.
>
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
> Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index b019db954793..9e36f54a5caf 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -133,7 +133,7 @@ allOf:
> properties:
> clocks:
> minItems: 2
> - maxItems: 7
> + maxItems: 8
I would prefer we start enforcing the order. The initial flexibility was
because of conversion from the old bindings and dealing with some
technical debt, AFAIU.
This is requirement of new clock, so maybe better add dedicated if:then
case which will be enforcing the order with always-on at the end.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-22 8:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 19:40 [PATCH 0/8] MSM8976 MDSS/GPU/WCNSS support Adam Skladowski
2024-01-21 19:40 ` [PATCH 1/8] arm64: dts: qcom: msm8976: Add IOMMU nodes Adam Skladowski
2024-02-06 19:08 ` Konrad Dybcio
2024-01-21 19:41 ` [PATCH 2/8] dt-bindings: dsi-controller-main: Document missing msm8976 compatible Adam Skladowski
2024-01-22 8:47 ` Krzysztof Kozlowski
2024-01-21 19:41 ` [PATCH 3/8] dt-bindings: msm: qcom, mdss: Include ommited fam-b compatible Adam Skladowski
2024-01-22 8:48 ` [PATCH 3/8] dt-bindings: msm: qcom,mdss: " Krzysztof Kozlowski
2024-02-06 7:27 ` [PATCH 3/8] dt-bindings: msm: qcom, mdss: " Dmitry Baryshkov
2024-02-06 7:38 ` [PATCH 3/8] dt-bindings: msm: qcom,mdss: " Krzysztof Kozlowski
2024-01-21 19:41 ` [PATCH 4/8] arm64: dts: qcom: msm8976: Add MDSS nodes Adam Skladowski
2024-02-09 21:29 ` Konrad Dybcio
2024-01-21 19:41 ` [PATCH 5/8] dt-bindings: drm/msm/gpu: Document AON clock for A506/A510 Adam Skladowski
2024-01-22 8:51 ` Krzysztof Kozlowski [this message]
2024-01-21 19:41 ` [PATCH 6/8] arm64: dts: qcom: msm8976: Add Adreno GPU Adam Skladowski
2024-02-09 21:32 ` Konrad Dybcio
2024-01-21 19:41 ` [PATCH 7/8] arm64: dts: qcom: msm8976: Declare and wire SDC pins Adam Skladowski
2024-01-21 22:16 ` Marijn Suijten
2024-01-21 19:41 ` [PATCH 8/8] arm64: dts: qcom: msm8976: Add WCNSS node Adam Skladowski
2024-02-09 21:35 ` Konrad Dybcio
2024-02-19 12:30 ` [PATCH 0/8] MSM8976 MDSS/GPU/WCNSS support Dmitry Baryshkov
2024-05-28 3:32 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f525b63f-a32c-41cf-b80f-5d85b6eb50c8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).