From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v7 1/5] leds: populate the device's of_node when possible Date: Tue, 24 Sep 2019 23:03:37 +0200 Message-ID: References: <20190918145730.22805-1-jjhiblot@ti.com> <20190918145730.22805-2-jjhiblot@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190918145730.22805-2-jjhiblot@ti.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jean-Jacques Hiblot , pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, lee.jones@linaro.org, daniel.thompson@linaro.org Cc: dmurphy@ti.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com List-Id: dri-devel@lists.freedesktop.org Hi Jean, Thank you for rebasing the set On 9/18/19 4:57 PM, Jean-Jacques Hiblot wrote: > If initialization data is available and its fwnode is actually a of_node, > store this information in the led device's structure. This will allow the > device to use or provide OF-based API such (devm_xxx). > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/leds/led-class.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > index 647b1263c579..c2167b66b61f 100644 > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -276,8 +276,11 @@ int led_classdev_register_ext(struct device *parent, > mutex_unlock(&led_cdev->led_access); > return PTR_ERR(led_cdev->dev); > } > - if (init_data && init_data->fwnode) > + if (init_data && init_data->fwnode) { > led_cdev->dev->fwnode = init_data->fwnode; > + if (is_of_node(init_data->fwnode)) > + led_cdev->dev->of_node = to_of_node(init_data->fwnode); It would be step backwards. You can do the conversion in the place of use i.e. in devm_led_get(). > + } > > if (ret) > dev_warn(parent, "Led %s renamed to %s due to name collision", > -- Best regards, Jacek Anaszewski