From: Chris Wilson <chris@chris-wilson.co.uk>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: wake up all pageflip waiters
Date: Mon, 17 Dec 2012 19:24:45 +0000 [thread overview]
Message-ID: <f5ae8a$7ta5ij@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1355759940-7464-3-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 17 Dec 2012 16:59:00 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Otherwise it seems like we can get stuck with concurrent waiters.
> Right now this /shouldn't/ be a problem, since all pending pageflip
> waiters are serialized by the one mode_config.mutex, so there's at
> most on waiter. But better paranoid than sorry, since this is tricky
> code.
Hmm.
BUG_ON(waitqueue_active()) before joining the waitqueue?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-12-17 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 15:58 [PATCH 0/2] Two patches for pageflips Daniel Vetter
2012-12-17 15:58 ` [PATCH 1/2] drm/fb_helper: check whether fbcon is bound Daniel Vetter
2012-12-17 15:59 ` [PATCH 2/2] drm/i915: wake up all pageflip waiters Daniel Vetter
2012-12-17 19:24 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f5ae8a$7ta5ij@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox